patch for new RS690 card id (Gigabyte MA69GM-S2H motherboard)
Hello all, I've added a patch to recognise my (microATX) 690G motherboard; according to the xorg.log file, it looks like my mb uses the same atom bios as the -S3H mother board (the ATX version of my motherboard), so I don't know whether the code should be quite so specific about what it has identified; what do you think? Let me know if there's anything I can do to help. Tim Here's a snippet of the xorg.log after the patch: (--) RADEONHD(0): Detected an RS690 on a Gigabyte MA69GM-S2H (II) RADEONHD(0): Mapped IO at 0x2b4ff49ce000 (size 0x00010000) (II) RADEONHD(0): Getting BIOS copy from legacy VBIOS location (II) RADEONHD(0): ATOM BIOS Rom: SubsystemVendorID: 0x1002 SubsystemID: 0x791e IOBaseAddress: 0xee00 Filename: 69G_S3_4.bin BIOS Bootup Message: ATI Radeon Xpress for GBTMA69G-S3 and a diff: cb306d3f212df57be652d83ca04fda6376269a97 src/rhd_id.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/rhd_id.c b/src/rhd_id.c index 027fbb8..cd10016 100644 --- a/src/rhd_id.c +++ b/src/rhd_id.c @@ -553,6 +553,7 @@ rhdCards[] = /* 0x7297 : RV560 : RV560 */ /* 0x791E : RS690 : Radeon X1200 */ { 0x791E, 0x1043, 0x826D, "Asus M2A-VM", RHD_CARD_FLAG_NONE, ID_CONNECTORINFO_EMPTY }, + { 0x791E, 0x1458, 0xD001, "Gigabyte MA69GM-S2H", RHD_CARD_FLAG_NONE, ID_CONNECTORINFO_EMPTY }, /* 0x791F : RS690 : Radeon X1200 */ { 0x791F, 0x103C, 0x30C2, "HP/Compaq 6715b", RHD_CARD_FLAG_NONE, ID_CONNECTORINFO_EMPTY }, /* 0x793F : RS600 : Radeon Xpress 1200 */ -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Dec 28, 07 18:19:40 +0000, tim hughes wrote:
I've added a patch to recognise my (microATX) 690G motherboard; according to the xorg.log file, it looks like my mb uses the same atom bios as the -S3H mother board (the ATX version of my motherboard), so I don't know whether the code should be quite so specific about what it has identified; what do you think?
If you don't need any quirks for this card, it doesn't need to be
identified. So as long as the motherboard works fine (read: all outputs
work and modes are stable) we shouldn't add anything to rhd_id.c.
Historically, the table contains some non-quirks entries - now I think
we should either get rid completely of them, or move the entries (just
the names) to a different table without quirks information.
Matthias
--
Matthias Hopf
On 28/12/2007, Matthias Hopf
On Dec 28, 07 18:19:40 +0000, tim hughes wrote:
I've added a patch to recognise my (microATX) 690G motherboard; according to the xorg.log file, it looks like my mb uses the same atom bios as the -S3H mother board (the ATX version of my motherboard), so I don't know whether the code should be quite so specific about what it has identified; what do you think?
If you don't need any quirks for this card, it doesn't need to be identified. So as long as the motherboard works fine (read: all outputs work and modes are stable) we shouldn't add anything to rhd_id.c.
This makes a lot of sense - no point in listing it in the quirks table if it doesn't have quirks! I haven't tested the DVI or HDMI yet because I don't have a cable, so I'm still using VGA. :-(
Historically, the table contains some non-quirks entries - now I think we should either get rid completely of them, or move the entries (just the names) to a different table without quirks information.
As a user, I would appreciate the non-quirks table; it doesn't add any actual functionality and would add some bloat, but looking through the xorg.log file and seeing that your card has been recognised would give me some reassurance that someone somewhere has given the card a go and so it's likely to work. I do appreciate this would be low priority work though. Thanks for your feedback, sorry for the delay in answering and keep up the good work. :-) Thanks, Tim -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (2)
-
Matthias Hopf -
tim hughes