Re: [PATCH] Use XORG_CHANGELOG macro to create ChangeLog. #22611
On Jul 16, 09 14:34:41 +1000, Peter Hutterer wrote:
From: Gaetan Nadon
Adding the macro in configure.ac and use it in Makefile.am Refer to: https://bugs.freedesktop.org/show_bug.cgi?id=22611 Global maintenance on all modules
Signed-off-by: Peter Hutterer
Hm. I don't see the advantage ATM, and it has the big disadvantage that you need to have a very recent xorg-macros for autoconfig. Even the latest released openSUSE (11.1) doesn't have that. I'll keep the patch in my inbox and will apply it when it seems fit. But thanks for notifying!
--- Makefile.am | 3 +-- configure.ac | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am index 534c3fd..d254b4d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -30,9 +30,8 @@ MAINTAINERCLEANFILES = ChangeLog
.PHONY: ChangeLog
-# "git log" with the space should be available since git 1.3.0 ChangeLog: - (GIT_DIR=$(top_srcdir)/.git git log > .changelog.tmp && mv .changelog.tmp ChangeLog; rm -f .changelog.tmp) || (touch ChangeLog; echo 'git directory not found: installing possibly empty changelog.' >&2) + $(CHANGELOG_CMD)
dist-hook: ChangeLog
diff --git a/configure.ac b/configure.ac index c2f06cf..d5c6fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -16,6 +16,9 @@ AM_MAINTAINER_MODE
AC_CONFIG_FILES([shave shave-libtool])
+# Require xorg-macros: XORG_CHANGELOG +m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 or later before running autoconf/autogen])]) +XORG_MACROS_VERSION(1.2)
# Program checks. AC_DISABLE_STATIC @@ -355,6 +358,7 @@ m4_pattern_forbid([XORG_MANPAGE_SECTIONS])dnl XORG_MANPAGE_SECTIONS m4_pattern_forbid([XORG_RELEASE_VERSION])dnl XORG_RELEASE_VERSION +XORG_CHANGELOG
dnl These are also defined in XORG_RELEASE_VERSION since 2006-11-30. dnl So we check whether XORG_RELEASE_VERSION has already done this -- 1.6.3.rc1.2.g0164.dirty
Matthias
--
Matthias Hopf
On Thu, Jul 16, 2009 at 01:59:42PM +0200, Matthias Hopf wrote:
On Jul 16, 09 14:34:41 +1000, Peter Hutterer wrote:
From: Gaetan Nadon
Adding the macro in configure.ac and use it in Makefile.am Refer to: https://bugs.freedesktop.org/show_bug.cgi?id=22611 Global maintenance on all modules
Signed-off-by: Peter Hutterer
Hm. I don't see the advantage ATM, and it has the big disadvantage that you need to have a very recent xorg-macros for autoconfig. Even the latest released openSUSE (11.1) doesn't have that.
I'll keep the patch in my inbox and will apply it when it seems fit.
just a bit more background for why this patch exists: Gaetan started with repos that still used "git-log" instead of "git log". This breaks on newer releases. In the cleanup Gaeton (sensibly) also switched to the CHANGELOG_CMD macro to avoid duplication in every repo. It is not required for radeonhd though it would be nice to merge in the future to avoid duplications. That's what the macros are for after all. Cheers, Peter -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Jul 17, 09 10:28:02 +1000, Peter Hutterer wrote:
just a bit more background for why this patch exists: Gaetan started with repos that still used "git-log" instead of "git log".
Yeah, we had this issue as well quite some time ago. As we're using git more extensively in our build system, we probably noticed earlier. As 'git log' works for quite some time now (at least 1.3 I think) it was a non-issue to just change this.
It is not required for radeonhd though it would be nice to merge in the future to avoid duplications. That's what the macros are for after all.
Yes, and we definitely will use the macro soon. Unless we have a
distribution that includes this macro I refrain from applying this
patch, though, radeonhd has few developers already and I don't want to
discourage anybody.
Thanks
Matthias
--
Matthias Hopf
participants (2)
-
Matthias Hopf -
Peter Hutterer