Re: [radeonhd] xf86-video-radeonhd:master: 52 commit(s)
xf86Parser.h should never be included in a driver. Newer servers may have changed this paradigm. Still, bw compatibility will break likely. Egbert. Stefan Dirsch writes:
On Wed, Nov 21, 2007 at 07:52:38AM -0800, Matthias Hopf wrote:
commit 6ceb6870bcc2774fb6acd2b6467a091e0cac1504 Author: Matthias Hopf
Date: Tue Oct 30 15:28:31 2007 +0100 Added RandR entry point for mode validation.
diffstat: src/rhd_modes.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/rhd_modes.h | 4 + 2 files changed, 109 insertions(+)
gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=...
I needed the following patch to fix the build on imake based distributions like
- SUSE LINUX 10.0 - SUSE LINUX 10.1 - SLES10
diff -u -r ../xf86-video-radeonhd.old/src/rhd_modes.c ./src/rhd_modes.c --- ../xf86-video-radeonhd.old/src/rhd_modes.c 2007-11-21 20:53:19.000000000 +0000 +++ ./src/rhd_modes.c 2007-11-21 20:59:59.000000000 +0000 @@ -29,7 +29,6 @@
#include "xf86.h" #include "xf86DDC.h" -#include "xf86Parser.h"
#include "rhd.h" #include "rhd_crtc.h"
Without this patch a lot of symbols are defined twice. :-(
Best regards, Stefan
Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX Products GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg http://www.suse.de Germany ----------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ----------------------------------------------------------------- -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
-- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Thu, Nov 22, 2007 at 09:13:30AM +0100, Egbert Eich wrote:
xf86Parser.h should never be included in a driver. Newer servers may have changed this paradigm. Still, bw compatibility will break likely.
Thanks. This reminds me, that on most Linux distributions this file is not available at all. Probably SUSE is the only one, which ships it - due to SaX2 requirements. Best regards, Stefan Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX Products GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg http://www.suse.de Germany ----------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ----------------------------------------------------------------- -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Nov 22, 07 09:13:30 +0100, Egbert Eich wrote:
xf86Parser.h should never be included in a driver. Newer servers may have changed this paradigm. Still, bw compatibility will break likely.
I didn't add it just for the fun of it, so at the beginning of writing
the code I clearly needed it.
Doesn't seem to be the case any more, I already removed it.
Matthias
--
Matthias Hopf
participants (3)
-
Egbert Eich
-
Matthias Hopf
-
Stefan Dirsch