2009/8/17 Frieder Ferlemann :

Hi Yang,

...

    Do not log about "Unknown card detected" when AtomBIOS is available

    There's a lot of confusion about this message; time to kill it now that     AtomBIOS modesetting is significantly more stable.

Maybe additionally change the text from "Unknown card detected" to "card not found in quirk table" or something like that?

AFAIU, without AtomBIOS, we don't have generic modesetting, so any GPU not recognized is effectively unknown. I think it's appropriate to keep this working for this case. -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org

Sorry, took me much too long to actually come back to deal with this. 2009/8/18 Matthias Hopf :

On Aug 17, 09 23:51:22 -0700, Yang Zhao wrote:

...

2009/8/17 Frieder Ferlemann :

...

...

    Do not log about "Unknown card detected" when AtomBIOS is available

I do not agree with this change completely. Yes, we have received bad "bug" reports, but if we remove this message we'll probably even get more... More important, your patch removes the logging of the three-hex-numbers string, one that is *very* important for bug reports. Maybe I can rephrase that to looks less provocative.

The PCI ID is logged earlier by xserver, so I thought this wouldn't be a big issue. However, then I realized that this is the only place were we log a message about asking the mailling list for help, so it's been reverted with a modified message. The new message mentions "generic modesetting" explicitly, and gets rid of "Unknown card". I think this is an effective compromise without getting too verbose in the logs. Cheers, -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org