python-distro v 1.6.0 no longer supports Python 2.6
Hi list, I've opened this[0] SR yesterday and added a comment[1] to spark a discussion – but maybe it would be better to discuss this here. The problem with this SR is that python-distro version 1.6.0 drops support for Python 2.7, 3.4 and 3.5. But devel:languages:python/python- distro also builds for SLE_15_SP2 and openSUSE_Leap_15.2. The builds are not failing, but user would probably run into problems when using the RPM. Now there are three questions: 1. Do we want to have the version bump? 2. Wouldn't it be better to drop builds for Python 2 entirely? 3. Is the deprecation of Python 3.4 and 3.5 also causing problems? I haven't checked what is shipped in the other openSUSE/SLE versions apart from Tumbleweed. Cheers, Jochen aka brejoc [0] https://build.opensuse.org/request/show/910038 [1] https://build.opensuse.org/request/show/910038#comment-1497660
Hi Jochen, Am 04.08.21 um 14:59 schrieb Jochen Breuer:
Hi list,
I've opened this[0] SR yesterday and added a comment[1] to spark a discussion – but maybe it would be better to discuss this here.
The problem with this SR is that python-distro version 1.6.0 drops support for Python 2.7, 3.4 and 3.5. But devel:languages:python/python- distro also builds for SLE_15_SP2 and openSUSE_Leap_15.2. The builds are not failing, but user would probably run into problems when using the RPM.
I read the subject header and started to write: "SLE 15 and Leap 15.2 have Python 2.7 and 3.6. You should be fine." Then I realized you actually meant 2.7. Note that for distro 1.6.0 the support is actually only deprecated, not dropped yet: "* Deprecated Python 2.7, 3.4 and 3.5 support. Further releases will only support Python 3.6+"
Now there are three questions:
1. Do we want to have the version bump?
d:l:p is primarily for Factory. I am not a maintainer but I would say, yes. Leap builds should not block the advancement of Tumbleweed. Add `%define skip_python2 1` in the next release in order to drop the python2 build for the backport packages. You are removing the python2 package from d:l:p:backports, but the regular SLE 15 and Leap 15.2 DVDs and repos still have their python2-distro-1.5.0 package.
2. Wouldn't it be better to drop builds for Python 2 entirely?
The per package skip_python2 has the advantage that all packages still supporting python2 can continue to do so for the backports SLE/Leap targets.
3. Is the deprecation of Python 3.4 and 3.5 also causing problems? I haven't checked what is shipped in the other openSUSE/SLE versions apart from Tumbleweed.
You could add `BuildRequires: %{python_module base >= 3.6}` and `Requires: python-base >= 3.6` in order to prevent any SLE12 build, if you care about a failing package in d:l:p:backports. But you would be in the minority: devel:languages:python:backports/SLE_12_SP5 x86_64 succeeded: 18 failed: 1441 unresolvable: 1736 broken: 19 excluded: 11 I would argue to disable the SLE < 15 targets in backports and let the SUSE maintainers figure out updates for those distros internally. Very unlikely they still pull something from the Factory devel projects into SLE < 15
Cheers,
Jochen aka brejoc
[0] https://build.opensuse.org/request/show/910038 [1] https://build.opensuse.org/request/show/910038#comment-1497660
Ben
Am Mi., 4. Aug. 2021 um 15:28 Uhr schrieb Ben Greiner <code@bnavigator.de>:
Hi Jochen,
Am 04.08.21 um 14:59 schrieb Jochen Breuer:
Hi list,
I've opened this[0] SR yesterday and added a comment[1] to spark a discussion – but maybe it would be better to discuss this here.
The problem with this SR is that python-distro version 1.6.0 drops support for Python 2.7, 3.4 and 3.5. But devel:languages:python/python- distro also builds for SLE_15_SP2 and openSUSE_Leap_15.2. The builds are not failing, but user would probably run into problems when using the RPM.
I read the subject header and started to write: "SLE 15 and Leap 15.2 have Python 2.7 and 3.6. You should be fine." Then I realized you actually meant 2.7.
Note that for distro 1.6.0 the support is actually only deprecated, not dropped yet:
"* Deprecated Python 2.7, 3.4 and 3.5 support. Further releases will only support Python 3.6+"
You are right, PR #281 was not part of the 1.6.0 release and was merged afterwards. Thanks for pointing that out!
Now there are three questions:
1. Do we want to have the version bump? d:l:p is primarily for Factory. I am not a maintainer but I would say, yes. Leap builds should not block the advancement of Tumbleweed. Add `%define skip_python2 1` in the next release in order to drop the python2 build for the backport packages. You are removing the python2 package from d:l:p:backports, but the regular SLE 15 and Leap 15.2 DVDs and repos still have their python2-distro-1.5.0 package.
Sounds good! So we can still have the Python2 builds for now and disable them for what comes after 1.6.0.
2. Wouldn't it be better to drop builds for Python 2 entirely?
The per package skip_python2 has the advantage that all packages still supporting python2 can continue to do so for the backports SLE/Leap targets.
3. Is the deprecation of Python 3.4 and 3.5 also causing problems? I haven't checked what is shipped in the other openSUSE/SLE versions apart from Tumbleweed.
You could add `BuildRequires: %{python_module base >= 3.6}` and `Requires: python-base >= 3.6` in order to prevent any SLE12 build, if you care about a failing package in d:l:p:backports. But you would be in the minority:
devel:languages:python:backports/SLE_12_SP5 x86_64 succeeded: 18 failed: 1441 unresolvable: 1736 broken: 19 excluded: 11
I would argue to disable the SLE < 15 targets in backports and let the SUSE maintainers figure out updates for those distros internally. Very unlikely they still pull something from the Factory devel projects into SLE < 15
I guess we have a plan. But for now I think we can proceed. I just ran the test suite with Python 2.7 just to make sure that nothing was sneaking in and all tests came back green. Thanks a lot!
Cheers,
Jochen aka brejoc
[0] https://build.opensuse.org/request/show/910038 [1] https://build.opensuse.org/request/show/910038#comment-1497660
Ben
participants (2)
-
Ben Greiner -
Jochen Breuer