[opensuse-python] jsonchema 3
Recently jupyterlab had its big 1.0.0 release. This is the next-generation replacement for the jupyter notebook, and affects about a half dozen packages. However, it requires jsonscheme >= 3.0.1. A few months ago this update was rejected because it breaks a lot of other packages. Is that still the case? -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
It is looking like jsonschema 2.6 will not work under python 3.8 [1], so we will need to update anyway. Should we go ahead and just do the update? [1] https://github.com/Julian/jsonschema/issues/487 On Sun, Jul 28, 2019 at 10:54 PM Todd Rme <toddrme2178@gmail.com> wrote:
Recently jupyterlab had its big 1.0.0 release. This is the next-generation replacement for the jupyter notebook, and affects about a half dozen packages. However, it requires jsonscheme >= 3.0.1. A few months ago this update was rejected because it breaks a lot of other packages. Is that still the case?
-- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
The revert was done for cloud iirc. @Dirk: is it still needed? Cheers Tom Todd Rme píše v Po 29. 07. 2019 v 11:26 -0400:
It is looking like jsonschema 2.6 will not work under python 3.8 [1], so we will need to update anyway. Should we go ahead and just do the update?
[1] https://github.com/Julian/jsonschema/issues/487
On Sun, Jul 28, 2019 at 10:54 PM Todd Rme <toddrme2178@gmail.com> wrote:
Recently jupyterlab had its big 1.0.0 release. This is the next-generation replacement for the jupyter notebook, and affects about a half dozen packages. However, it requires jsonscheme >= 3.0.1. A few months ago this update was rejected because it breaks a lot of other packages. Is that still the case?
On Tuesday, July 30, 2019 11:16:27 AM CEST Tomas Chvatal wrote: Hi Tomas,
The revert was done for cloud iirc. @Dirk: is it still needed?
Yes, we're still only compatible with jsonschema 2.6.0. Greetings, Dirk -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
On Mon, Aug 5, 2019 at 9:17 AM Dirk Mueller <dirk.mueller@suse.com> wrote:
On Tuesday, July 30, 2019 11:16:27 AM CEST Tomas Chvatal wrote:
Hi Tomas,
The revert was done for cloud iirc. @Dirk: is it still needed?
Yes, we're still only compatible with jsonschema 2.6.0.
Greetings, Dirk
Can we make a jsonschema2 package, then, that they can depend on? Sticking with jsonschema 2 is holding up important updates. Packages that rely on jsonschema 2 are going to break when python 3.8 comes out in a couple of months anyway. jsonschema 2 hasn't been updated since 2017. -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
On 8/6/19 1:04 AM, Todd Rme wrote:
Can we make a jsonschema2 package, then, that they can depend on?
Sticking with jsonschema 2 is holding up important updates. Packages that rely on jsonschema 2 are going to break when python 3.8 comes out in a couple of months anyway. jsonschema 2 hasn't been updated since 2017.
Sounds reasonable and I agree. A package with that many reverse dependencies shouldn't be stuck in such an old version. Adrian
On Tuesday, August 6, 2019 9:37:38 AM CEST John Paul Adrian Glaubitz wrote: Hi,
Sounds reasonable and I agree. A package with that many reverse dependencies shouldn't be stuck in such an old version.
We're not stuck, we just need more time. Also, the bulk of the reverse dependencies of jsonschema actualyl require jsonschema < 3. Greetings, Dirk -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
On Tue, Aug 6, 2019 at 1:11 PM Dirk Mueller <dirk.mueller@suse.com> wrote:
On Tuesday, August 6, 2019 9:37:38 AM CEST John Paul Adrian Glaubitz wrote:
Hi,
Sounds reasonable and I agree. A package with that many reverse dependencies shouldn't be stuck in such an old version.
We're not stuck, we just need more time. Also, the bulk of the reverse dependencies of jsonschema actualyl require jsonschema < 3.
Greetings, Dirk
Essentially the entire jupyter stack requires jsonschema 3 now. Outside of the openstack packages, I could only find 4 that still require jsonschema 2, two of which have jsonschema 3 patches that we could backport and one of which hasn't been had a commit in 3 years so will probably have to be dropped when Python 3.8 comes out. -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
On Tuesday, August 6, 2019 10:42:35 PM CEST Todd Rme wrote: Hi Todd,
Essentially the entire jupyter stack requires jsonschema 3 now.
Yeah, I see it was raied without a clear explanation on why (at least according to the git commit message and the linked issue). perhaps it works just fine with the older version as well?
Outside of the openstack packages, I could only find 4 that still require jsonschema 2, two of which have jsonschema 3 patches that we could backport and one of which hasn't been had a commit in 3 years so will probably have to be dropped when Python 3.8 comes out.
Sure, I'm not saying we shouldn't update. Just that somebody needs to do the work of backporting allt he enablement patches etc. I'm pushing on the openstack side (which is slightly more complicated, as it requires a 3rd party to cooperate). I think the plan of introducing jsonschema2 makes upgrade difficult. could we maybe just work on making everything jsonschema 3 compatible and then switch? meanwhile, did you try patching out the dependency of jsonschema to 2.6? TIA, Dirk -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
On Wed, Aug 7, 2019 at 9:07 AM Dirk Mueller <dirk.mueller@suse.com> wrote:
On Tuesday, August 6, 2019 10:42:35 PM CEST Todd Rme wrote:
Hi Todd,
Essentially the entire jupyter stack requires jsonschema 3 now.
Yeah, I see it was raied without a clear explanation on why (at least according to the git commit message and the linked issue). perhaps it works just fine with the older version as well?
I would be disinclined to second-guess the developers about what version they support. That is what they are developing against and testing against. And the big thing that changes in jsonschema 3 is on the json side, rather than the python side, and I am in no position to assess the state of their json stuff, especially since they are switching to a new json format. Several other packages have updates coming soon that also drop support for jsonschema 2.
Outside of the openstack packages, I could only find 4 that still require jsonschema 2, two of which have jsonschema 3 patches that we could backport and one of which hasn't been had a commit in 3 years so will probably have to be dropped when Python 3.8 comes out.
Sure, I'm not saying we shouldn't update. Just that somebody needs to do the work of backporting allt he enablement patches etc. I'm pushing on the openstack side (which is slightly more complicated, as it requires a 3rd party to cooperate). I think the plan of introducing jsonschema2 makes upgrade difficult. could we maybe just work on making everything jsonschema 3 compatible and then switch?
Not all the openstack packages support jsonschema 3 even in master, and most of those that do have support are too out-of-date in openSUSE to include the fixes. How long will it take to get it compatible?
meanwhile, did you try patching out the dependency of jsonschema to 2.6?
No, because in most cases that involves dropping support for jsonschema 2 entirely, so I can't do it until we have a jsonschema 3 package available. -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
Am Donnerstag, 8. August 2019, 15:16:49 CEST schrieb Todd Rme: Hi,
No, because in most cases that involves dropping support for jsonschema 2 entirely, so I can't do it until we have a jsonschema 3 package available.
I believe things in factory are new enough that we can update jsonschema to 3.x now. would you please submit it? I'll deal of the fallout then should there still be one. Thanks, Dirk -- To unsubscribe, e-mail: opensuse-python+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-python+owner@opensuse.org
Dirk Mueller píše v Pá 20. 09. 2019 v 13:14 +0200:
Am Donnerstag, 8. August 2019, 15:16:49 CEST schrieb Todd Rme:
Hi,
No, because in most cases that involves dropping support for jsonschema 2 entirely, so I can't do it until we have a jsonschema 3 package available.
I believe things in factory are new enough that we can update jsonschema to 3.x now.
would you please submit it? I'll deal of the fallout then should there still be one.
Thanks, Dirk
I already have the submission for jsonschema 3 open so I will just forward it to TW and lets see what happens. Also currently being processed are the tornados and pytest5 as default on python3. Cheers Tom
On 9/20/19 1:59 PM, Tomas Chvatal wrote:
I already have the submission for jsonschema 3 open so I will just forward it to TW and lets see what happens.
Let me know once that has happened, I'll submit the updated python-cfn-lint package plus dependencies which I have prepared weeks ago. Adrian
John Paul Adrian Glaubitz píše v Pá 20. 09. 2019 v 12:30 +0000:
On 9/20/19 1:59 PM, Tomas Chvatal wrote:
I already have the submission for jsonschema 3 open so I will just forward it to TW and lets see what happens.
Let me know once that has happened, I'll submit the updated python- cfn-lint package plus dependencies which I have prepared weeks ago.
You can start watching it here: https://build.opensuse.org/request/show/732149 Tom
participants (4)
-
Dirk Mueller -
John Paul Adrian Glaubitz -
Todd Rme -
Tomas Chvatal