[opensuse-project] grub-0.97 patch errors
Hi, all I'm a student currently proposing for an opensuse gsoc project (http://en.opensuse.org/Summer_of_Code_2008#enable_ext4_file_system_as_boot_p...) This project aims at enabling ext4 file system as grub legacy boot partition for opensuse and others. I downloaded the grub source package from http://download.opensuse.org/distribution/10.3/repo/src-oss/suse/src/grub-0.... After decompressing it, I found eventually several patches for old grub-0.93, and grub-0.95 etc. Surprisingly, even some grub-0.97 patches don't work well, such as disk-by-ID: $cat disk-by-ID diff -Burbp grub-0.97.orig/lib/device.c grub-0.97/lib/device.c --- grub-0.97.orig/lib/device.c 2007-03-16 14:15:52.000000000 +0100 +++ grub-0.97/lib/device.c 2007-03-16 17:19:59.000000000 +0100 @@ -869,7 +869,11 @@ write_to_partition (char **map, int driv len = strlen(dev); pnum = ((partition >> 16) & 0xFF); - if (isdigit(dev[len-1])) + if (strncmp (dev, "/dev/disk/by-id/", 16) == 0) + { + sprintf (dev + len, "-part%d", pnum + 1); + } + else if (isdigit(dev[len-1])) { /* It is obviously some RAID disk: "/dev/<dsk>/c0d0" . "p1" */ sprintf (dev + len, "p%d", pnum + 1); $patch -p0 < disk-by-ID patching file grub-0.97/lib/device.c Hunk #1 FAILED at 869. 1 out of 1 hunk FAILED -- saving rejects to file grub-0.97/lib/device.c.rej My questions are: are these old patches applicable to grub-0.97? Does grub running in opensuse10.3 really uses these patches, or just some of them? I know that grub legacy is no longer under development, but since I'm working on an opensuse project, I need to consult the opensuse community to make sure that my ext4 patch cooperates with other patches when it comes out. Thanks, Bergwolf --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-project+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-project+help@opensuse.org
Hi there, On Mon, Apr 21, 2008 at 08:49:31PM +0800, Bergwolf wrote:
I'm a student currently proposing for an opensuse gsoc project (http://en.opensuse.org/Summer_of_Code_2008#enable_ext4_file_system_as_boot_p...) This project aims at enabling ext4 file system as grub legacy boot partition for opensuse and others.
I downloaded the grub source package from http://download.opensuse.org/distribution/10.3/repo/src-oss/suse/src/grub-0....
Please pull in the latests sources from: http://download.opensuse.org/distribution/SL-OSS-factory/inst-source/suse/sr... unrpm the complete archive and check out the grub.spec (rpm specfile).
After decompressing it, I found eventually several patches for old grub-0.93, and grub-0.95 etc.
Surprisingly, even some grub-0.97 patches don't work well, such as disk-by-ID:
$cat disk-by-ID diff -Burbp grub-0.97.orig/lib/device.c grub-0.97/lib/device.c --- grub-0.97.orig/lib/device.c 2007-03-16 14:15:52.000000000 +0100 +++ grub-0.97/lib/device.c 2007-03-16 17:19:59.000000000 +0100 @@ -869,7 +869,11 @@ write_to_partition (char **map, int driv
len = strlen(dev); pnum = ((partition >> 16) & 0xFF); - if (isdigit(dev[len-1])) + if (strncmp (dev, "/dev/disk/by-id/", 16) == 0) + { + sprintf (dev + len, "-part%d", pnum + 1); + } + else if (isdigit(dev[len-1])) { /* It is obviously some RAID disk: "/dev/<dsk>/c0d0" . "p1" */ sprintf (dev + len, "p%d", pnum + 1);
$patch -p0 < disk-by-ID patching file grub-0.97/lib/device.c Hunk #1 FAILED at 869. 1 out of 1 hunk FAILED -- saving rejects to file grub-0.97/lib/device.c.rej
My questions are: are these old patches applicable to grub-0.97? Does grub running in opensuse10.3 really uses these patches, or just some of them?
I don't think so -- please check the latests grub 0.97 sources, that are used in the upcoming openSUSE 11.0.
I know that grub legacy is no longer under development, but since I'm working on an opensuse project, I need to consult the opensuse community to make sure that my ext4 patch cooperates with other patches when it comes out.
Great -- please subscribe yourself to the opensuse-factory mailinglist, which is the main forum for development related topics. Best, Christoph -- Christoph Thiel, Tech. Project Management, Research & Development SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-project+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-project+help@opensuse.org
On 4/21/08, Christoph Thiel <cthiel@suse.de> wrote:
Hi there,
On Mon, Apr 21, 2008 at 08:49:31PM +0800, Bergwolf wrote:
I'm a student currently proposing for an opensuse gsoc project (http://en.opensuse.org/Summer_of_Code_2008#enable_ext4_file_system_as_boot_p...) This project aims at enabling ext4 file system as grub legacy boot partition for opensuse and others.
I downloaded the grub source package from http://download.opensuse.org/distribution/10.3/repo/src-oss/suse/src/grub-0....
Please pull in the latests sources from: http://download.opensuse.org/distribution/SL-OSS-factory/inst-source/suse/sr...
unrpm the complete archive and check out the grub.spec (rpm specfile).
After decompressing it, I found eventually several patches for old grub-0.93, and grub-0.95 etc.
Surprisingly, even some grub-0.97 patches don't work well, such as disk-by-ID:
$cat disk-by-ID diff -Burbp grub-0.97.orig/lib/device.c grub-0.97/lib/device.c --- grub-0.97.orig/lib/device.c 2007-03-16 14:15:52.000000000 +0100 +++ grub-0.97/lib/device.c 2007-03-16 17:19:59.000000000 +0100 @@ -869,7 +869,11 @@ write_to_partition (char **map, int driv
len = strlen(dev); pnum = ((partition >> 16) & 0xFF); - if (isdigit(dev[len-1])) + if (strncmp (dev, "/dev/disk/by-id/", 16) == 0) + { + sprintf (dev + len, "-part%d", pnum + 1); + } + else if (isdigit(dev[len-1])) { /* It is obviously some RAID disk: "/dev/<dsk>/c0d0" . "p1" */ sprintf (dev + len, "p%d", pnum + 1);
$patch -p0 < disk-by-ID patching file grub-0.97/lib/device.c Hunk #1 FAILED at 869. 1 out of 1 hunk FAILED -- saving rejects to file grub-0.97/lib/device.c.rej
My questions are: are these old patches applicable to grub-0.97? Does grub running in opensuse10.3 really uses these patches, or just some of them?
I don't think so -- please check the latests grub 0.97 sources, that are used in the upcoming openSUSE 11.0.
I know that grub legacy is no longer under development, but since I'm working on an opensuse project, I need to consult the opensuse community to make sure that my ext4 patch cooperates with other patches when it comes out.
Great -- please subscribe yourself to the opensuse-factory mailinglist, which is the main forum for development related topics. Thanks, Christoph. I shall post my further question there:-)
Best, Christoph -- Christoph Thiel, Tech. Project Management, Research & Development SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-- RGDS 彭涛-Bergwolf ................ Here lieth one whose name was writ on water.
participants (3)
-
Bergwolf -
Christoph Thiel -
Peng tao