On 2024-12-26 10:47, Franck Bui wrote:
On 12/24/24 15:34, Andreas Stieger wrote:
I cannot speak about others. Let's speak about the general situation: SUSE LLC's copyright line is both added and updated upon every invocation of the source service (at least osc build), with or without any involvement of a SUSE person. What's good for SUSE should be good for everyone if they choose to do so like me, without filtering. Again this behavior looks inappropriate especially given the size of your very first contribution in the systemd package.
Interesting. What is the cut-off? I made that point in the original post btw.
If we want to be fair, we would need to add all copyright of each contributor the same way plus some details about the contribution. The changelogs is already doing that.
How does that go with the "SUSE LLC" header being maintained, added on top (!) if missing, and the year updated? In the context of the openSUSE project, are we treating the "SUSE LLC" header special? If we are not doing that, for a spec file that a contributor writes from scratch and adds to the distribution, will that contributor's header remain the single line forever? Including rejecting changes that change it later, manually or with the same formatting tools and services?
I don't know you're the very first one claiming such copyright,
I am aware of the general guidance to never touch anyone else's, there was a bit of a discussion around the mozilla packages where the maintainer was not happy with removals. As would I. Pascal B is a frequent occurrence.
For the time being I'll revert your change until a decision is made.
Interesting. Would the bug fix would be acceptable without that bit? I do not believe that the /project /should gate contributions like that. My current (technical) thoughts are to see if I can make the "SUSE LLC" header handling configurable, and heuristically trigger on SUSE's users only by default. I believe that this may have been the original intention. Also I'll see if I find the OBS work that Julia mentioned. Andreas