[opensuse-programming] Next issue: libmodplug

19 Dec 2008

      Hi,

Sorry for the noise on this otherwise sooo quiet mailinglist.

I have a package that fails building (own obs). the issue is not really of packaging nature (it works up to 11.0) but is actually a code issue.

The build log says:
I: Statement is overflowing a buffer
E: libmodplug bufferoverflow load_pat.cpp:1321

Which ends up to be in this loop:

        for(t=1; t<of->m_nInstruments; t++) { // xmms modplug doesn't use slot zero
                if( (of->Headers[t] = new INSTRUMENTHEADER) == NULL ) return FALSE;
                memset(of->Headers[t], 0, sizeof(INSTRUMENTHEADER));
                PATinst(of->Headers[t], t, pat_smptogm(t));
        }

from the buildlog, I think the 'most' interesting part would be
g++ -DHAVE_CONFIG_H -I. -I. -I. -Ilibmodplug -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector
-funwind-tables -fasy
nchronous-unwind-tables -fPIC -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwin
d-tables -fno-exceptions -Wall -ffast-math -D_REENTRANT -MT load_pat.lo -MD -MP -MF .deps/load_pat.Tpo -c load_pat.cpp -o load_pat.o
load_pat.cpp: In function 'void pat_init_patnames()':
load_pat.cpp:367: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result
load_pat.cpp:390: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result
load_pat.cpp: In function 'void pat_read_layerheader(FILE*, LayerHeader*)':
load_pat.cpp:435: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result
load_pat.cpp: In function 'void pat_read_waveheader(FILE*, WaveHeader*, int)':
load_pat.cpp:465: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result
load_pat.cpp:473: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result
load_pat.cpp:487: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result
load_pat.cpp: In function 'void pat_readpat(int, char*, int)':
load_pat.cpp:649: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result
In function 'char* strncpy(char*, const char*, size_t)',
inlined from 'void PATinst(INSTRUMENTHEADER*, int, int)' at load_pat.cpp:1147,
inlined from 'BOOL PAT_Load_Instruments(void*)' at load_pat.cpp:1321:
/usr/include/bits/string3.h:122: warning: call to char* __builtin___strncpy_chk(char*, const char*, unsigned int, unsigned int) will always overflow
destinat
ion buffer

Any ideas on how I can fix that one? (Sorry... I do some coding.. but I'm pretty much at my beginnings with this... and this at my high age)

Thanks for giving any pointers possible or, if needed, I can provide more information if this helps.

Dominique

-- 
To unsubscribe, e-mail: opensuse-programming+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-programming+help@opensuse.org

Dominique Leuenberger

Philipp Thomas

Dominique Leuenberger

K.R. Foley

Dominique Leuenberger

Philipp Thomas

Philipp Thomas

Dominique Leuenberger

tags

participants (3)