[opensuse-packaging] specfile autoformat during submit request
What can be done to avoid such breakage from the specfile autoformat which runs during submit request? @@ -62,8 +63,8 @@ %package devel Summary: C++ Template Library for Linear Algebra -Group: Development/Libraries/C and C++ # libeigen3-devel was last used at openSUSE 13.1 (version 3.2.0) +Group: Development/Libraries/C and C++ Provides: libeigen3-devel = %{version} Obsoletes: libeigen3-devel < %{version} There no reason to move comments around. Olaf
On Mittwoch, 4. Januar 2017, 10:21:39 CET wrote Olaf Hering:
What can be done to avoid such breakage from the specfile autoformat which runs during submit request?
(it runs on commit, not on submit request)
@@ -62,8 +63,8 @@
%package devel Summary: C++ Template Library for Linear Algebra -Group: Development/Libraries/C and C++ # libeigen3-devel was last used at openSUSE 13.1 (version 3.2.0) +Group: Development/Libraries/C and C++ Provides: libeigen3-devel = %{version} Obsoletes: libeigen3-devel < %{version}
There no reason to move comments around.
I dunno, but you may want to discuss it here: https://github.com/openSUSE/obs-service-format_spec_file -- Adrian Schroeter email: adrian@suse.de SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Am 04.01.2017 um 10:23 schrieb Adrian Schröter:
On Mittwoch, 4. Januar 2017, 10:21:39 CET wrote Olaf Hering:
What can be done to avoid such breakage from the specfile autoformat which runs during submit request?
(it runs on commit, not on submit request)
@@ -62,8 +63,8 @@
%package devel Summary: C++ Template Library for Linear Algebra -Group: Development/Libraries/C and C++ # libeigen3-devel was last used at openSUSE 13.1 (version 3.2.0) +Group: Development/Libraries/C and C++ Provides: libeigen3-devel = %{version} Obsoletes: libeigen3-devel < %{version}
There no reason to move comments around.
I dunno, but you may want to discuss it here:
I agree to Adrian and ... ... I don't think it was the comment which was moved .. it was the 'Group' ... good luck :) -- Christian ---------------------------------------------------- - Please do not 'CC' me on list mails. Just reply to the list :) ---------------------------------------------------- http://www.sc24.de - Sportbekleidung ---------------------------------------------------- -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 01/09/2017 11:36 AM, Christian wrote:
Am 04.01.2017 um 10:23 schrieb Adrian Schröter:
On Mittwoch, 4. Januar 2017, 10:21:39 CET wrote Olaf Hering:
What can be done to avoid such breakage from the specfile autoformat which runs during submit request?
(it runs on commit, not on submit request)
@@ -62,8 +63,8 @@
%package devel Summary: C++ Template Library for Linear Algebra -Group: Development/Libraries/C and C++ # libeigen3-devel was last used at openSUSE 13.1 (version 3.2.0) +Group: Development/Libraries/C and C++ Provides: libeigen3-devel = %{version} Obsoletes: libeigen3-devel < %{version}
There no reason to move comments around.
I dunno, but you may want to discuss it here:
I agree to Adrian and ...
... I don't think it was the comment which was moved .. it was the 'Group' ...
good luck :)
That is correct. I have posted a PR to fix the issue https://github.com/openSUSE/obs-service-format_spec_file/pull/20 but the fact that format_spec_file enforces the Summary->License->Group sequence makes it somewhat ugly and fragile to preserve anything surrounding these tags. -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 04/01/2017 11:21, Olaf Hering wrote:
What can be done to avoid such breakage from the specfile autoformat which runs during submit request? During check in?
@@ -62,8 +63,8 @@
%package devel Summary: C++ Template Library for Linear Algebra -Group: Development/Libraries/C and C++ # libeigen3-devel was last used at openSUSE 13.1 (version 3.2.0) +Group: Development/Libraries/C and C++ Provides: libeigen3-devel = %{version} Obsoletes: libeigen3-devel < %{version}
There no reason to move comments around.
Olaf spec-cleaner-format_spec_file does things like that, try uninstalling it if installed. The only other package that touches spec files on check in is obs-service-format_spec_file but it's never caused any problems for me, try uninstalling it. Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Thursday 2017-01-05 13:02, Dave Plater wrote:
spec-cleaner-format_spec_file does things like that, try uninstalling it if installed. The only other package that touches spec files on check in is obs-service-format_spec_file but it's never caused any problems for me, try uninstalling it.
Then osc ci will complain that it cannot find the service. Just use osc --no-service / --noservice / --skip-local / any of its other names. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 05/01/2017 14:08, Jan Engelhardt wrote:
On Thursday 2017-01-05 13:02, Dave Plater wrote:
spec-cleaner-format_spec_file does things like that, try uninstalling it if installed. The only other package that touches spec files on check in is obs-service-format_spec_file but it's never caused any problems for me, try uninstalling it. Then osc ci will complain that it cannot find the service.
Just use osc --no-service / --noservice / --skip-local / any of its other names. osc doesn't complain when you remove it, you just have to remember to change the copyright date to 2017 :-) Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (6)
-
Adrian Schröter -
Christian -
Dave Plater -
Jan Engelhardt -
Markos Chandras -
Olaf Hering