[opensuse-packaging] blog post series started for rpmlint and brp warnings / errors
Hi everybody, We know them all and some of us get frustrated by them: lints and brp checks aborting our builds, even though make and make install perfectly passed through (well, one correction here already: APPARENTLY perfectly passed). I do not argue against the checks at all and I think they are a good thing (tm). But sometimes they can be a little bit cryptic and most of the time require work. so I started a series of blog posts (2 so far) which try to address them. Please bare with me, I'm no hard core crack coder, but I will try to summarize the usual causes and solutions to a problem. Not in every case will the provided solution fit and if you're not sure about correctness in your package: discuss the matter with upstream. Anyway, once you produce a patch, you should always make sure upstream gets it too. So what were the blog posts about so far? Part 1: how to fix brp and rpmlint warnings ? today: Expression compares a char* pointer with a string literal http://dominique.leuenberger.net/blog/?p=151 Part 2: how to fix brp and rpmlint warnings ? today: I: Program causes undefined operation (likely same variable used twice and post/pre incremented in the same expression) http://dominique.leuenberger.net/blog/?p=178 As noted on the first entry, i will gladly take recommendations for which errors you would like to see an entry. I will try to write them up, likely 1 or 2 per week (I am actually not that much of a writer... 0 Hope the series is useful to you... If it saves you a few minutes here and there, then it is. Best regards, Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 28/03/11 13:15, Dominique Leuenberger a.k.a DimStar wrote:
We know them all and some of us get frustrated by them: lints and brp checks aborting our builds, even though make and make install perfectly passed through (well, one correction here already: APPARENTLY perfectly passed).
Mine idea was to document all rpmlint/brpcheck warnings/errors in the wiki (together with solutions) and patch rpmlint/brpcheck to include also the link to the particular solution, not just the name of the error. Sadly, I didn't find time to start it ... -- Best Regards / S pozdravom, Pavol RUSNAK SUSE LINUX, s.r.o openSUSE Boosters Team Lihovarska 1060/12 PGP 0xA6917144 19000 Praha 9 prusnak[at]opensuse.org Czech Republic -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 03/28/2011 06:34 PM, Pavol Rusnak wrote:
On 28/03/11 13:15, Dominique Leuenberger a.k.a DimStar wrote:
We know them all and some of us get frustrated by them: lints and brp checks aborting our builds, even though make and make install perfectly passed through (well, one correction here already: APPARENTLY perfectly passed).
Mine idea was to document all rpmlint/brpcheck warnings/errors in the wiki (together with solutions) and patch rpmlint/brpcheck to include also the link to the particular solution, not just the name of the error. Sadly, I didn't find time to start it ...
Dominique is doing half the work for you maybe if you provided a list of all possible warnings and errors someone can reference the two together and start a wiki page. I find wiki pages more difficult than maintaining packages, the old wiki was easier than the existing one but I always add new things I discover. All we need is a wiki page with all possible warnings and errors and blanks for the solutions to be filled in. Thanks for the effort Dominique I haven't experienced the first problem but the second one is quite common. Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Hi, At dinsdag 29 maart 2011 18:28:49 wrote Dave Plater:
All we need is a wiki page with all possible warnings and errors and blanks for the solutions to be filled in. Thanks for the effort Dominique I haven't experienced the first problem but the second one is quite common.
Does that already exist? http://en.opensuse.org/openSUSE:Packaging_checks -- Richard -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Quoting Richard Bos <rbos@opensuse.org>:
Hi,
At dinsdag 29 maart 2011 18:28:49 wrote Dave Plater:
All we need is a wiki page with all possible warnings and errors and blanks for the solutions to be filled in. Thanks for the effort Dominique I haven't experienced the first problem but the second one is quite common.
Does that already exist? http://en.opensuse.org/openSUSE:Packaging_checks
Richard, Thanks for the pointer, This is certainly a good start, but is not complete. The 'easy' rpmlint errors that are listed there are probably not the cause for most people's build problems. The ones I addressed so far always require a code fix, and not just some spec cleanup. This might change to some spec cleanup too, but so far I'm not sure I well have to or want to address library-without-ldconfig-postin: I think the error says it all. But nothing is excluded :) Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Hey, (catching up with mails after the GNOME 3 release) Le lundi 28 mars 2011, à 13:15 +0200, Dominique Leuenberger a écrit :
Hi everybody,
We know them all and some of us get frustrated by them: lints and brp checks aborting our builds, even though make and make install perfectly passed through (well, one correction here already: APPARENTLY perfectly passed).
I do not argue against the checks at all and I think they are a good thing (tm).
But sometimes they can be a little bit cryptic and most of the time require work.
so I started a series of blog posts (2 so far) which try to address them.
This is good, I love this! More, more, more :-) Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (5)
-
Dave Plater -
Dominique Leuenberger a.k.a DimStar -
Pavol Rusnak -
Richard Bos -
Vincent Untz