On Tuesday 2014-06-03 22:00, Michal Srb wrote:

"%_sbindir/update-alternatives" --install /bin/vim vim /bin/vim-normal 15

Rpmlint doesn't parse this correctly (it takes the first thing after update- alternatives that doesn't start with "--"

If I read the python code correctly, it uses any *arbitrary occurrence* of the substring "update-alternatives" to look for an "--install" string. To me, that is just too fuzzy a match. I would instead suggest to: * Split the script by '\n', and _join back_ lines that are \\-continued. It is not unheard of %post scripts to use that. * Dequote each line into arguments according to well-known double-quoting rules, that is, a state machine that tracks whether or not it is inside a "string" or 'string' and recognizes \"escapes. * When done, check first argument of the so-split line for - trailing portion being equal to "/update-alternatives" (/update-alternatives$ for regex fanatics, but substr will do just fine) - equality to "update-alternatives" (^update-alternatives$) * And since the line was already split per DQ rules, checking for "--install" is easy too. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org