[opensuse-packaging] The containers team needs some help reviewing new packages
Hello everybody, I hope that I am contacting the right mailing lists for this :) Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated. Thanks! Miquel [1] https://build.opensuse.org/project/show/Virtualization:containers
Hello, pack is perfectly okay mailinglist for this :) If it is public and you can stand some noise from community you can also use opensuse-packaging@opensuse.org. To split it up: Kristyna: you check flannel Premysl: you check etcd I will check kubernetes Cheers Tom Miquel Sabaté Solà píše v St 13. 07. 2016 v 15:40 +0200:
Hello everybody,
I hope that I am contacting the right mailing lists for this :)
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
Thanks! Miquel
[1] https://build.opensuse.org/project/show/Virtualization:containers _______________________________________________ Pack mailing list Pack@suse.cz https://mailman.suse.de/mailman/listinfo/pack
On Wednesday 2016-07-13 15:40, Miquel Sabaté Solà wrote:
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
kubernetes.spec: # if node is installed with node, version and release must be the same Conflicts: kubernetes-node < %{version}-%{release} Conflicts: kubernetes-node > %{version}-%{release} Ugh. Just make it a Requires: kubernetes-node = %version-%release Simiarly elsewhere. kubernetes and etcd: %pre master Put the getent calls first in %pre, better resiliency if failure. etcd.spec: BuildRequires: shadow that should perhaps be Requires(pre). "BuildRequires: systemd" maybe could be BuildRequires: systemd-rpm-macros instead.. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
13.07.2016 18:02, Jan Engelhardt пишет:
On Wednesday 2016-07-13 15:40, Miquel Sabaté Solà wrote:
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
kubernetes.spec: # if node is installed with node, version and release must be the same Conflicts: kubernetes-node < %{version}-%{release} Conflicts: kubernetes-node > %{version}-%{release}
Ugh. Just make it a Requires: kubernetes-node = %version-%release
There is subtle difference. Requires forces required package to be installed too. Conflicts says "*if* other package is installed, it must be that and that version", but does not force installation of other package. I do not know context well enough, but please consider what is more appropriate here. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wed, 13 Jul 2016 18:12:35 +0300 Andrei Borzenkov <arvidjaar@gmail.com> wrote:
13.07.2016 18:02, Jan Engelhardt пишет:
On Wednesday 2016-07-13 15:40, Miquel Sabaté Solà wrote:
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
kubernetes.spec: # if node is installed with node, version and release must be the same Conflicts: kubernetes-node < %{version}-%{release} Conflicts: kubernetes-node > %{version}-%{release}
Ugh. Just make it a Requires: kubernetes-node = %version-%release
There is subtle difference. Requires forces required package to be installed too. Conflicts says "*if* other package is installed, it must be that and that version", but does not force installation of other package.
I do not know context well enough, but please consider what is more appropriate here.
In this case it is a bit tricky as there is basically three packages: - master - client - node node and master have Requires: kubernetes-client = %{version}-%{release} but master and node do not require each other. But to be honest I do not see way how solver can have different version of master and node, when both of them require exactly same version of client. So from my POV all conflicts can be removed as there is no way how node and master can have different version unless client can be installed in multiple versions, which I think cannot happen now with libzypp without multiversion flag. Josef -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wednesday 2016-07-13 17:12, Andrei Borzenkov wrote:
13.07.2016 18:02, Jan Engelhardt пишет:
On Wednesday 2016-07-13 15:40, Miquel Sabaté Solà wrote:
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
kubernetes.spec: # if node is installed with node, version and release must be the same Conflicts: kubernetes-node < %{version}-%{release} Conflicts: kubernetes-node > %{version}-%{release}
Ugh. Just make it a Requires: kubernetes-node = %version-%release
There is subtle difference. Requires forces required package to be installed too. Conflicts says "*if* other package is installed, it must be that and that version", but does not force installation of other package.
Ah yes, I reread what master and node is about. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wednesday 2016-07-13 17:02, Jan Engelhardt wrote:
On Wednesday 2016-07-13 15:40, Miquel Sabaté Solà wrote:
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
%package client Summary: Kubernetes client tools Requires: bash-completion Why does the client force this ungodly b-c on me? Please don't! -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Created submission for the kubernetes: sr#408313 There are still two big things to sort out but that is up to you guys how you would like to approach that. Tom Miquel Sabaté Solà píše v St 13. 07. 2016 v 15:40 +0200:
Hello everybody,
I hope that I am contacting the right mailing lists for this :)
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
Thanks! Miquel
[1] https://build.opensuse.org/project/show/Virtualization:containers _______________________________________________ Pack mailing list Pack@suse.cz https://mailman.suse.de/mailman/listinfo/pack
On Wed, 13 Jul 2016 15:40:52 +0200 Miquel Sabaté Solà <msabate@suse.com> wrote:
Hello everybody,
I hope that I am contacting the right mailing lists for this :)
Around November 2016 the containers team will be publishing new packages to our customers. During this last sprint we have been polishing new packages but we would like to get some feedback from packagers. The packages are kubernetes, etcd and flannel; and they can all be found in the Virtualization:containers project in OBS [1]. Any kind of feedback will be helpful and greatly appreciated.
Thanks!
Miquel
[1] https://build.opensuse.org/project/show/Virtualization:containers
my feedback ( beside what is already written ) kubernet: PreReq: %fillup_prereq is not needed when package do not use fillup script ( I really discourage using it ) output_path for binaries based on arch looks nasty. Doesn't go provide for it macro? does it make sense to have same doc files for all three packages? why not simple use only client which is always installed? etcd: is it correct that etcdctl do not require etcd? or it can be run also for remotelly? In general I think it is quite good spec files ;) Josef
participants (5)
-
Andrei Borzenkov -
Jan Engelhardt -
Josef Reidinger -
Miquel Sabaté Solà -
Tomas Chvatal