[opensuse-packaging] Re: qt3 in KDE:KDE3 patching fails
I keep sending from the wrong email address... >_> On Apr 20, 2011, at 10:34, Will Stephenson <wstephenson@suse.de> wrote:
On Wednesday 20 Apr 2011 16:15:15 Robert Xu wrote:
On Wed, Apr 20, 2011 at 04:43, Philipp Thomas <pth@suse.de> wrote:
* Robert Xu (rxu@lincomlinux.org) [20110418 21:57]:
The problem is this patch works perfectly fine, until we get openSUSE 11.3+, where it thinks this patch is not a regular file.
Look at the patch itself and you'll see that it tries to patch qglobal.h twice, once via its symlink and then at the end of the patch the qglobal.h file the symlink in include/ points to. If you remove the first patch it should all be OK.
Philipp
That works, thanks! Now to sr this...
Is this the binary-incompatible patch to Qt 3 I read about on the trinity list?
Yes, the patch to Qt3. Not sure about the binary incompatibility though. -- Robert Xu + Linux is awesome; don't doubt what it can do + rxu@lincomlinux.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wednesday 20 April 2011 17:23:11 Robert Xu wrote:
I keep sending from the wrong email address... >_>
On Apr 20, 2011, at 10:34, Will Stephenson <wstephenson@suse.de> wrote:
On Wednesday 20 Apr 2011 16:15:15 Robert Xu wrote:
On Wed, Apr 20, 2011 at 04:43, Philipp Thomas <pth@suse.de> wrote:
* Robert Xu (rxu@lincomlinux.org) [20110418 21:57]:
The problem is this patch works perfectly fine, until we get openSUSE 11.3+, where it thinks this patch is not a regular file.
Look at the patch itself and you'll see that it tries to patch qglobal.h twice, once via its symlink and then at the end of the patch the qglobal.h file the symlink in include/ points to. If you remove the first patch it should all be OK.
Philipp
That works, thanks! Now to sr this...
Is this the binary-incompatible patch to Qt 3 I read about on the trinity list?
Yes, the patch to Qt3. Not sure about the binary incompatibility though.
I checked, it's binary compatible. I'm interested to know why those extra methods on QObject are needed though - can you point me to any uses of them? Will -- Will Stephenson, KDE Developer, openSUSE Boosters Team SUSE LINUX Products GmbH - Nürnberg - AG Nürnberg - HRB 16746 - GF: Markus Rex -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Apr 21, 2011 at 05:28, Will Stephenson <wstephenson@suse.de> wrote:
On Wednesday 20 April 2011 17:23:11 Robert Xu wrote:
I keep sending from the wrong email address... >_>
On Apr 20, 2011, at 10:34, Will Stephenson <wstephenson@suse.de> wrote:
On Wednesday 20 Apr 2011 16:15:15 Robert Xu wrote:
On Wed, Apr 20, 2011 at 04:43, Philipp Thomas <pth@suse.de> wrote:
* Robert Xu (rxu@lincomlinux.org) [20110418 21:57]:
The problem is this patch works perfectly fine, until we get openSUSE 11.3+, where it thinks this patch is not a regular file.
Look at the patch itself and you'll see that it tries to patch qglobal.h twice, once via its symlink and then at the end of the patch the qglobal.h file the symlink in include/ points to. If you remove the first patch it should all be OK.
Philipp
That works, thanks! Now to sr this...
Is this the binary-incompatible patch to Qt 3 I read about on the trinity list?
Yes, the patch to Qt3. Not sure about the binary incompatibility though.
I checked, it's binary compatible. I'm interested to know why those extra methods on QObject are needed though - can you point me to any uses of them?
Will
It adds in two functions that allow the use of object list objects instead of pointers to them. Also, it prevents bad pointer accesses. The Trinity Qt wrapper - TQtinterface, makes use of these objects. -- Robert Xu + Linux is awesome; don't doubt what it can do + rxu@lincomlinux.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thursday 21 Apr 2011 21:21:25 Robert Xu wrote:
On Thu, Apr 21, 2011 at 05:28, Will Stephenson <wstephenson@suse.de> wrote:
On Wednesday 20 April 2011 17:23:11 Robert Xu wrote:
Is this the binary-incompatible patch to Qt 3 I read about on the trinity list?
Yes, the patch to Qt3. Not sure about the binary incompatibility though.
I checked, it's binary compatible. I'm interested to know why those extra methods on QObject are needed though - can you point me to any uses of them?
Will
It adds in two functions that allow the use of object list objects instead of pointers to them.
Yeah, I read that in the patch.
Also, it prevents bad pointer accesses.
Hmm. Not sure about that.
The Trinity Qt wrapper - TQtinterface, makes use of these objects.
Where do I find the TQtinterface code that uses these? Will -- Will Stephenson, openSUSE Team SUSE LINUX Products GmbH - Nürnberg - AG Nürnberg - HRB 16746 - GF: Markus Rex -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (2)
-
Robert Xu -
Will Stephenson