[opensuse-packaging] Confusion with spec file
Aloha all, I have been having issues for quite some time now trying to package my beloved bongo on >=11.0. It goes fine on 10.3 but on anything newer I get: + exit 0 ... checking for files with abuild user/group ... running 00-check-install-rpms ... installing all built rpms Preparing packages for installation... bongo-snapshot-debuginfo-0.4.0svn1009-1.1 bongo-snapshot-debugsource-0.4.0svn1009-1.1 libbongo-snapshot-import-0.4.0svn1009-1.1 bongo-snapshot-data-0.4.0svn1009-1.1 libbongo-snapshot-0.4.0svn1009-1.1 python-bongo-snapshot-0.4.0svn1009-1.1 libbongo-snapshot-dev-0.4.0svn1009-1.1 bongo-snapshot-0.4.0svn1009-1.1 chown: invalid user: `bongo' bongo-snapshot-mta-0.4.0svn1009-1.1 bongo-snapshot-web-0.4.0svn1009-1.1 ... running 01-check-debuginfo ... testing for empty debuginfo packages ... running 02-check-gcc-output ... testing for serious compiler warnings (using /usr/lib/build/checks-data/check_gcc_output) (using //.build.log) E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-cal-object.c:262 E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-import-tz.c:41 E: bongo-snapshot 64bit-portability-issue src/libs/msgapi/msgcollector.c:435 My spec file has: %pre #Add the bongo user & group /usr/sbin/groupadd -r bongo 2> /dev/null || : /usr/sbin/useradd -r -g bongo -s /bin/false -c "Bongo Mail daemon" -d /etc/bongo bongo 2> /dev/null || : %post #Ensure that the data directory has the correct ownership permissions chown -R bongo /var/bongo %fillup_only bongo %preun %{stop_on_removal} bongo %postun %{insserv_cleanup} Is this correct? Many thanks for your help. Andy -- Andrew Wafaa, openSUSE Member: FunkyPenguin. openSUSE: Get It, Discover It, Create It at http://www.opensuse.org awafaa@opensuse.org | http://www.wafaa.eu -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Andrew Wafaa escribió:
E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-cal-object.c:262 E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-import-tz.c:41 E: bongo-snapshot 64bit-portability-issue src/libs/msgapi/msgcollector.c:435
Please tell us what project/package we are talking about. -- "The 'sanctity of life' is kind of a selective thing..we get to choose which forms of life we feel are sacred, and we get to kill the rest, pretty neat deal huh ?" -George Carlin (1937-2008) Cristian Rodríguez R. Software Developer Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/
* Cristian Rodríguez (crrodriguez@suse.de) [20090219 20:36]:
Please tell us what project/package we are talking about.
He's most probably talking about home:FunkyPenguin:Bongo/bongo-snapshot . Philipp -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, 19 Feb 2009 20:43:34 +0100
Philipp Thomas
* Cristian Rodríguez (crrodriguez@suse.de) [20090219 20:36]:
Please tell us what project/package we are talking about.
He's most probably talking about home:FunkyPenguin:Bongo/bongo-snapshot .
Philipp
Indeed I am :) People say the error has nothing to do with my spec yet in the error I see "chown: invalid user: `bongo'" even though I create the user and group. Is the content and method I have used correct? I will go back to the developers and check about the 64bit-portability-issues even though I think they've resolved it already. Regards, Andy -- Andrew Wafaa, openSUSE Member: FunkyPenguin. openSUSE: Get It, Discover It, Create It at http://www.opensuse.org awafaa@opensuse.org | http://www.wafaa.eu -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
* Andrew Wafaa (awafaa@opensuse.org) [20090219 20:49]:
I will go back to the developers and check about the 64bit-portability-issues even though I think they've resolved it already.
They haven't, at least not in the code you're compiling as you can see if you check the build log: E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-cal-object.c:262 E: bongo-snapshot 64bit-portability-issue src/libs/cal/bongo-import-tz.c:41 E: bongo-snapshot 64bit-portability-issue src/libs/msgapi/msgcollector.c:435 These are all: warning: assignment makes pointer from integer without a cast Which are 64bit issues. I'll send you a patch. Philipp -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
* Philipp Thomas (pth@suse.de) [20090219 21:13]:
These are all: warning: assignment makes pointer from integer without a cast Which are 64bit issues.
And all three because a header wasn't included. I've also fixed some warnings because of int<->pointer casts. You'll get a collaboration request that'll contains all my fixes. Philipp -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Am Thursday 19 February 2009 21:39:42 schrieb Philipp Thomas:
* Philipp Thomas (pth@suse.de) [20090219 21:13]:
These are all: warning: assignment makes pointer from integer without a cast Which are 64bit issues.
And all three because a header wasn't included. I've also fixed some warnings because of int<->pointer casts. You'll get a collaboration request that'll contains all my fixes.
Philipp
Could you post the output of "osc sr show -d $foo" here ? It could help people understand/fix similar issues. Best, Jan-Simon -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, 19 Feb 2009 22:30:30 +0100, you wrote:
Could you post the output of "osc sr show -d $foo" here ?
I can't because I'm at home now and don't know the sr number. But it was simply casting ints to long before casting them to pointer, i.e. instead of (void *)(int)val it's now (void *)(long)val Another possibility would be to include stdint.h and use intptr_t or uintptr_t for casting. If it's software using glib you can use the GINT_TO_POINTER and GPOINTER_TO_INT macros to cast from/to pointer. Philipp -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, 2009-02-19 at 21:39 +0100, Philipp Thomas wrote:
* Philipp Thomas (pth@suse.de) [20090219 21:13]:
These are all: warning: assignment makes pointer from integer without a cast Which are 64bit issues.
And all three because a header wasn't included. I've also fixed some warnings because of int<->pointer casts. You'll get a collaboration request that'll contains all my fixes.
Philipp
Philipp, Many many thanks for the help it is most appreciated, not just by me but the small and growing Bongo community as well :-) Regards, Andy -- Andrew Wafaa, openSUSE Member: FunkyPenguin. openSUSE: Get It, Discover It, Create It at http://www.opensuse.org awafaa@opensuse.org | http://www.wafaa.eu -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Andrew Wafaa wrote:
My spec file has: %pre #Add the bongo user & group /usr/sbin/groupadd -r bongo 2> /dev/null || : /usr/sbin/useradd -r -g bongo -s /bin/false -c "Bongo Mail daemon" -d /etc/bongo bongo 2> /dev/null || :
%post #Ensure that the data directory has the correct ownership permissions chown -R bongo /var/bongo %fillup_only bongo
%preun %{stop_on_removal} bongo
%postun %{insserv_cleanup}
And actually, it is also missing %{restart_on_update} bongo in %pre script. And %post should probably use %{fillup_and_insserv} (syntax depends, whether you have init script and sysconfig or only init script). -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
* Stanislav Brabec (sbrabec@suse.cz) [20090220 16:41]:
And actually, it is also missing %{restart_on_update} bongo in %pre script.
Good spotting!
And %post should probably use %{fillup_and_insserv} (syntax depends, whether you have init script and sysconfig or only init script).
It should, as it only has the init script and no sysconfig. Philipp -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (6)
-
Andrew Wafaa -
Cristian Rodríguez -
Jan-Simon Möller -
Philipp Thomas -
Philipp Thomas -
Stanislav Brabec