[opensuse-packaging] allowing download in python package?
I am upgrading the package python-zope.testbrowser to its latest version. The tests were disabled because they were broken, but I have reason to believe from the change log that upstream has fixed the broken tests. Indeed, re-enabling the tests have only one failure now instead of four. The test that is failing is trying "browser.open('http://google.com/ncr')", so clearly the restriction to block installation of other python packages during a build is causing this failure. Is there any way to work around the restriction to allow this test to happen: temporarily disable the restriction or allow a certain URL or subset of URLs? Tests are good, it would be nice to enable them again. -- Jason Craig -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Sat, 1 Mar 2014 18:17, Jason Craig <os-dev@...> wrote:
I am upgrading the package python-zope.testbrowser to its latest version. The tests were disabled because they were broken, but I have reason to believe from the change log that upstream has fixed the broken tests. Indeed, re-enabling the tests have only one failure now instead of four.
The test that is failing is trying "browser.open('http://google.com/ncr')", so clearly the restriction to block installation of other python packages during a build is causing this failure. Is there any way to work around the restriction to allow this test to happen: temporarily disable the restriction or allow a certain URL or subset of URLs? Tests are good, it would be nice to enable them again.
OBS has no external network. PERIOD. (Virtual-Machine, case closed) No test accessing anyting other than 127.0.0.1 will ever work. Either you disable (only) this test, or you have to bring your own http-deamon for the test. possible to do: - Include a distro-patch that disables this special test. - Make the test clever, e.g. test for network before hand. - Expand the test-suite to include their own httpd. - Yamaban. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Jason Craig <os-dev@jacraig.com> Sat, 01 Mar 2014 20:17:37 +0300:
I am upgrading the package python-zope.testbrowser to its latest version. The tests were disabled because they were broken, but I have reason to believe from the change log that upstream has fixed the broken tests. Indeed, re-enabling the tests have only one failure now instead of four.
The test that is failing is trying "browser.open('http://google.com/ncr')", so clearly the restriction to block installation of other python packages during a build is causing this failure. Is there any way to work around the restriction to allow this test to happen: temporarily disable the restriction or allow a certain URL or subset of URLs? Tests are good, it would be nice to enable them again.
-- Jason Craig
Hello! The only way is to disable this test somehow, f.e. via a patch. -- Best regards, Dmitriy DA(P).DarkneSS Perlow @ Linux x64 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
El 01/03/14 14:17, Jason Craig escribió: ation of other python packages during a build is causing
this failure. Is there any way to work around the restriction to allow this test to happen: temporarily disable the restriction or allow a certain URL or subset of URLs? Tests are good, it would be nice to enable them again.
No, security people do not like that.. and it is extremely unlikely that it will be ever allowed. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Sat, Mar 1, 2014 at 12:17 PM, Jason Craig <os-dev@jacraig.com> wrote:
I am upgrading the package python-zope.testbrowser to its latest version. The tests were disabled because they were broken, but I have reason to believe from the change log that upstream has fixed the broken tests. Indeed, re-enabling the tests have only one failure now instead of four.
The test that is failing is trying "browser.open('http://google.com/ncr')", so clearly the restriction to block installation of other python packages during a build is causing this failure. Is there any way to work around the restriction to allow this test to happen: temporarily disable the restriction or allow a certain URL or subset of URLs? Tests are good, it would be nice to enable them again.
-- Jason Craig
For a local build, the network is enabled I believe. For a build.opensuse.org build, it is disabled and there is no way around it. Greg -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 01.03.2014 21:17, Jason Craig wrote:
The test that is failing is trying "browser.open('http://google.com/ncr')",
Could you demonstrate the source of this test? I don't think that this test does matter. Because you rely on google.com, and what if it is down? As for me, I would better mock socket operations in similar situations. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 03/07/2014 02:52 AM, Matwey V. Kornilov wrote:
On 01.03.2014 21:17, Jason Craig wrote:
The test that is failing is trying "browser.open('http://google.com/ncr')",
Could you demonstrate the source of this test? I don't think that this test does matter. Because you rely on google.com, and what if it is down? As for me, I would better mock socket operations in similar situations.
Ah, on closer inspection it turns out the particular test is a doctest: The browser can `open` web pages: >>> # This is tricky, since in Germany I am forwarded to google.de usually; >>> # The `ncr` forces to really go to google.com. >>> browser.open('http://google.com/ncr') >>> browser.url 'http://www.google.com/' >>> 'html' in browser.contents.lower() True ... So I will just disable this doctest from the test suite. Is there any way to do this with a command switch to "python setup.py test" that anyone knows, or will I have to patch the source? -- Jason Craig -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (6)
-
Cristian Rodríguez -
Dmitriy Perlow -
Greg Freemyer -
Jason Craig -
Matwey V. Kornilov -
Yamaban