[opensuse-packaging] yast2-gtk patch for maintenance release
Hi! The yast2-gtk package is at version 2.21.58 in the project openSUSE:11.3. However, a few bugs [1] were detected and the developer upgraded the version to 2.21.64 to fix them. Now, I have created the patch for the fixes against the older version, in a branched project [2]. To address the version updates, I renamed the source binary from yast2-gtk-2.21.58.tar.bz2 to yast2-gtk-2.21.64.tar.bz2, and the directory in that source also to yast2-gtk-2.21.64. In other words, the source in the branched project is identical to the one in the original project, with only the name changed. Then I apply the patch via the usual patch macro in the spec file: %patch -p1. Everything works, package builds without complains and installs fine. Solves the problems. Eventually, I want to submit this for maintenance release, and I wanted to know if the procedure I followed is an acceptable way of doing it or is there a better way to do this? Is it okay if the package being submitted for a maintenance release has a source with a different version number compared to the original package in the distribution? Would be much grateful for any help. [1] Critical: https://bugzilla.novell.com/show_bug.cgi?id=620513 Medium: https://bugzilla.novell.com/show_bug.cgi?id=609778 [2] https://build.opensuse.org/project/show?project=home%3Abadshah400% 3Abranches%3AopenSUSE%3A11.3 Bye -- Atri -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Hi, Le lundi 12 juillet 2010, à 19:37 +0530, Atri Bhattacharya a écrit :
Hi!
The yast2-gtk package is at version 2.21.58 in the project openSUSE:11.3. However, a few bugs [1] were detected and the developer upgraded the version to 2.21.64 to fix them. Now, I have created the patch for the fixes against the older version, in a branched project [2].
Thanks for working on that!
To address the version updates, I renamed the source binary from yast2-gtk-2.21.58.tar.bz2 to yast2-gtk-2.21.64.tar.bz2, and the directory in that source also to yast2-gtk-2.21.64. In other words, the source in the branched project is identical to the one in the original project, with only the name changed. Then I apply the patch via the usual patch macro in the spec file: %patch -p1. Everything works, package builds without complains and installs fine. Solves the problems.
I don't understand: it seems you're saying that yast2-gtk-2.21.58.tar.bz2 and yast2-gtk-2.21.64.tar.bz2 are identical. If I understand it right, then this is wrong ;-) If the solution is really to bump to version 2.21.64, it's better to really take the real yast2-gtk-2.21.64.tar.bz2 and not apply any patch on top of that. A potentially better (because safer) solution would be to keep the 2.21.58 tarball unchanged and add the patch that would fix only the problem that we want to fix with the update. I don't know if it's easier, though, since I didn't look at the changes that are needed.
Eventually, I want to submit this for maintenance release, and I wanted to know if the procedure I followed is an acceptable way of doing it or is there a better way to do this?
See above :-)
Is it okay if the package being submitted for a maintenance release has a source with a different version number compared to the original package in the distribution?
Since 11.2, we're okay doing maintenance updates with a new upstream version if the changes in the new version make sense. Btw, since you're trying to do a maintenance update for the first time (that's great!), don't hesitate to write down all issues or questions you face: we should document solutions and answers to make it easier for people to submit updates. Thanks, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Mon, 2010-07-12 at 17:00 +0200, Vincent Untz wrote:
Hi,
I don't understand: it seems you're saying that yast2-gtk-2.21.58.tar.bz2 and yast2-gtk-2.21.64.tar.bz2 are identical. If I understand it right, then this is wrong ;-)
Yes, I guessed as much.
If the solution is really to bump to version 2.21.64, it's better to really take the real yast2-gtk-2.21.64.tar.bz2 and not apply any patch on top of that.
The only change between versions 2.21.58 and 2.21.64 is the fixing of the two mentioned bugs, so I think this is what I will do. Thanks.
Since 11.2, we're okay doing maintenance updates with a new upstream version if the changes in the new version make sense.
Btw, since you're trying to do a maintenance update for the first time (that's great!), don't hesitate to write down all issues or questions you face: we should document solutions and answers to make it easier for people to submit updates.
Yes, I will keep adding to my user-page some of the things I learn, so that I can fall back on them when needed. If there is enough info there in time to be useful for more people I can make an FAQ page in the wiki appropriately. Bye. -- Atri -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (2)
-
Atri Bhattacharya
-
Vincent Untz