Hi, I am experiencing strange issue at science eso-midas Factory. brp-25-symlink want to relink my links in a quite strange manner. here is log: [ 446s] INFO: relinking /opt/eso-midas/12FEBpl1.3/context/*.ctx -> ../applic/general/etc/*.ctx ../gui/XAlice/etc/alice.ctx ../contrib /astromet/etc/astromet.ctx ../contrib/baches/etc/baches.ctx ../stdred/ccdred/etc/ccdred.ctx ../stdred/ccdtest/etc/ccdtest.ctx ../contr ib/cloud/etc/cloud.ctx ../contrib/daophot/etc/daophot.ctx ../stdred/do/etc/do.ctx ../stdred/echelle/etc/echelle.ctx ../contrib/esolv/e tc/esolv.ctx ../stdred/feros/etc/feros.ctx ../contrib/geotest/etc/geotest.ctx ../contrib/imres/etc/imres.ctx ../contrib/invent/etc/inv ent.ctx ../stdred/irac2/etc/irac2.ctx ../stdred/irspec/etc/irspec.ctx ../contrib/iue/etc/iue.ctx ../stdred/long/etc/long.ctx ../contri b/lyman/etc/lyman.ctx ../stdred/mos/etc/mos.ctx ../stdred/optopus/etc/optopus.ctx ../contrib/pepsys/etc/pepsys.ctx ../stdred/pisco/etc /pisco.ctx ../stdred/qc/etc/qc.ctx ../contrib/romafot/etc/romafot.ctx ../stdred/spec/etc/spec.ctx ../applic/statist/etc/statist.ctx .. /contrib/surfphot/etc/surfphot.ctx ../contrib/template/etc/template.ctx ../contrib/tsa/etc/tsa.ctx ../contrib/wavelet/etc/wavelet.ctx (was ../applic/general/etc/*.ctx [ 446s] ../gui/XAlice/etc/alice.ctx [ 446s] ../contrib/astromet/etc/astromet.ctx [ 446s] ../contrib/baches/etc/baches.ctx [ 446s] ../stdred/ccdred/etc/ccdred.ctx [ 446s] ../stdred/ccdtest/etc/ccdtest.ctx [ 446s] ../contrib/cloud/etc/cloud.ctx [ 446s] ../contrib/daophot/etc/daophot.ctx [ 446s] ../stdred/do/etc/do.ctx [ 446s] ../stdred/echelle/etc/echelle.ctx [ 446s] ../contrib/esolv/etc/esolv.ctx [ 446s] ../stdred/feros/etc/feros.ctx [ 446s] ../contrib/geotest/etc/geotest.ctx [ 446s] ../contrib/imres/etc/imres.ctx [ 446s] ../contrib/invent/etc/invent.ctx [ 446s] ../stdred/irac2/etc/irac2.ctx [ 446s] ../stdred/irspec/etc/irspec.ctx [ 446s] ../contrib/iue/etc/iue.ctx [ 446s] ../stdred/long/etc/long.ctx [ 446s] ../contrib/lyman/etc/lyman.ctx [ 446s] ../stdred/mos/etc/mos.ctx [ 446s] ../stdred/optopus/etc/optopus.ctx [ 446s] ../contrib/pepsys/etc/pepsys.ctx [ 446s] ../stdred/pisco/etc/pisco.ctx [ 446s] ../stdred/qc/etc/qc.ctx [ 446s] ../contrib/romafot/etc/romafot.ctx [ 446s] ../stdred/spec/etc/spec.ctx [ 446s] ../applic/statist/etc/statist.ctx [ 446s] ../contrib/surfphot/etc/surfphot.ctx [ 446s] ../contrib/template/etc/template.ctx [ 446s] ../contrib/tsa/etc/tsa.ctx [ 446s] ../contrib/wavelet/etc/wavelet.ctx) [ 446s] ln: target './/opt/eso-midas/12FEBpl1.3/context/*.ctx' is not a directory It looks like $new_link_dest and $orig_link_dest should be the paths or files, but brp-25-synlink uses expanded globs instead. This leads to wrong ln command and breaks my package :) -- With best regards, Matwey V. Kornilov http://0x2207.blogspot.com xmpp:0x2207@jabber.ru -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 03.05.2013 09:42, Matwey V. Kornilov wrote:
Hi,
I am experiencing strange issue at science eso-midas Factory. brp-25-symlink want to relink my links in a quite strange manner. here is log:
[ 446s] INFO: relinking /opt/eso-midas/12FEBpl1.3/context/*.ctx ->
You seriusly have packaged a *.ctx file? Perhaps you should fix that first Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
It seems so... but I am really wonder how it appeared in find-generated manifest file. 03.05.2013 11:54, Stephan Kulow пишет:
On 03.05.2013 09:42, Matwey V. Kornilov wrote:
Hi,
I am experiencing strange issue at science eso-midas Factory. brp-25-symlink want to relink my links in a quite strange manner. here is log:
[ 446s] INFO: relinking /opt/eso-midas/12FEBpl1.3/context/*.ctx ->
You seriusly have packaged a *.ctx file? Perhaps you should fix that first
Greetings, Stephan
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
It strange, that brp tools worked until that moment (and still works for 12.3, 12.2, etc.). This file has always been there. It is generated by the following fun bash-construction in makefile: for file in *.ctx; \ do (cd $(CTXDIR); $(LN) ../applic/$$PCK/etc/$$file $$file;) \ done And when there are no any *.ctx files in directory, the $file equals '*.ctx'. Ok, I have to fix that... 03.05.2013 11:54, Stephan Kulow пишет:
On 03.05.2013 09:42, Matwey V. Kornilov wrote:
Hi,
I am experiencing strange issue at science eso-midas Factory. brp-25-symlink want to relink my links in a quite strange manner. here is log:
[ 446s] INFO: relinking /opt/eso-midas/12FEBpl1.3/context/*.ctx ->
You seriusly have packaged a *.ctx file? Perhaps you should fix that first
Greetings, Stephan
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 03.05.2013 15:26, Matwey V. Kornilov wrote:
It strange, that brp tools worked until that moment (and still works for 12.3, 12.2, etc.). This file has always been there. It is generated by
I assume there was some subtle change in coreutils and/or bash that triggered finding that bug. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 05/03/2013 03:31 PM, Stephan Kulow wrote:
On 03.05.2013 15:26, Matwey V. Kornilov wrote:
It strange, that brp tools worked until that moment (and still works for 12.3, 12.2, etc.). This file has always been there. It is generated by
I assume there was some subtle change in coreutils and/or bash that triggered finding that bug.
I don't see a change in ln in the new coreutils package. What's the command line ln sees? ... I mean it's not a problem for ln to create such a link: $ ln -sv 'a/b/c/*.ctx' '*.ctx' '*.ctx' -> 'a/b/c/*.ctx' $ ls -ldog \*.ctx lrwxrwxrwx 1 11 May 3 16:35 *.ctx -> a/b/c/*.ctx ln (or better the kernel) even permits such a symlink to itself: $ ln -sv '*.ctx' '*.ctx' '*.ctx' -> '*.ctx' $ ls -ldog \*.ctx lrwxrwxrwx 1 5 May 3 16:38 *.ctx -> *.ctx Have a nice day, Berny -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Friday 03 of May 2013 16:42EN, Bernhard Voelker wrote:
On 05/03/2013 03:31 PM, Stephan Kulow wrote:
It strange, that brp tools worked until that moment (and still works for 12.3, 12.2, etc.). This file has always been there. It is generated by> I assume there was some subtle change in coreutils and/or bash that
On 03.05.2013 15:26, Matwey V. Kornilov wrote: triggered finding that bug.
I don't see a change in ln in the new coreutils package. What's the command line ln sees? ... I mean it's not a problem for ln to create such a link:
IMHO the problem rather is that now there isn't any matching file while before there was at least one. Michal Kubeček -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 05/03/2013 05:16 PM, Michal Kubeček wrote:
IMHO the problem rather is that now there isn't any matching file while before there was at least one.
That's strange because the original error message ln: target './/opt/eso-midas/12FEBpl1.3/context/*.ctx' is not a directory can only occur when ln is fed with multiple operands: $ ln -sv x y z ln: target `z' is not a directory Given Matwey's Makefile rule ... for file in *.ctx; \ do (cd $(CTXDIR); $(LN) ../applic/$$PCK/etc/$$file $$file;) \ done this means that there are files matching the glob *.ctx in the directory "$CTXDIR/../applic/$$PCK/etc/". But I still don't see how the *.ctx glob would result in './/opt/eso-midas/12FEBpl1.3/context/*.ctx'. Have a nice day, Berny -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Fri, 3 May 2013 18:26, Bernhard Voelker
On 05/03/2013 05:16 PM, Michal Kubeček wrote:
IMHO the problem rather is that now there isn't any matching file while before there was at least one. [snip] Given Matwey's Makefile rule ...
for file in *.ctx; \ do (cd $(CTXDIR); $(LN) ../applic/$$PCK/etc/$$file $$file;) \ done
Constuct fails due to wrong / changed glob options in shell, or "missing file" handling in "ln", please add test for $file: for file in *.ctx; do test -e "$file" && \ (cd $(CTXDIR); $(LN) ../applic/$$PCK/etc/$$file $$file;) \ done Maybe 'test -s "$file"' would be even better. "make" (here most likely GNU make) and shell opts like each other similar to cats and dogs. Such traps are hell to find, and easy to create. - Yamaban.
Actually, there is no problem in *.ctx link. But there are other real files.ctx in the same target directory, so the issue was that in brp, filename *.ctx was treated as blob and expanded. 03.05.2013 18:42, Bernhard Voelker пишет:
On 05/03/2013 03:31 PM, Stephan Kulow wrote:
On 03.05.2013 15:26, Matwey V. Kornilov wrote:
It strange, that brp tools worked until that moment (and still works for 12.3, 12.2, etc.). This file has always been there. It is generated by
I assume there was some subtle change in coreutils and/or bash that triggered finding that bug.
I don't see a change in ln in the new coreutils package. What's the command line ln sees? ... I mean it's not a problem for ln to create such a link:
$ ln -sv 'a/b/c/*.ctx' '*.ctx' '*.ctx' -> 'a/b/c/*.ctx'
$ ls -ldog \*.ctx lrwxrwxrwx 1 11 May 3 16:35 *.ctx -> a/b/c/*.ctx
ln (or better the kernel) even permits such a symlink to itself:
$ ln -sv '*.ctx' '*.ctx' '*.ctx' -> '*.ctx'
$ ls -ldog \*.ctx lrwxrwxrwx 1 5 May 3 16:38 *.ctx -> *.ctx
Have a nice day, Berny
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (5)
-
Bernhard Voelker
-
Matwey V. Kornilov
-
Michal Kubeček
-
Stephan Kulow
-
Yamaban