[opensuse-packaging] When to use the Reopen Request feature and when to close the issue and open a new SR.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi openSUSE packagers of the year 2013, when I initially "learned" packaging, I used to supersede old/bad requests by just issuing new requests that fixed what was wrong. For some time there has been a button "reopen request" on revoked requests in the obs and I am unsure when to use it. When I view a declined request after adding, for example, missing changelog details, I still see the old diff. What will "reopen" do then? Re-submit the old declined SR as-is or submit an SR for the current state of the project repository? What is a good example for using reopen and when should I just close and submit a new sr? - -- Ralf Lang Linux Consultant / Developer Tel.: +49-170-6381563 Mail: lang@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlDqj6EACgkQCs1dsHJ/X7A0eACgj0yFrOKHnjGQG62MhEP/WTdw JUYAn1OQ7/6WN5YmDp5tstv7o7LmQRHl =n1q8 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 7 January 2013 09:04, Ralf Lang <lang@b1-systems.de> wrote:
When I view a declined request after adding, for example, missing changelog details, I still see the old diff. What will "reopen" do then? Re-submit the old declined SR as-is or submit an SR for the current state of the project repository?
Re-submit the old declined SR as-is
What is a good example for using reopen and when should I just close and submit a new sr?
You should reopen it if I reject your request saying it has a problem and you disagree. You reopen it with a message like "Please, review again when you are not drunk" or the polite equivalent explaining why you disagree. You should just close (revoke) and submit a new sr when you agree with the rejection and need to do some change before resubmitting. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Am Montag, 7. Januar 2013, 09:19:14 schrieb Cristian Morales Vega:
On 7 January 2013 09:04, Ralf Lang <lang@b1-systems.de> wrote:
When I view a declined request after adding, for example, missing changelog details, I still see the old diff. What will "reopen" do then? Re-submit the old declined SR as-is or submit an SR for the current state of the project repository?
Re-submit the old declined SR as-is
What is a good example for using reopen and when should I just close and submit a new sr?
You should reopen it if I reject your request saying it has a problem and you disagree. You reopen it with a message like "Please, review again when you are not drunk" or the polite equivalent explaining why you disagree.
You should just close (revoke) and submit a new sr when you agree with the rejection and need to do some change before resubmitting.
Small side note, you do not need to explicit to revoke it in this case. Current osc sr of the new one will offer you to supersede the old request automatically. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Mon, Jan 07, 2013 at 10:04:33AM +0100, Ralf Lang wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi openSUSE packagers of the year 2013,
when I initially "learned" packaging, I used to supersede old/bad requests by just issuing new requests that fixed what was wrong.
For some time there has been a button "reopen request" on revoked requests in the obs and I am unsure when to use it.
When I view a declined request after adding, for example, missing changelog details, I still see the old diff. What will "reopen" do then? Re-submit the old declined SR as-is or submit an SR for the current state of the project repository?
Hi Ralf, reopen don't add anything what have happened in a meanwhile in source project. So the old sumission is requested again.
What is a good example for using reopen and when should I just close and submit a new sr?
For instance - you made a sr from a project not on a list of Factory devel project. In that case, you can reopen it again when the source project is added on such list. Regards Michal Vyskocil
- -- Ralf Lang Linux Consultant / Developer Tel.: +49-170-6381563 Mail: lang@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/
iEYEARECAAYFAlDqj6EACgkQCs1dsHJ/X7A0eACgj0yFrOKHnjGQG62MhEP/WTdw JUYAn1OQ7/6WN5YmDp5tstv7o7LmQRHl =n1q8 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Hi, Reopen is used when the repository maintainer makes a wrong decision. It means the SR will be always the same as your first submit. Or it should be a new SR. But you explain/debate and give them a second chance to accept. Marguerite -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (5)
-
Adrian Schröter
-
Cristian Morales Vega
-
Marguerite
-
Michal Vyskocil
-
Ralf Lang