[opensuse-packaging] E: athena 64-bit-portability issue
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build): 61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457 The offending code from src/athena-toolbar.c is: GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; } I'm not sure how this would affect portability. Is this a glitch in osc/OBS, or do I have something wrong in my source?
On 05/18/2013 12:41 AM, Shawn W Dunn wrote:
[ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
I don't have the code, but it sounds like self->priv->show_location_entry is not of type (GtkWidget *), is it? If it's e.g. a long value, then this may overwrite the stack, because there's only place for a pointer which is probably smaller. Have a nice day, Berny -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hey Shawn,
one comment
- use git archive for exporting source code from git (it will auto
remove .git and can help packaging so you do not need to think about
naming package later)
* example of git archive command: git archive --format tar
--prefix=athena-1.0/ -o ../athena-1.0.tar master
On Sat, May 18, 2013 at 12:41 AM, Shawn W Dunn
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build):
61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
I'm not sure how this would affect portability. Is this a glitch in osc/OBS, or do I have something wrong in my source? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Saturday 2013-05-18 00:41, Shawn W Dunn wrote:
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build):
61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
What you see here is the rpmlint summary of compiler-emitted warnings. Please search the build log for gcc's warnings for "athena-toolbar.c:457" and post them too. Those will usually give the useful, sought-for message. Chances are, it is "cast from/to pointer of different size", or value truncation..
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 05/17/2013 04:29 PM, Jan Engelhardt wrote:
On Saturday 2013-05-18 00:41, Shawn W Dunn wrote:
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build):
61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
What you see here is the rpmlint summary of compiler-emitted warnings. Please search the build log for gcc's warnings for "athena-toolbar.c:457" and post them too. Those will usually give the useful, sought-for message.
Chances are, it is "cast from/to pointer of different size", or value truncation..
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
Alrighty, here are the relevant lines from the build log: 957 [ 70s] athena-toolbar.c:457:2: warning: return makes pointer from integer without a cast [enabled by default]
On 05/18/2013 12:11 AM, Shawn W Dunn wrote:
On 05/17/2013 04:29 PM, Jan Engelhardt wrote:
On Saturday 2013-05-18 00:41, Shawn W Dunn wrote:
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build):
61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
What you see here is the rpmlint summary of compiler-emitted warnings. Please search the build log for gcc's warnings for "athena-toolbar.c:457" and post them too. Those will usually give the useful, sought-for message.
Chances are, it is "cast from/to pointer of different size", or value truncation..
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
Alrighty, here are the relevant lines from the build log: 957 [ 70s] athena-toolbar.c:457:2: warning: return makes pointer from integer without a cast [enabled by default]
This is 99.9% of the time a bug that will make your program crash, or worst..do weird things. Ask upstream to fix it. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On 05/17/2013 11:03 PM, Cristian Rodríguez wrote:
On 05/18/2013 12:11 AM, Shawn W Dunn wrote:
On 05/17/2013 04:29 PM, Jan Engelhardt wrote:
On Saturday 2013-05-18 00:41, Shawn W Dunn wrote:
I'm building devel:cloverleaf:Consort/athena, and I get to this stage of the build locally (osc build):
61s] ... running 01-check-debuginfo [ 61s] ... testing for empty debuginfo packages [ 61s] ... running 02-check-gcc-output [ 61s] ... testing for serious compiler warnings [ 61s] (using /usr/lib/build/checks-data/check_gcc_output) [ 61s] (using /var/tmp/build-root/.build.log) [ 61s] E: athena 64bit-portability-issue athena-toolbar.c:457
What you see here is the rpmlint summary of compiler-emitted warnings. Please search the build log for gcc's warnings for "athena-toolbar.c:457" and post them too. Those will usually give the useful, sought-for message.
Chances are, it is "cast from/to pointer of different size", or value truncation..
The offending code from src/athena-toolbar.c is:
GtkWidget * athena_toolbar_get_show_location_entry (AthenaToolbar *self) { return self->priv->show_location_entry; }
Alrighty, here are the relevant lines from the build log: 957 [ 70s] athena-toolbar.c:457:2: warning: return makes pointer from integer without a cast [enabled by default]
This is 99.9% of the time a bug that will make your program crash, or worst..do weird things.
Ask upstream to fix it.
Will do. Thanks for confirming where my issue is.
participants (5)
-
Bernhard Voelker -
Boris Manojlovic -
Cristian Rodríguez -
Jan Engelhardt -
Shawn W Dunn