Le lundi 30 janvier 2012, à 10:08 +0100, Richard Guenther a écrit :

On Mon, 30 Jan 2012, Vincent Untz wrote:

...

Hi all,

For a while, we've had the issue of packages with changes in devel projects not always being submitted to Factory. At the last openSUSE Conference, it appeared that not everyone was aware that this had to be manually done, and one solution that was discussed involved automatic submission.

After some push from coolo, I finished a script I started working on a while ago, and we now have obs-autosubmit: https://gitorious.org/opensuse/obs-autosubmit

To put it simply, it submits unsubmitted changes to Factory. It tries hard to be clever, for instance:

Err, I think this idea is completely broken. These are "development" projects after all. Now, do we want to split devel projects into a "staging" project (state to be submitted to factory (after some while?)) and a real "devel" project (where development happens?).

The issue here is that you're assuming everyone is using the devel projects the same way. A good number of contributors really want to have all their changes submitted to Factory -- they'd commit directly to Factory if they could. We can argue for ages about whether they're wrong or not, how we could make sure they follow some different process, etc. Or we can make their life easier. And yes, for me too, the autosubmit behavior would be broken. Btw, note that obs-autosubmit doesn't act as soon as there is a change in the devel project. There's usually a delay caused by various reasons, and I think it'd make sense to add some check to make sure that the last change is not too recent. [...]

Please never autosubmit packages maintained by me (devel:gcc, devel:libraries:c_c++/{cloog,gmp,mpc,mpfr,ppl}).

Sure, I've blacklisted those. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Le lundi 30 janvier 2012, à 12:05 +0100, Juergen Weigert a écrit :

On Jan 30, 12 10:37:26 +0100, Vincent Untz wrote:

...

...

...

For a while, we've had the issue of packages with changes in devel projects not always being submitted to Factory. At the last openSUSE Conference, it appeared that not everyone was aware that this had to be manually done, and one solution that was discussed involved automatic submission.

After some push from coolo, I finished a script I started working on a while ago, and we now have obs-autosubmit: https://gitorious.org/opensuse/obs-autosubmit

To put it simply, it submits unsubmitted changes to Factory. It tries hard to be clever, [...] Things that are clever usually fail horribly sometimes.

Sure. Except that it doesn't do anything that can't be reverted, so failing horribly 1% of the time is acceptable, at least to me. (Ok, I can imagine the case where some change in a package has a bug leading to a your disk getting formatted -- that is bad, but that'd be bad for people using the devel project too...)

For years we have learned that not everything qualifies for Factory. Some of the packages I felt important were rejected with something like 'They make Factory too big'. This does not mix well with the idea that devel maintainers should be responsible for filling up Factory.

That's an issue orthogonal to autosubmit, isn't it?

On the other hand, there are devel projects, where stuff is horribly broken, if you look at the wrong point of time. E.g. making a major update, that affects many individual packages.

Yes, that's exactly why we have a blacklist and why I don't want autosubmit for GNOME:Factory. However, I'd argue that only a subset of devel projects work this way. I'm not saying this is good or bad; it's just the way things are and have been for a while.

I am in favour of an automated script searching for submission candidates. But rather than directly submitting, tell the devel maintainers, that Factory wants one of their Packages, and provide a copy-paste submit request template. That could be a submit request to Factory where the devel maintainers group is added as Reviewers,

We can do that too, and we actually discussed this. The issue is that it relies on people receiving and reading their hermes mail. We could experiment autosubmit by forcing all requests to be in review first? Coolo, what do you think? Cheers, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Jan 30, 12 12:39:43 +0100, Stephan Kulow wrote:

On 30.01.2012 12:25, Vincent Untz wrote:

...

We can do that too, and we actually discussed this. The issue is that it relies on people receiving and reading their hermes mail.

We could experiment autosubmit by forcing all requests to be in review first? Coolo, what do you think?

The problem at hand is that only the target maintainer gets email if a submit request is created. The maintainer of e.g. devel:gcc won't notice there is a new request for him to review unless he polls.

Ouch. Does that also mean, that I would not get any emails if someone adds me as reviewer to some non-factory requests? cheers, JW- -- o \ Juergen Weigert paint it green! __/ _=======.=======_ <V> | jw@suse.de back to ascii! __/ _---|____________\/ \ | 0911 74053-508 say #263A!__/ (____/ /\ (/) | _____________________________/ _/ \_ vim:set sw=2 wm=8 SUSE LINUX Products GmbH, GF: Jeff Hawn, J.Guild, F.Imendoerffer, HRB 16746 (AG Nuernberg), Maxfeldstrasse 5, 90409 Nuernberg, Germany SuSE. Supporting Linux since 1992. ☺ -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Jan 30, 12 12:25:34 +0100, Vincent Untz wrote:

...

That could be a submit request to Factory where the devel maintainers group is added as Reviewers,

We can do that too, and we actually discussed this. The issue is that it relies on people receiving and reading their hermes mail.

Devel projects are often maintained by a group of people. So individuals who are not reachable do little harm. This is not relying on emails. I get notification of pending requests when I browse my packages on build.o.o and also when I use osc. Sure, there is still room for improvement there, but hey... cheers, JW- -- o \ Juergen Weigert paint it green! __/ _=======.=======_ <V> | jw@suse.de back to ascii! __/ _---|____________\/ \ | 0911 74053-508 say #263A!__/ (____/ /\ (/) | _____________________________/ _/ \_ vim:set sw=2 wm=8 SUSE LINUX Products GmbH, GF: Jeff Hawn, J.Guild, F.Imendoerffer, HRB 16746 (AG Nuernberg), Maxfeldstrasse 5, 90409 Nuernberg, Germany SuSE. Supporting Linux since 1992. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 30.01.2012 12:05, Juergen Weigert wrote:

On Jan 30, 12 10:37:26 +0100, Vincent Untz wrote:

...

...

...

For a while, we've had the issue of packages with changes in devel projects not always being submitted to Factory. At the last openSUSE Conference, it appeared that not everyone was aware that this had to be manually done, and one solution that was discussed involved automatic submission.

After some push from coolo, I finished a script I started working on a while ago, and we now have obs-autosubmit: https://gitorious.org/opensuse/obs-autosubmit

To put it simply, it submits unsubmitted changes to Factory. It tries hard to be clever, [...] Things that are clever usually fail horribly sometimes.

For years we have learned that not everything qualifies for Factory. Some of the packages I felt important were rejected with something like 'They make Factory too big'. That must be pretty old news. Anyway, new packages are not the topic here. We're talking about 375 packages that are already in factory and have an updated .changes file in their devel project and are not submitted. Some for weeks.

Greetings, Stephan

This does not mix well with the idea that devel maintainers should be responsible for filling up Factory.

-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 30.01.2012 12:31, Ruediger Meier wrote:

BTW does auto-submit mean that submit request will be done automatically but still have to be accepted by Factory manually? Would it's possible to add the devel package maintainer as reviewer such that he has the right of veto.

Or how about only sending a reminder email automatically to the maintainer, like "package xyz is ahead Factory, consider submit request".

We will have reminder mails anyway. If you don't want your package to be autosubmitted, tell vuntz - that's the whole point of his email. If you read Vincent's email, the auto-submit was an explicit wish of many people taking part of the factory workflow workshop on the openSUSE conference. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 30.01.2012 13:01, Richard Guenther wrote:

On Mon, 30 Jan 2012, Stephan Kulow wrote:

...

On 30.01.2012 12:31, Ruediger Meier wrote:

...

BTW does auto-submit mean that submit request will be done automatically but still have to be accepted by Factory manually? Would it's possible to add the devel package maintainer as reviewer such that he has the right of veto.

Or how about only sending a reminder email automatically to the maintainer, like "package xyz is ahead Factory, consider submit request".

We will have reminder mails anyway. If you don't want your package to be autosubmitted, tell vuntz - that's the whole point of his email.

If you read Vincent's email, the auto-submit was an explicit wish of many people taking part of the factory workflow workshop on the openSUSE conference.

Why not make a whitelist instead then, or add a package/project attribute that can be set so that each osc commit automatically asks if it should do a osc sr afterwards? External bots really do not like the correct hammer to hit this nail.

We tried the "maintainers submit it" model for quite some time with very low success, so let's try the black list approach for a while and _then_ discuss next steps please? As Vincent said, no harm is (supposed to be) done and we need to refine this process. Having ideas on how the next step should look like is fine, but having solutions ready for problems we see is better. That having said, putting your project on the black list is _fine_, we want more people/projects to do proper submissions - but a sad fact is that currently most don't. osc prompting for every commit sounds very annoying too, btw. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Mon, Jan 30, 2012 at 6:08 AM, Richard Guenther wrote:

...

If you want to *not* have automatic submission for your project or your package, please tell me!

Please never autosubmit packages maintained by me (devel:gcc, devel:libraries:c_c++/{cloog,gmp,mpc,mpfr,ppl}).

I'm aware of the need to submit, I keep modified packages in devel until I've properly tested them. So, don't autosubmit mine either (only devel:languages:python:python-ipaddr) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Le lundi 30 janvier 2012, à 15:27 +0100, Guido Berhoerster a écrit :

Hi,

* Vincent Untz [2012-01-30 09:54]:

...

If you want to *not* have automatic submission for your project or your package, please tell me!

please blacklist X11:xfce.

Done: https://gitorious.org/opensuse/obs-autosubmit/commit/b1ab528c86839ea71b2d06e... Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Le lundi 30 janvier 2012, à 09:41 -0500, Greg Freemyer a écrit :

I think there should also be a "minimal stable time" requirement.

For instance if the changes file was updated and if NO changes have occurred in 2 weeks, it is a candidate for auto-submission.

That would give the maintainer a couple weeks to test things before they are auto-submitted.

4-weeks might be even better considering this mechanism is supposed to be a fallback solution, not the primary solution.

Yes, that was planned. And it's now implemented: the changes need to be older than a week (totally arbitrary value, but it seems reasonable). Cheers, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Mon, Jan 30, 2012 at 01:01:37PM -0500, Robert Schweikert wrote:

Thanks you :)

On 01/30/2012 03:54 AM, Vincent Untz wrote:

...

Hi all,

For a while, we've had the issue of packages with changes in devel projects not always being submitted to Factory. At the last openSUSE Conference, it appeared that not everyone was aware that this had to be manually done, and one solution that was discussed involved automatic submission.

After some push from coolo, I finished a script I started working on a while ago, and we now have obs-autosubmit: https://gitorious.org/opensuse/obs-autosubmit

To put it simply, it submits unsubmitted changes to Factory. It tries hard to be clever, for instance:

- it only submits changes if the .changes entry is different - it doesn't submit a change that is already submitted - it doesn't submit a change that was declined/superseded

Coupled with the factory-auto checks, this means that changed packages that don't build won't get through. (This has one issue, though: if a package failed to build because of another package being broken and got automatically submitted, it won't be automatically submitted again when the other package gets fixed)

However, automatic submission is something that some people might not want. For instance, in GNOME:Factory, that'd be insane as we generally need to push several packages together and we do this after testing G:F. Therefore, there's a way to disable this automatic submission for either a whole project, or specific packages. Right now, this way is a hardcoded list, but we'll likely use attributes in the future.

If you want to *not* have automatic submission for your project or your package, please tell me!

Eventually implementing an attribute in the meta data in OBS would be great to avoid the maintenance of the blacklist. But this is a great first step. Thanks for spending the time and effort to address this.

Hallo Vincent, please implement some special project/package attribute OBS:autocommit=false. This blacklisting is clumsy and not scallable. For example you would be able to disable the auto-submit only temporary, when you know the work will need more time. Sending you an email with please add/remove it from blacklist is not scallable. Regards Michal Vyskocil

Robert

-- Robert Schweikert MAY THE SOURCE BE WITH YOU SUSE-IBM Software Integration Center LINUX Tech Lead rjschwei@suse.com rschweik@ca.ibm.com 781-464-8147 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 01.02.2012 16:56, Vincent Untz wrote:

Le mercredi 01 février 2012, à 16:44 +0100, Michal Vyskocil a écrit :

...

Hallo Vincent,

please implement some special project/package attribute OBS:autocommit=false. This blacklisting is clumsy and not scallable. For example you would be able to disable the auto-submit only temporary, when you know the work will need more time. Sending you an email with please add/remove it from blacklist is not scallable.

That was the plan since the beginning, and there's a git branch that does just this already [1]. I just need to get the attribute name approved and test the branch.

Created the attribute now. Maintainers need to set it now (either on package or project Example of use: coolo@desdemona#~>osc meta attribute -c --attribute openSUSE:DisableAutoSubmit KDE:Distro:Factory <?xml version="1.0" encoding="UTF-8"?> <status code="ok"> <summary>Ok</summary> <details></details> </status> Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On 01.02.2012 17:42, Vincent Untz wrote:

Actually, I prefer if the value is set to true/1/etc. explicitly (so we can have the option to override the value for a specific package in a project where autosubmit is disabled):

osc meta attribute PROJECT [PACKAGE] --attribute openSUSE:DisableAutoSubmit --set true

I'll mail everyone who wanted to have something in the blacklist with commands they can copy & paste (and I'll keep the packages in the blacklist until they've run those commands).

true is a dangerous value, because what does "disable false" mean? Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Le jeudi 02 février 2012, à 10:12 +0100, Michal Vyskocil a écrit :

On Thu, Feb 02, 2012 at 09:44:55AM +0100, Stephan Kulow wrote:

...

On 01.02.2012 17:42, Vincent Untz wrote:

...

Actually, I prefer if the value is set to true/1/etc. explicitly (so we can have the option to override the value for a specific package in a project where autosubmit is disabled):

osc meta attribute PROJECT [PACKAGE] --attribute openSUSE:DisableAutoSubmit --set true

I'll mail everyone who wanted to have something in the blacklist with commands they can copy & paste (and I'll keep the packages in the blacklist until they've run those commands).

true is a dangerous value, because what does "disable false" mean?

"Disable: false" means "Enable" to me. Right, it's a double negative. I'm happy to change to openSUSE:EnableAutoSubmit if you want :-)

Then use on/off (or on/<everything else>) - it makes a perfect sense.

Why not, done. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Wed, Feb 01, 2012 at 04:56:43PM +0100, Vincent Untz wrote:

Le mercredi 01 février 2012, à 16:44 +0100, Michal Vyskocil a écrit :

...

Hallo Vincent,

please implement some special project/package attribute OBS:autocommit=false. This blacklisting is clumsy and not scallable. For example you would be able to disable the auto-submit only temporary, when you know the work will need more time. Sending you an email with please add/remove it from blacklist is not scallable.

That was the plan since the beginning, and there's a git branch that does just this already [1]. I just need to get the attribute name approved and test the branch.

Cool, in this case your feature is brilliant ;-) Thanks for doing that Michal Vyskocil

Cheers,

Vincent

[1] https://gitorious.org/opensuse/obs-autosubmit/commits/wip/attributes

-- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Mon, Jan 30, 2012 at 7:17 PM, Greg Freemyer wrote:

A status column for packages in devel projects which showed:

-- Not in factory at all -- Initial submission to factory pending -- Initial submission to factory rejected -- In factory and current -- In factory, but factory is not current -- In factory, and factory update submission pending -- In factory, and factory update submission rejected

would increase the likelihood I kept a handle on my various devel packages.

I can throw this into openfate if it would be useful.

It would get my vote. Right now, SR are sometimes rather inconspicuous. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Tuesday 31 January 2012, Stephan Kulow wrote:

On 30.01.2012 23:17, Greg Freemyer wrote:

...

I look at the WebUI My Projects page fairly often to help me remember what projects I'm a maintainer for.

A status column for packages in devel projects which showed:

-- Not in factory at all -- Initial submission to factory pending -- Initial submission to factory rejected -- In factory and current -- In factory, but factory is not current -- In factory, and factory update submission pending -- In factory, and factory update submission rejected

would increase the likelihood I kept a handle on my various devel packages.

I can throw this into openfate if it would be useful.

Throw it in if you think it's useful, but it's pretty hard to implement, taking that OBS is not only for factory. It would be pretty confusing for people if the packages view changes depending on devel packages around - IMO.

It's pitty that obs packages are not git based. This way you could "git remote add" factory or whatever package you want. Would be easy to see what is merged and what is not.

What I work on though is a subset of the above - making the factory status filterable for username. I use that information then to also send a reminder mail. E.g. ttp://goo.gl/wpKps is the factory status filtered for vuntz - which is a bit more "interesting" than yours:

https://build.opensuse.org/stage/project/status?project=openSUSE%3AFa ctory&filter_devel=All+Packages&ignore_pending=true&limit_to_fails=fal se&include_versions=false&filter_for_user=gregfreemyer

The "update rejected" is something Vincent worked on and I think we should integrate into the project status. At least if you go to build.opensuse.org, you see your rejected submissions as part of /home/my_work now, I see 2 on

https://build.opensuse.org/stage/home/my_work?user=gregfreemyer

Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Am 31.01.2012 19:38, schrieb Greg Freemyer:

(Yesterday's rejection of bulk_extractor being a prime example. It depends on libewf, which depends on python-fuse, which I just submitted to factory yesterday. So when it gets in, I have to remember to submit libewf. When that gets in I have to remember to submit bulk_extractor. When you're doing it very part time like me, it can take months for that sequence to work out and I forget what status the various packages are in.)

Understood. There the list of declined requests can become a very handy TODO list :) Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org