[opensuse-packaging] /etc/modprobe.* changes
Hi, the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf. Also, mkinitrd should be updated to not copy /etc/modprobe.conf* if it's not there. Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
At Mon, 16 Mar 2009 15:08:54 +0100, Michal Marek wrote:
Hi,
the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf.
These files can be created dynamically by a program or YaST, e.g. /etc/modprobe.d/sound file. Which package / program is responsible to rename them in the update path and how? thanks, Takashi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Takashi Iwai napsal(a):
At Mon, 16 Mar 2009 15:08:54 +0100, Michal Marek wrote:
the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf.
These files can be created dynamically by a program or YaST, e.g. /etc/modprobe.d/sound file. Which package / program is responsible to rename them in the update path and how?
Good point. I'd say the package that creates the file should take care of renaming it during update. It should be pretty simple: %post if test -e /etc/modprobe.d/$oldname; then mv -f /etc/modprobe.d/$oldname /etc/modprobe.d/50-$oldname.conf fi I'll file a bug against yast2-sound. Does anybody know about any other package that creates modprobe.d files at runtime? Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Michal Marek napsal(a):
Good point. I'd say the package that creates the file should take care of renaming it during update. It should be pretty simple:
%post if test -e /etc/modprobe.d/$oldname; then mv -f /etc/modprobe.d/$oldname /etc/modprobe.d/50-$oldname.conf fi
I'll file a bug against yast2-sound. Does anybody know about any other package that creates modprobe.d files at runtime?
Reply to myself: grep -r /etc/modprobe /usr/share/YaST2/ Any other programs besides YaST2 modifying modprobe config? Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
At Tue, 17 Mar 2009 11:57:13 +0100, Michal Marek wrote:
Michal Marek napsal(a):
Good point. I'd say the package that creates the file should take care of renaming it during update. It should be pretty simple:
%post if test -e /etc/modprobe.d/$oldname; then mv -f /etc/modprobe.d/$oldname /etc/modprobe.d/50-$oldname.conf fi
I'll file a bug against yast2-sound. Does anybody know about any other package that creates modprobe.d files at runtime?
Reply to myself: grep -r /etc/modprobe /usr/share/YaST2/
Any other programs besides YaST2 modifying modprobe config?
alsaconf would do. But it should be deprecated for 11.2, anyway... Takashi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
At Tue, 17 Mar 2009 11:40:00 +0100, Michal Marek wrote:
Takashi Iwai napsal(a):
At Mon, 16 Mar 2009 15:08:54 +0100, Michal Marek wrote:
the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf.
These files can be created dynamically by a program or YaST, e.g. /etc/modprobe.d/sound file. Which package / program is responsible to rename them in the update path and how?
Good point. I'd say the package that creates the file should take care of renaming it during update. It should be pretty simple:
%post if test -e /etc/modprobe.d/$oldname; then mv -f /etc/modprobe.d/$oldname /etc/modprobe.d/50-$oldname.conf fi
I'll file a bug against yast2-sound. Does anybody know about any other package that creates modprobe.d files at runtime?
Through a quick grep modprobe.d /usr/share/YaST, the following files seem to be created / modified via YaST: tv, ipv6, blacklist, newid, sound. Corresponding to yast2-tv, yast2-network, yast2-tune, yast2-sound. Takashi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Yeah, I'm a little late, I know. Le mardi 17 mars 2009, Michal Marek a écrit :
Takashi Iwai napsal(a):
These files can be created dynamically by a program or YaST, e.g. /etc/modprobe.d/sound file. Which package / program is responsible to rename them in the update path and how?
Good point. I'd say the package that creates the file should take care of renaming it during update. It should be pretty simple:
%post if test -e /etc/modprobe.d/$oldname; then mv -f /etc/modprobe.d/$oldname /etc/modprobe.d/50-$oldname.conf fi
I'll file a bug against yast2-sound. Does anybody know about any other package that creates modprobe.d files at runtime?
The sensors package does. I've just taken care of it. -- Jean Delvare Suse L3 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 3/16/2009 at 15:08, Michal Marek <mmarek@suse.cz> wrote: Hi,
the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf.
Also, mkinitrd should be updated to not copy /etc/modprobe.conf* if it's not there.
Michal, the vmware KMPs install a /etc/modprobe.d/vmnics file. I will change this to the new file name with the next monthly sync with upstream. I was though wondering what importance / function the number 50 has. I assume it is sort of priorization? Can you elaborate on this please? Also $name: should this be in any way related to the package name? so far, the vmware-kmp installs a file called vmnics (as it mangles the loading of vmnics (virtual machine nics). Should that also be adjusted to reflect any given name? Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Dominique Leuenberger napsal(a):
On 3/16/2009 at 15:08, Michal Marek <mmarek@suse.cz> wrote: Hi,
the new module-init-tools, which will appear in Factory soon, deprecated /etc/modprobe.conf(.local) and only uses /etc/modprobe.d/*.conf configuration files (files without the .conf suffix are still read, but cause a warning). I tried to find and fix packages that install modprobe config files, but in case I missed some, the fix is simple: change /etc/modprobe.d/$name to /etc/modprobe.d/50-$name.conf.
Also, mkinitrd should be updated to not copy /etc/modprobe.conf* if it's not there.
Michal,
the vmware KMPs install a /etc/modprobe.d/vmnics file. I will change this to the new file name with the next monthly sync with upstream.
I think I sent you a submitreq already.
I was though wondering what importance / function the number 50 has. I assume it is sort of priorization? Can you elaborate on this please?
It's just a number between 00-system.conf and 99-local.conf, it doesn't have to be exactly 50 if you don't like it, but you should use a two-digit prefix to that the files are read in a sensible order.
$name: should this be in any way related to the package name? so far, the vmware-kmp installs a file called vmnics (as it mangles the loading of vmnics (virtual machine nics). Should that also be adjusted to reflect any given name?
That's really up to you. If you want to change the name to something better then it's a good idea to do it now as you have to rename the file anyway, but I don't think there need to be rules for it. Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 3/18/2009 at 11:30, Michal Marek <mmarek@suse.cz> wrote: Dominique Leuenberger napsal(a): the vmware KMPs install a /etc/modprobe.d/vmnics file. I will change this to the new file name with the next monthly sync with upstream.
I think I sent you a submitreq already.
Ok.. I think the SR went against the -devel project of those packages, which lies in Pavol's home. Thanks for that. I'm sure Pavol is going to propagate it in this case.
I was though wondering what importance / function the number 50 has. I assume it is sort of priorization? Can you elaborate on this please?
It's just a number between 00-system.conf and 99-local.conf, it doesn't have to be exactly 50 if you don't like it, but you should use a two-digit prefix to that the files are read in a sensible order.
Thanks for the explanation... so having 50 as the 'distributor' standard does not sound to wrong. I just go with the flow here ;)
$name: should this be in any way related to the package name? so far, the vmware-kmp installs a file called vmnics (as it mangles the loading of vmnics (virtual machine nics). Should that also be adjusted to reflect any given name?
That's really up to you. If you want to change the name to something better then it's a good idea to do it now as you have to rename the file anyway, but I don't think there need to be rules for it.
Define 'better' :) the file is called to what it does and serves on. Having the file called in some sort of related to the package it comes from could avoid possible clashes (granted, the amount of modprobe.d/*.conf file is rather small, so it should not happen anyhow). Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Dominique Leuenberger napsal(a):
On 3/18/2009 at 11:30, Michal Marek <mmarek@suse.cz> wrote: Dominique Leuenberger napsal(a): the vmware KMPs install a /etc/modprobe.d/vmnics file. I will change this to the new file name with the next monthly sync with upstream.
I think I sent you a submitreq already.
Ok.. I think the SR went against the -devel project of those packages, which lies in Pavol's home. Thanks for that. I'm sure Pavol is going to propagate it in this case.
Oops, I forgot to commit and send this one. Sent now (against Virtualization:VMware).
That's really up to you. If you want to change the name to something better then it's a good idea to do it now as you have to rename the file anyway, but I don't think there need to be rules for it.
Define 'better' :) the file is called to what it does and serves on. Having the file called in some sort of related to the package it comes from could avoid possible clashes (granted, the amount of modprobe.d/*.conf file is rather small, so it should not happen anyhow).
As I said: It's really up to you :). And yes, a name clash is rather unlikely. Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Dominique Leuenberger wrote:
I think I sent you a submitreq already.
Ok.. I think the SR went against the -devel project of those packages, which lies in Pavol's home. Thanks for that. I'm sure Pavol is going to propagate it in this case.
Actually, Virtualization:VMware IS the devel project for open-vm-tools :) -- Best Regards / S pozdravom, Pavol RUSNAK SUSE LINUX, s.r.o Package Maintainer Lihovarska 1060/12 PGP 0xA6917144 19000 Praha 9, CR prusnak[at]suse.cz http://www.suse.cz -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 3/18/2009 at 14:42, Pavol Rusnak <prusnak@suse.cz> wrote: Dominique Leuenberger wrote: I think I sent you a submitreq already.
Ok.. I think the SR went against the -devel project of those packages, which lies in Pavol's home. Thanks for that. I'm sure Pavol is going to propagate it in this case.
Actually, Virtualization:VMware IS the devel project for open-vm-tools :)
Pavol, Indeed... I was pretty sure you had it once in home:prusnak:factory... but you probably got tired of synching those two always together ;) Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Hi Michal, Le mercredi 18 mars 2009, Michal Marek a écrit :
Dominique Leuenberger napsal(a):
I was though wondering what importance / function the number 50 has. I assume it is sort of priorization? Can you elaborate on this please?
It's just a number between 00-system.conf and 99-local.conf, it doesn't have to be exactly 50 if you don't like it, but you should use a two-digit prefix to that the files are read in a sensible order.
As this is a SUSE-specific policy, this seems impractical for tools which aren't SUSE-specific. There's no reason to name configuration files that way for upstream, which means we'll have to carry a patch around forever for such tools. Does this really matter in practice? Do you really expect conflicting configuration files so the order matters? If a user wants to change a setting, I'd rather have them edit the right configuration file than add custom settings to 99-local.conf. -- Jean Delvare Suse L3 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Jean Delvare napsal(a):
Hi Michal,
Le mercredi 18 mars 2009, Michal Marek a écrit :
Dominique Leuenberger napsal(a):
I was though wondering what importance / function the number 50 has. I assume it is sort of priorization? Can you elaborate on this please? It's just a number between 00-system.conf and 99-local.conf, it doesn't have to be exactly 50 if you don't like it, but you should use a two-digit prefix to that the files are read in a sensible order.
As this is a SUSE-specific policy, this seems impractical for tools which aren't SUSE-specific. There's no reason to name configuration files that way for upstream, which means we'll have to carry a patch around forever for such tools.
Does this really matter in practice? Do you really expect conflicting configuration files so the order matters? If a user wants to change a setting, I'd rather have them edit the right configuration file than add custom settings to 99-local.conf.
Basically, if adding the number is a problem and conflicts are not realistic, then feel free to omit the number. The .conf extension is required though. Michal -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (5)
-
Dominique Leuenberger -
Jean Delvare -
Michal Marek -
Pavol Rusnak -
Takashi Iwai