[opensuse-packaging] New rpmlint check
Hi, I've implemented the suggestion in bnc#357040, which checks if a package, that installs a file in /etc/cron.*/ or /etc/logrotate.d/, also rpm-requires "cron". As cron is not part of a minimal installation, this explicit rpm requires is useful to make sure that your package works as designed. Please watch for "missing-dependency-to-cron" rpmlint checks. These are not fatal at the moment but they might gain badness soon. Greetings, Dirk -- RPMLINT information under http://en.opensuse.org/Packaging/RpmLint --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 2008-02-05 19:00:28 +0100, Dirk Mueller wrote:
I've implemented the suggestion in bnc#357040, which checks if a package, that installs a file in /etc/cron.*/ or /etc/logrotate.d/, also rpm-requires "cron". As cron is not part of a minimal installation, this explicit rpm requires is useful to make sure that your package works as designed.
imho logrotate should require cron. but packages which provide logrotate configs should only recommend logrotate. your package might provide a sample logrotate file but in the end doesnt use it. (apache + cronolog as an example) darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Tue, 5 Feb 2008, Marcus Rueckert wrote:
On 2008-02-05 19:00:28 +0100, Dirk Mueller wrote:
I've implemented the suggestion in bnc#357040, which checks if a package, that installs a file in /etc/cron.*/ or /etc/logrotate.d/, also rpm-requires "cron". As cron is not part of a minimal installation, this explicit rpm requires is useful to make sure that your package works as designed.
imho logrotate should require cron. but packages which provide logrotate configs should only recommend logrotate. your package might provide a sample logrotate file but in the end doesnt use it. (apache + cronolog as an example)
Right, I would argue a Suggests is enough in both cases. No need to bloat the minimal installed system, right? ;) Richard. -- Richard Guenther <rguenther@suse.de> Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wednesday 06 February 2008, Richard Guenther wrote:
imho logrotate should require cron. but packages which provide logrotate configs should only recommend logrotate.
Good point, I agree with that. I'll try to make the check that way (which depends on a rpm bug so far being resolved first)
Right, I would argue a Suggests is enough in both cases.
Not in all cases. there are several packages that do not work correctly without cron. Greetings, Dirk -- RPMLINT information under http://en.opensuse.org/Packaging/RpmLint --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 2008-02-06 12:12:26 +0100, Dirk Mueller wrote:
On Wednesday 06 February 2008, Richard Guenther wrote:
imho logrotate should require cron. but packages which provide logrotate configs should only recommend logrotate.
Good point, I agree with that. I'll try to make the check that way (which depends on a rpm bug so far being resolved first)
Right, I would argue a Suggests is enough in both cases.
Not in all cases. there are several packages that do not work correctly without cron.
yeah but only those packages should require. for everything else a weak requirement should be the default. -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Tue, 5 Feb 2008 at 19:00, Dirk Mueller wrote:
I've implemented the suggestion in bnc#357040, which checks if a package, that installs a file in /etc/cron.*/ or /etc/logrotate.d/, also rpm-requires "cron". As cron is not part of a minimal installation, this explicit rpm requires is useful to make sure that your package works as designed.
The fact that an package installs something under /etc/cron.* doesn't necessarily mean the package doesn't work as designed without cron. The cron scripts might add optional functionality that is not needed for the basic operation of the package. cu Reinhard --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Tuesday 05 February 2008, Reinhard Max wrote:
The fact that an package installs something under /etc/cron.* doesn't necessarily mean the package doesn't work as designed without cron.
More verboseness please. Which package installs something under /etc/cron.*/ but works fine without that cronjob being called?
The cron scripts might add optional functionality that is not needed for the basic operation of the package.
Thats why we have Recommends: and Suggests: There is no excuse for leaving out the dependency though. Greetings, Dirk -- RPMLINT information under http://en.opensuse.org/Packaging/RpmLint --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wed, 6 Feb 2008 at 11:47, Dirk Mueller wrote:
On Tuesday 05 February 2008, Reinhard Max wrote:
The fact that an package installs something under /etc/cron.* doesn't necessarily mean the package doesn't work as designed without cron.
More verboseness please. Which package installs something under /etc/cron.*/ but works fine without that cronjob being called?
One example would be findutils-locate, which includes a daily cron job for running updatedb, but would work fine without that if the sysadmin prefers to run updatedb manually every once in a while, because he knowes that the system doesn't change much. In fact, when I look into /etc/cron.* on my system, I think most of the packages installing stuff there fall into this category. Their main functionality doesn't require cron and the cron scripts are only there to automate house keeping tasks that could as well be done manually, if so desired by the sysadmin. The only package I can currently think of, which might require cron for proper operation is mgetty+sendfax for sending out spooled fax jobs, and even for that a standalone daemon exists, so that cron isn't strictly needed. So, which packages do you have in mind, who absolutely can't live without cron? cu Reinhard --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wednesday 06 February 2008, Reinhard Max wrote:
One example would be findutils-locate, which includes a daily cron job for running updatedb, but would work fine without that if the sysadmin prefers to run updatedb manually every once in a while, because he knowes that the system doesn't change much.
a suggests or recommends is probably still correct here though.
So, which packages do you have in mind, who absolutely can't live without cron?
the following cron jobs could be wanted to be run if they're installed: logrotate logdigest leafnode storebackup suse_clean_catman suse.de-backup* suse-de-check-battery suse.de-cron-local suse.de-cyrus-imapd Greetings, Dirk -- RPMLINT information under http://en.opensuse.org/Packaging/RpmLint --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Dirk Mueller escribió:
On Tuesday 05 February 2008, Reinhard Max wrote:
Thats why we have Recommends: and Suggests: There is no excuse for leaving out the dependency though.
Last time I checked "Suggests" did absolutely nothing (a "suggested" package is never installed) has this changed recently ? -- “There is always some madness in love. But there is also always some reason in madness.” - Friedrich Nietzsche Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wednesday 06 February 2008, Cristian Rodríguez wrote:
Last time I checked "Suggests" did absolutely nothing (a "suggested" package is never installed) has this changed recently ?
No it hasn't. There is a still a small chance that this gets fixed in YaST somewhen though, as it was not designed to do nothing ;) Greetings, Dirk -- RPMLINT information under http://en.opensuse.org/Packaging/RpmLint --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Dirk Mueller escribió:
No it hasn't. There is a still a small chance that this gets fixed in YaST somewhen though, as it was not designed to do nothing ;)
I think "suggests" should just cause zypper to emit an informative message like "The following packages are suggested but are not going to be installed foo bar joe doe" by default Suggested packages should not be installed unless a --install-suggests flag or a configuration option is set to true. just my 2CLP. -- "Morality is merely an interpretation of certain phenomena — more precisely, a misinterpretation." - Friedrich Nietzsche Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (5)
-
Cristian Rodríguez -
Dirk Mueller -
Marcus Rueckert -
Reinhard Max -
Richard Guenther