spec sources with spaces in filename (rpm 4.18)
Hi, In a package, I have a source file with spaces in it: Source: Mobile Atlas Creator %{version}.zip ... %prep %setup -q -c -n mobac This used to work fine, and resulted in: [ 76s] + cd /home/abuild/rpmbuild/BUILD [ 76s] + rm -rf mobac [ 76s] + /usr/bin/mkdir -p mobac [ 76s] + cd mobac [ 76s] + /usr/bin/unzip -qq '/home/abuild/rpmbuild/SOURCES/Mobile Atlas Creator 2.3.0.zip' [ 77s] + STATUS=0 But since rpm 4.18, a new tool rpmuncompress is used. This now gives: [ 38s] + cd /home/abuild/rpmbuild/BUILD [ 38s] + rm -rf mobac [ 38s] + /usr/bin/mkdir -p mobac [ 38s] + cd mobac [ 38s] + /usr/lib/rpm/rpmuncompress -x /home/abuild/rpmbuild/SOURCES/Mobile Atlas Creator 2.3.0.zip [ 38s] error: File /home/abuild/rpmbuild/SOURCES/Mobile: No such file or directory [ 38s] error: Bad exit status from /var/tmp/rpm-tmp.SgyFCX (%prep) Is this just a plain bug in rpm? Is there some recommended way to deal with spaces in filenames? TIA for advice, Manfred
Am 31.12.22 um 01:27 schrieb Manfred Schwarb:
Hi,
In a package, I have a source file with spaces in it:
Source: Mobile Atlas Creator %{version}.zip ... %prep %setup -q -c -n mobac
This used to work fine, and resulted in: [ 76s] + cd /home/abuild/rpmbuild/BUILD [ 76s] + rm -rf mobac [ 76s] + /usr/bin/mkdir -p mobac [ 76s] + cd mobac [ 76s] + /usr/bin/unzip -qq '/home/abuild/rpmbuild/SOURCES/Mobile Atlas Creator 2.3.0.zip' [ 77s] + STATUS=0
But since rpm 4.18, a new tool rpmuncompress is used. This now gives: [ 38s] + cd /home/abuild/rpmbuild/BUILD [ 38s] + rm -rf mobac [ 38s] + /usr/bin/mkdir -p mobac [ 38s] + cd mobac [ 38s] + /usr/lib/rpm/rpmuncompress -x /home/abuild/rpmbuild/SOURCES/Mobile Atlas Creator 2.3.0.zip [ 38s] error: File /home/abuild/rpmbuild/SOURCES/Mobile: No such file or directory [ 38s] error: Bad exit status from /var/tmp/rpm-tmp.SgyFCX (%prep)
Is this just a plain bug in rpm? Is there some recommended way to deal with spaces in filenames?
This is fixed now upstream, see https://github.com/rpm-software-management/rpm/issues/2335 . Probably wants to be backported?
TIA for advice, Manfred
On 12/31/22 01:27, Manfred Schwarb wrote> Is this just a plain bug in rpm? Is there some recommended way to deal
with spaces in filenames?
Looks like a bug. Best is to create a bug report about it. Until it's fixed in TW, you may need to workaround it by renaming the archive. - Adam
Am 25.01.23 um 14:40 schrieb Adam Majer:
On 12/31/22 01:27, Manfred Schwarb wrote> Is this just a plain bug in rpm? Is there some recommended way to deal
with spaces in filenames?
Looks like a bug. Best is to create a bug report about it. Until it's fixed in TW, you may need to workaround it by renaming the archive.
It is fixed, see https://github.com/rpm-software-management/rpm/issues/2335 The question is whether it is worth backporting (i.e. are there other people with the same issue?), or waiting for version 4.18.1 is OK. I use mainly Leap, so it is not urgent for me. There is also the %{?_smp_mflags} issue (https://github.com/rpm-software-management/rpm/issues/2343) which could be worth backporting.
On Wednesday 2023-01-25 14:59, Manfred Schwarb wrote:
with spaces in filenames?
Looks like a bug. Best is to create a bug report about it. Until it's fixed in TW, you may need to workaround it by renaming the archive.
It is fixed, see https://github.com/rpm-software-management/rpm/issues/2335
The question is whether it is worth backporting (i.e. are there other people with the same issue?),
Probably not worth doing anything about. Even if rpm manages spaces, some build scripts may not, because (improperly escaped) space is a token separator, and it is probably fair to say most people do not care enough and just opt to use an underscore instead. If you ever had a friend who wrote $* or $@ in shell instead of "$@", that's the kind of guy :D
participants (3)
-
Adam Majer -
Jan Engelhardt -
Manfred Schwarb