[opensuse-packaging] %{reconfigure_fonts_scriptlets}
Hi, That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore. Thoughts? darix [1] https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25desktop... -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wed, 2015-06-10 at 16:13 +0200, Marcus Rueckert wrote:
Hi,
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
Thoughts?
I agree it should be split - there will be a bunch of packages failing,
that use it now with the assumption of it creating all the post/postun
sections, but we better bite this bullet.
--
Dimstar / Dominique Leuenberger
On Wednesday 2015-06-10 16:20, Dimstar / Dominique Leuenberger wrote:
On Wed, 2015-06-10 at 16:13 +0200, Marcus Rueckert wrote:
Hi,
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
Thoughts?
I agree it should be split - there will be a bunch of packages failing, that use it now with the assumption of it creating all the post/postun sections, but we better bite this bullet.
But for simple font packages, you want to continue providing a single macro that expands to all four sections. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
At Wed, 10 Jun 2015 16:23:13 +0200 (CEST), Jan Engelhardt wrote:
On Wednesday 2015-06-10 16:20, Dimstar / Dominique Leuenberger wrote:
On Wed, 2015-06-10 at 16:13 +0200, Marcus Rueckert wrote:
Hi,
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
Thoughts?
I agree it should be split - there will be a bunch of packages failing, that use it now with the assumption of it creating all the post/postun sections, but we better bite this bullet.
But for simple font packages, you want to continue providing a single macro that expands to all four sections.
Right. For standard font packages, there shouldn't need any other things. Of course, providing individual macros *in addition* wouldn't harm, though. Takashi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Wed, Jun 10, Marcus Rueckert wrote:
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
If rpm-macros.fonts-config is touched anway: Does anyone know if %__fontsupdatescript and %__fontsupdatescript_cjk is a public interface? Right now the implementation causes build-compare to republish packages using %reconfigure_fonts_post. If the two variables above are really meant to be local to %reconfigure_fonts_post then I will rearrange the code to make build-compare happy. Olaf -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
At Thu, 11 Jun 2015 08:23:30 +0200, Olaf Hering wrote:
On Wed, Jun 10, Marcus Rueckert wrote:
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
If rpm-macros.fonts-config is touched anway:
Does anyone know if %__fontsupdatescript and %__fontsupdatescript_cjk is a public interface?
They are supposed to be internal. But Petr must know at best.
Right now the implementation causes build-compare to republish packages using %reconfigure_fonts_post. If the two variables above are really meant to be local to %reconfigure_fonts_post then I will rearrange the code to make build-compare happy.
We'd happily take any optimizations! Takashi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
On Thu, Jun 11, 2015 at 12:13:43PM +0200, Takashi Iwai wrote:
At Thu, 11 Jun 2015 08:23:30 +0200,
Does anyone know if %__fontsupdatescript and %__fontsupdatescript_cjk is a public interface?
It is?
They are supposed to be internal. But Petr must know at best.
Exactly.
Right now the implementation causes build-compare to republish packages using %reconfigure_fonts_post. If the two variables above are really meant to be local to %reconfigure_fonts_post then I will rearrange the code to make build-compare happy.
We'd happily take any optimizations!
Exactly! Thanks, Petr
On Wed, Jun 10, 2015 at 04:13:46PM +0200, Marcus Rueckert wrote:
Hi,
That macro is less than ideal. I think it should be split up in macros per section like e.g. the desktop db macros [1]. If that macro is used you cant not call other per section macros anymore.
Sorry my ignorance, what you are missing from the set of macros already defined in rpm-macros.fonts-config? %reconfigure_fonts_post %reconfigure_fonts_postun %reconfigure_fonts_posttrans %reconfigure_fonts_scriptlets Petr
participants (6)
-
Dimstar / Dominique Leuenberger -
Jan Engelhardt -
Marcus Rueckert -
Olaf Hering -
Petr Gajdos -
Takashi Iwai