[opensuse-packaging] Rpmlint warning for hicolor-icon-theme is it valid and how do I get rid of it?
Hi, I'm the maintainer of the OpenLP package and it has a depency on hicolor-icon-theme. I'm trying to clean up all the rpmlint warnings and I can't figure out how to get rid of this one. OpenLP.noarch: W: suse-branding-unversioned-requires hicolor-icon-theme Please make sure that your requires entry reads like 'Requires: %name-branding = <versionnumber>'. Is this a bogus warning? In which case I'll filter it out in rpmlintrc, or is it valid and I need to depend on something else? I've search Google, the mailing lists and the forum and I haven't been able to find an answer. I think the warning may be triggered by the following code in BrandingPolicyCheck.py in the rpmlint package https://build.opensuse.org/package/view_file?file=BrandingPolicyCheck.py&package=rpmlint&project=openSUSE%3A12.2 BrandingPolicyCheck.py Lines 37-40 if r[0].endswith('branding') or r[0].endswith('theme'): # XXX: that startswith 1 breaks with openSUSE 20... if (r[1] != rpm.RPMSENSE_EQUAL or not r[2][1].startswith('1')): printError(pkg,'suse-branding-unversioned-requires', r[0]) Joseph Mulloy jdmulloy@gmail.com -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
Hi, Le jeudi 23 août 2012, à 00:19 -0400, Joseph Mulloy a écrit :
Hi,
I'm the maintainer of the OpenLP package and it has a depency on hicolor-icon-theme. I'm trying to clean up all the rpmlint warnings and I can't figure out how to get rid of this one.
OpenLP.noarch: W: suse-branding-unversioned-requires hicolor-icon-theme Please make sure that your requires entry reads like 'Requires: %name-branding = <versionnumber>'.
Is this a bogus warning? In which case I'll filter it out in rpmlintrc, or is it valid and I need to depend on something else? I've search Google, the mailing lists and the forum and I haven't been able to find an answer.
I think the warning may be triggered by the following code in BrandingPolicyCheck.py in the rpmlint package https://build.opensuse.org/package/view_file?file=BrandingPolicyCheck.py&package=rpmlint&project=openSUSE%3A12.2
BrandingPolicyCheck.py Lines 37-40 if r[0].endswith('branding') or r[0].endswith('theme'): # XXX: that startswith 1 breaks with openSUSE 20... if (r[1] != rpm.RPMSENSE_EQUAL or not r[2][1].startswith('1')): printError(pkg,'suse-branding-unversioned-requires', r[0])
It's really a bug in the check. Icon themes are not branding packages. Can you file a bug about this? Thanks, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
participants (2)
-
Joseph Mulloy -
Vincent Untz