On Wed, 6 May 2020, Martin Liška wrote:

On 5/6/20 8:45 AM, Richard Biener wrote:

...

I think it should check $(MAKE) actually points to an executable ... (or simply somehow try and then fall back to 'make'). It could be MAKE = echo as well if the project is not using make after all.

Hi.

Note that the code is there for 10 years :) I wouldn't check if $(MAKE) is executable, but checking of an option in the env variable seems to me reasonable.

What about:

$ MAKE="make -s" gcc main.o -flto=16 lto-wrapper: fatal error: an option found in ‘MAKE’ environment variable: ‘make -s’, use ‘MAKEFLAGS’ instead compilation terminated. /usr/bin/ld: error: lto-wrapper failed collect2: error: ld returned 1 exit status

?

Well ... if we do not find a jobserver then we clear MAKEFLAGS, so that seems like a bad suggestion? So in that light Michas suggestion seems to be better (hopefully there's some utility for proper splitting in libiberty, buildargv looks close). Richard.

Martin

-- Richard Biener SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)