Paul Elliott wrote:
Autoreqprov: on AFAIK it is Automatically on in new distros.
%{?suse_update_libdir:%{suse_update_libdir}} %{?suse_update_config:%{suse_update_config -f}}
I personally prefer autoreconf -f -i in %build phase instead, if is is doable. It prevents bad detection of uncommon platforms or new systems not supported in authors automake.
CFLAGS="$RPM_OPT_FLAGS" CXXFLAGS="$RPM_OPT_FLAGS" \ PKG_CONFIG_PATH=%{_prefix}/%{_lib}/pkgconfig:%{_prefix}/share/pkgconfig \ %configure --prefix=%{_prefix}
This PKG_CONFIG_PATH stuff will probably break multi-prefix systems (SuSE <= 10.2). For other systems, it is only obsolete. %configure already includes setting of CFLAGS, CXXFLAGS, prefix, libdir and other dirs except libexecdir, which is set incorrectly by RPM.
CCFLAGS=$RPM_OPT_FLAGS \ PKG_CONFIG_PATH=%{_prefix}/%{_lib}/pkgconfig:%{_prefix}/share/pkgconfig \ make %{?_smp_mflags}
If sources are not broken, both CFLAGS and PKG_CONFIG_PATH are obsolete here.
rm -rf $RPM_BUILD_ROOT
At least in SuSE, don't use it, see other mails. For other distros, check its documentation.
make DESTDIR=$RPM_BUILD_ROOT install-strip
install-strip effectively kills %debug_package. Use plain install, if you want to provide debug information. In suse %makeinstall does the work well (not in other distros, where it still not uses DESTDIR). -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz Lihovarská 1060/12 tel: +420 284 028 966 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org