On Fri, Apr 29, 2011 at 07:50, Jan Matejek <jan.matejek@novell.com> wrote:
* You don't need to have %post and %postun scripts. You only need them for systemwide libraries. Python modules have no use for this step.
Got it.
(Also, %clean section is mostly useless with modern rpm. You can just leave it out. It's not wrong to have it, though)
Good to know.
* I suggested %exclude for files that are moved into a different subpackage ( = listed in another filelist), not removed entirely. I thought that it is what you want to do with the explicit filelist. It's OK to use it this way, but it is slightly confusing. Just removing them in the %install section is probably better.
In python-Traits those are c generated code that are not used in the final package. I do not believe that a -devel package is necessary here, but let me know what you think.
* why are you using "fdupes -s" somewhere and just "fdupes" in other places?
Dumb copy-and-paste mistake from my part.
Other than that, the specs look fine to me. Please send a submitrequest.
regards m.
Thanks for the helpful analysis. I'm slowly learning the packaging guidelines and improving my skills. These packages were the first ones that I felt confident enough to "submit" to official repos. BTW: Am I submitting them to the right place? devel:languages:python? Regards, Filipe. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org