Dne 26.4.2011 23:57, Filipe Pires Alvarenga Fernandes napsal(a):
Do you mind criticizing the spec file for these 4 python-Traits* packages?
https://build.opensuse.org/project/show?project=home%3Aocefpaf%3AETS
* You don't need to have %post and %postun scripts. You only need them for systemwide libraries. Python modules have no use for this step. (Also, %clean section is mostly useless with modern rpm. You can just leave it out. It's not wrong to have it, though) * I suggested %exclude for files that are moved into a different subpackage ( = listed in another filelist), not removed entirely. I thought that it is what you want to do with the explicit filelist. It's OK to use it this way, but it is slightly confusing. Just removing them in the %install section is probably better. * why are you using "fdupes -s" somewhere and just "fdupes" in other places? Other than that, the specs look fine to me. Please send a submitrequest. regards m.
Thanks for the attention, Filipe.
ps: I do think these packages are valid for more users.
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org