On Thursday 24 March 2016, Ruediger Oertel wrote:
Am 23.03.2016 um 21:57 schrieb Ruediger Meier:
On Wednesday 23 March 2016, Michal Kubecek wrote:
On Wed, Mar 23, 2016 at 09:19:43PM +0100, Ruediger Meier wrote:
even I've realized that "uname -r" is broken on any openSUSE build repo.
It's because the post-build-checks package symlinks an uname.sh script which does not report the running kernel version anymore but a version string from arbitrary text files or installed kernel sources.
What is the reason why we have this dirty hack?
IMHO the reason is that while regular OBS builds use a full virtual machine for build now, it wasn't always so and even now, local builds use only a chroot.
actually these hacks go back a very long way and the main "ab-"users of this were the proprietary graphics drivers. From that view, I'm perfectly fine with finally getting rid of this ugly hack.
The result would then depend on kernel version of the build host. For example, the system I'm doing most of my local osc builds on would report 3.12 kernel while the actual target systems range from 2.6.16 to 4.5.0.
Yes and this is correct and wanted behavior.
For example a test-suite might skip (or include) certain tests depending on the _running_ kernel. The kernel version can be used to guess about kernel _runtime_ bugs or features.
well, here I'm not so sure. What matters is absolutely not the running kernel, because even in current build environments where the running kernel for the VM often matches the kernel the distribution will be running on, there is no guarantee at all that it actually matches.
I don't think so. A test-script may only work if a particular syscall is available. This syscall exists for all kernels, say >3.14. If the running kernel has the wanted version then ok ... run the test. If not ... then it has to skip the test because it would fail. In this case we may miss that test run for the final distro kernel. But there is no way to test it without having the distro kernel or any other kernel > 3.14 running.
[...] But all this is more the conceptual side. The uname hack is just that: an old hack that was needed at the time when it was written (many years ago), but we should have gotten rid of it for quite a while already.
This would be nice. BTW I've made some more tests and have to admit that uname.sh usually does _not_ report wrong versions because there is no such file /.kernelversion neither in chroot nor on OBS build hosts. So it should be 100% safe to remove the hack (at least for all packages which do not require kernel-source). cu, Rudi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org