On Thu, 21 Mar 2013 12:47, Sascha Peilicke <speilicke@...> wrote:
On 03/21/2013 12:09 PM, Adam Spiers wrote:
[setting Cc and Reply-To to the opensuse-buildservice list] Sascha Peilicke (speilicke@suse.com) wrote:
On 03/21/2013 09:50 AM, Togan Muftuoglu wrote:
On 03/21/2013 09:10 AM, Sascha Peilicke wrote: [snip] Since I am not currently a regular reviewer, feel free to tell me if I'm talking rubbish, but it seems to me that there are some low-hanging fruit changes we could make here to make life much easier for reviewers, e.g.:
- Change the Rpmlint Results tab to group warnings/errors by filter type, and just show the number of occurrences in each group. Then you can mouseover or click to see more details.
Could work, but in general I tried to reduce the number of clicks as much as possible since review time matters. Currently, it's one click to reach the rpmlint tab and maybe another to pick the distro you're interested in.
How about: auto-collapse only for the non-failure sections. Pro: - Fast overview, - less scrolling to the failure-details, - no added click for failure-search Con: - added work during implementation.
@Henne: Maybe the distinction between distros can be released a bit, usually openSUSE:* are all the same to openSUSE:Factory. Only SLE_11_* rpmlint warnings differ, but they're maybe that outdated that we don't want to show them. Long story short, only showing Factory rpmlint issues should be enough for every request (even those not targeted at openSUSE:Factory).
However, having collapsed boxes means more clicks and wouldn't like that there.
- Add a way to view an rpmlint results summary via osc (is there an API call for this, or do you just have to grep the build log client-side?)
- Automatically color the build log according to patterns.
Very useful and easily done via CodeMirror2.
- Automatically split the build log into the different phases, e.g.
- booting the VM - init_buildsystem etc. - %prep - %build - %install - /usr/lib/rpm/brp-* hooks - autoreqprov calculation - %clean - post-build checks (01-check-debuginfo ... 99-check-remove-rpms) - rpmlint - post-build tasks (e.g. "creating baselibs", "comparing built packages with former built") - VM power down
and make each section expandable in the webUI with all sections starting collapsed and colour-coded red/green according to whether the section's contents matched any known failure patterns. (Actually I already have some code which might help implement this last idea.)
I like the idea and that may reduce the scrolling needed. Collapsing sections here is that you usually search for something specific.
See above: auto-collapse only for 'green' / error free sections. And, yes, re-use the same code as from above would definitely reduce the work for future maintenance. Thank you for taking this further. - Yamaban. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org