Am 20. März 2013 20:22:53 schrieb Togan Muftuoglu <toganm@opensuse.org>:
Hi,
Should there be a general review policy for the obs users who have the maintainer rights for package/group. I guess there is one for the opensuse-review team maybe we should have it also for those who are accepting packages to the devel projects as well.
In ms opinion it can't hurt if develprojects apply Factory review rules to some degree too. Since some reviewers are packagers too that aleeady happens, although it should be more forgiving than for Factory.
The reason is I had a declination with a comment why I have not explained use of %ghost macro in a spec file, but a person who would have reviewed the rpm buildlogs for the package would realize the fact that rpmlint gives the following error.
Who seriously looks at buildlogs when reviewing requests?
non-ghost-in-var-run (Badness: 1000)
And the mentioning %ghost in changes file in IMHO is nonsense as the issue has nothing to the with the package but packaging itself and from the end users point of is just cosmetic.
Depends on the exact case. In general, I'd say put it into the changes file and let the user decide. Also, reviewers look there for reasons why changes happen. Trying to read packagers minds is usually consuming too much time, so such requests may easily get a Factory decline. We have ~50-200 requests per day fighting for attention. Those with concise changes and clear documentation win. And I refuse to spend much time on the others :-)
So maybe it is a good idea to have a document describing what is required/recommended in the #sr review
I would prefer that we improve the Factory review documentation and use that as a recommendation. Less doubled work.
Togan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org