On Sun, Apr 7, 2013 at 7:03 AM, Lars Vogdt <lrupp@suse.de> wrote:
My feeling is now that I am not a good reviewer as I accept too many packages. My hope is/was that packagers read my comments even if their package gets accepted for Factory. If this assumption is wrong, we should discuss what I can do instead.
Currently I do not like the idea to reject packages because of guideline violations, but if my notes are not read if I accept a package, than I should adapt to a better strategy. Suggestions welcome!
It may not be at all bad to reject, if it's a guideline and it is clear that compliance is optional, the one that submitted can decide to reopen with a comment on why we would not comply. Either a compelling reason not to comply, or maybe something along the lines of "it would be too much work and it's better to push this fix sooner rather than later" would still be very informative. It's a pity OBS doesn't let you add a comment without either accepting or rejecting. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org