On 10/29/2013 02:25 AM, Cristian Rodríguez wrote:
El 28/10/13 17:12, Lee Duncan escribió:
This is not a lock directory but rather the home of the open-iscsi run-time implementation. This directory has the open-iscsi configuration file, interface definitions and configurations, as well as holding the NODE and target persistence database. The term LOCK_DIR is perhaps unfortunate but is historic.
It is wrong anyway.. runtime status should not be there.. i looked at the source code..
#define LOCK_FILE LOCK_DIR"/lock" #define LOCK_WRITE_FILE LOCK_DIR"/lock.write"
I did not say there were not any lock files there. Open-iscsi mixes lock files, config files, and database files in a directory tree. As I said, it is historical, as are many of the systems that still use lock files in /etc.
You should not create any runtime status in /etc.. specially not locks that should be placed in a directory that is guaranteed to be clean at startup.
By "you" I will assume you mean the open-iscsi package maintainers. And they do not require the directory to be clean, at start up.
Kay has made it clear that it is the job of systemd and not udev to handle these device events,
which is much of the motiavation for this
open-iscsi makeover. There is no need for this extra udev clutter if either (1) the systemd unit files are configure correctly, or (2) the iscsi daemon is just configured to run all the time, as it is now.
But the "systemd way" to handle this is via socket-based on-demand starting of the iscsi daemon.
You are misunderstading my suggestion.. I never told you that udev should do that or that it will do so with my suggestion.. it simply means that udev will tell systemd that the iscsi service ought to be included in the transaction because it is wanted.
Perhaps you misunderstand my reply. I am asking why is it neccessary to have udev tell systemd anything? The daemon has to be running for the device to show up, so by the time udev gets called there is no need to tell iscsid anything.
-- Lee Duncan SUSE Labs -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org