![](https://seccdn.libravatar.org/avatar/576633d48951f8e887a5df4f8707451a.jpg?s=120&d=mm&r=g)
On 14 May 2012 16:07, Joop Boonen <joop.boonen@boonen.org> wrote:
Hi all,
I have been using spec cleaner for while. What I notice it that it uses macro %make_install instead of %makeinstall. Both macros are OK for openSUSE but the first one breaks the build for SLE.
<quote> + %make_install /var/tmp/rpm-tmp.59594: line 45: fg: no job control </quote>
I wonder if this should be fixed, in either spec-cleaner (use%makeinstall in stead of %make_install) or in the buildserver (add macro %make_install for SLE)?
The problem is rpm's %makeinstall is broken (http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_ma...). openSUSE overrides the original rpm definition with one equivalent to %make_install, but that has not always been the case and other distros don't do it. %make_install is the correct one, defined in upstream rpm since version 4.8.0. Personally I favour cross-distro compatibility to compatibility with old distros. IMHO if someone wants to support old distros he should do the work without interfering with the latests development (e.g. http://pmbs.links2linux.org/package/rdiff?opackage=rpm&oproject=openSUSE.org...) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org