Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ce30ce04e0f584076135e5453e28e421e2040d3d https://github.com/openSUSE/open-build-service/commit/ce30ce04e0f584076135e5... Author: Shayon Mukherjee <opensuse@shayon.me> Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/app/models/comment_request.rb M src/api/config/routes.rb M src/api/db/structure.sql M src/api/test/fixtures/comments.yml M src/api/test/functional/comments_controller_test.rb M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/project_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/models/api_details.rb A src/webui/app/views/application/_update_comments.html.erb A src/webui/app/views/shared/_comment_links.html.erb M src/webui/app/views/shared/_parent_comments.erb M src/webui/config/routes.rb Log Message: ----------- [webui][api] added edit/delete functionality with permission checks Commit: b6d28dccedf775e042174a1c3972bb1208e27ac5 https://github.com/openSUSE/open-build-service/commit/b6d28dccedf775e042174a... Author: Shayon Mukherjee <opensuse@shayon.me> Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/app/models/comment_request.rb M src/api/config/routes.rb M src/api/test/functional/comments_controller_test.rb M src/webui/app/assets/stylesheets/comments.scss M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/project_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/models/api_details.rb A src/webui/app/views/application/_edit_comments.html.erb R src/webui/app/views/application/_update_comments.html.erb M src/webui/app/views/shared/_child_comment.html.erb M src/webui/app/views/shared/_comment_links.html.erb R src/webui/app/views/shared/_comment_reply_link.html.erb M src/webui/app/views/shared/_parent_comments.erb M src/webui/config/routes.rb Log Message: ----------- [webui][api] edit and delete both route through different methods now. Commit: f0b4f01bfc4e392461c82e5daecb2054db83a465 https://github.com/openSUSE/open-build-service/commit/f0b4f01bfc4e392461c82e... Author: Shayon Mukherjee <opensuse@shayon.me> Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/app/models/comment_request.rb M src/api/config/routes.rb M src/api/test/functional/comments_controller_test.rb M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/project_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/models/api_details.rb M src/webui/app/views/package/comments.html.erb M src/webui/app/views/request/comments.html.erb Log Message: ----------- [webui][api] refactored permission check. Added condition for required params. Handingly unknown request ids for comment Commit: 2ded339a3d94eec71703195fca0d2d430e40256e https://github.com/openSUSE/open-build-service/commit/2ded339a3d94eec7170319... Author: Shayon Mukherjee <opensuse@shayon.me> Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/test/functional/comments_controller_test.rb M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/views/shared/_comment_links.html.erb M src/webui/app/views/shared/_new_comment.html.erb M src/webui/test/functional/request_controller_test.rb Log Message: ----------- [webui][api] moved field checks to controller, updated test functions and some more refactoring. Commit: 63e5807c06c43522e1280ea0b6d32f4e56f8a8c0 https://github.com/openSUSE/open-build-service/commit/63e5807c06c43522e1280e... Author: Shayon Mukherjee <opensuse@shayon.me> Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/views/shared/_new_comment.html.erb Log Message: ----------- [webui][api] added required_fields to check for empty params/content and fixed other tid-bit bugs Compare: https://github.com/openSUSE/open-build-service/compare/c1f6110c2bbb...63e580...