[obs-commits] [openSUSE/open-build-service] 692bc3: Revert "[ci] Enable Capybara.wait_on_first_by_defa...

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 692bc31dae520eec968d15d1d6458497383779f9 https://github.com/openSUSE/open-build-service/commit/692bc31dae520eec968d15... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-06-07 (Tue, 07 Jun 2016) Changed paths: M src/api/test/functional/webui/maintenance_workflow_test.rb M src/api/test/test_helper.rb Log Message: ----------- Revert "[ci] Enable Capybara.wait_on_first_by_default" This reverts commit d62d131fcd1b36ffcc6b2ce8755d8f938dbf8a8a. This was meant to fix test failures introduced by updating phantomjs to v2.1. But apparently this broke some other tests when run during package built. Besides it was a crude workaround anyway. Commit: 69a7fbecad22ef8418a3c248ad9dea8f2013381a https://github.com/openSUSE/open-build-service/commit/69a7fbecad22ef8418a3c2... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-06-07 (Tue, 07 Jun 2016) Changed paths: M src/api/test/functional/webui/maintenance_workflow_test.rb Log Message: ----------- [ci] Fix test that fails with updated phantomjs (v1.9 -> v2.1) Capybara's find is waiting for an element to appear while first and all expect an element to be there right away. Apparently this started to cause a problem here when updating phantomjs. Using find with a proper locator fixes the failing test. Commit: 0b78eae61cfdb22218f8d6112bdf16fd3f1409f9 https://github.com/openSUSE/open-build-service/commit/0b78eae61cfdb22218f8d6... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-06-08 (Wed, 08 Jun 2016) Changed paths: M src/api/test/functional/webui/package_controller_test.rb Log Message: ----------- [ci] Update tests for package controller The old code / capybara selectors were fragile and could easily break due to timeouts. This sometimes caused test failures with phantomjs 2.1. Commit: 14b0da541edb3b4e24e7b9a7d1c18e89c0a2ddc3 https://github.com/openSUSE/open-build-service/commit/14b0da541edb3b4e24e7b9... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-06-08 (Wed, 08 Jun 2016) Changed paths: M src/api/test/functional/webui/user_controller_test.rb Log Message: ----------- [ci] Fix fragile test_creation_of_home_projects test This test required the backend to be fully up and running to avoid inconsistency which would crash the backend. This could have been done by via wait_for_scheduler_start method, but using a user without a home project is the better approach. Thanks Adrian for the hint! ======= test_creation_of_home_projects PASS (27.13s) /vagrant/src/api/lib/opensuse/backend.rb:182:in `handle_response': <status code="404"> (ActiveXML::Transport::NotFoundError) <summary>project 'home:Iggy' has no repository '10.2'</summary> <details>404 project 'home:Iggy' has no repository '10.2'</details> </status> from /vagrant/src/api/lib/opensuse/backend.rb:96:in `put_or_post' from /vagrant/src/api/lib/opensuse/backend.rb:100:in `put' from /vagrant/src/api/script/start_test_backend:360:in `block in <main>' /vagrant/src/api/lib/opensuse/backend.rb:182:in `handle_response': <status code="404"> (ActiveXML::Transport::NotFoundError) <summary>project 'home:Iggy' has no repository '10.2'</summary> <details>404 project 'home:Iggy' has no repository '10.2'</details> </status> from /vagrant/src/api/lib/opensuse/backend.rb:96:in `put_or_post' from /vagrant/src/api/lib/opensuse/backend.rb:100:in `put' from /vagrant/src/api/script/start_test_backend:360:in `block in <main>' Commit: 3613a68de1dce9e6640e5e6f21c47f5c07a244f6 https://github.com/openSUSE/open-build-service/commit/3613a68de1dce9e6640e5e... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-06-08 (Wed, 08 Jun 2016) Changed paths: M src/api/test/functional/webui/download_on_demand_controller_test.rb Log Message: ----------- [ci] Fix test suite failures during OBS rpm build (Webui::DownloadOnDemandControllerTest) ==== [ 1352s] Webui::DownloadOnDemandControllerTest [ 1352s] test_adding_download_on_demand ERROR (8.39s) [ 1352s] Capybara::ElementNotFound: Capybara::ElementNotFound: Unable to find xpath "//a[@href='/project/repository_state/home:user5/My%20DoD%20repository']" [ 1352s] capybara (2.5.0) lib/capybara/node/finders.rb:43:in `block in find' [ 1352s] capybara (2.5.0) lib/capybara/node/base.rb:84:in `synchronize' [ 1352s] capybara (2.5.0) lib/capybara/node/finders.rb:32:in `find' [ 1352s] capybara (2.5.0) lib/capybara/session.rb:698:in `block (2 levels) in <class:Session>' [ 1352s] capybara (2.5.0) lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>' [ 1352s] test/functional/webui/download_on_demand_controller_test.rb:70:in `block in test_adding_download_on_demand' Commit: 73dcd6f586c300bbbcc90e090e9106de57a669ee https://github.com/openSUSE/open-build-service/commit/73dcd6f586c300bbbcc90e... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2016-06-08 (Wed, 08 Jun 2016) Changed paths: M src/api/test/functional/webui/download_on_demand_controller_test.rb M src/api/test/functional/webui/maintenance_workflow_test.rb M src/api/test/functional/webui/package_controller_test.rb M src/api/test/functional/webui/user_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #1863 from bgeuken/debug_test_failures [ci] Fix test that fails with updated phantomjs (v1.9 -> v2.1) Compare: https://github.com/openSUSE/open-build-service/compare/ef268199e5da...73dcd6...
participants (1)
-
Henne Vogelsang