Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ce02086c28b5fd0769cf6dca371da96feb8e8742 https://github.com/openSUSE/open-build-service/commit/ce02086c28b5fd0769cf6d... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Rename conn variable In every method name that deals with the LDAP connection this is abbreviated with one `n` not two. Commit: d9d8979512802ca0dffb54891e3afc85197280d9 https://github.com/openSUSE/open-build-service/commit/d9d8979512802ca0dffb54... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Tag UserLdapStrategy logging To make it easier to understand where this comes from. Also slightly changes the messages to be more consistent. Commit: b279cee524487515d6d1908a04e42b3f3f652827 https://github.com/openSUSE/open-build-service/commit/b279cee524487515d6d190... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Make render_grouplist_ldap private It's only used in the class Commit: 79fb617f4af7c2b36667846a14be62a9e5e84ff7 https://github.com/openSUSE/open-build-service/commit/79fb617f4af7c2b3666784... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- Make authenticate_with_local private It's only used inside the class Commit: c684966f9bd77058107265bc87164935e9d0182a https://github.com/openSUSE/open-build-service/commit/c684966f9bd77058107265... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/spec/models/user_ldap_strategy_spec.rb R src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- Make dn2user_principal_name private It's only used inside the class Commit: d337dba915b7d3bd6f5b5f57d09cb286695bcd62 https://github.com/openSUSE/open-build-service/commit/d337dba915b7d3bd6f5b5f... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/shared/examples/a_ldap_connection.rb Log Message: ----------- Make initialize_ldap_con private It is only used inside the class Commit: 3cba02eaaf8c0b152d2f5406e3fed660cd2712c2 https://github.com/openSUSE/open-build-service/commit/3cba02eaaf8c0b152d2f54... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Make try_ldap_con private It is only used inside the class Commit: ac3aaaa904742567c280d108b5bb6e75ffea7fd0 https://github.com/openSUSE/open-build-service/commit/ac3aaaa904742567c280d1... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Make local_permission_check_with_ldap private It's only used inside the class Commit: e16b682c145ec1fd14357d497af4d6c992342589 https://github.com/openSUSE/open-build-service/commit/e16b682c145ec1fd14357d... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Make local_role_check_with_ldap private It's only used inside the class Commit: 06ef978c8ffc08570b05c727395fe114242e3b7b https://github.com/openSUSE/open-build-service/commit/06ef978c8ffc08570b05c7... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/concerns/has_relationships.rb M src/api/app/models/user_ldap_strategy.rb M src/api/spec/models/user_ldap_strategy_spec.rb Log Message: ----------- Merge search_ldap and find_group_with_ldap No need for an extra method to check for a result... Commit: 6fc4f77430e1f0acbb96f6542455c7395fbbeea4 https://github.com/openSUSE/open-build-service/commit/6fc4f77430e1f0acbb96f6... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/app/models/user.rb M src/api/app/models/user_basic_strategy.rb M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Use lookup_strategy to list groups of a User directly Commit: c28c54f7c43955577bbdb35ec3c0852d462867dc https://github.com/openSUSE/open-build-service/commit/c28c54f7c43955577bbdb3... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Make lookup_strategy a private instance method It is only used inside the class Commit: 20c4c88ab1be3288f41017f2a42ee35bac18fa9b https://github.com/openSUSE/open-build-service/commit/20c4c88ab1be3288f41017... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Merge user_in_group_ldap? and is_in_group? No need for another method just to call user.login... Commit: c41468397ceb9d96a4442495394a5aa35105d1c7 https://github.com/openSUSE/open-build-service/commit/c41468397ceb9d96a44424... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Stop using UserLdapStrategy directly User.is_in_group? is already checking with LDAP if this is the strategy. Commit: 7860d9a1f6f8c2bcb17f6bf1c1088429dbfffbdb https://github.com/openSUSE/open-build-service/commit/7860d9a1f6f8c2bcb17f6b... Author: Henne Vogelsang Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Move find_with_credentials_via_ldap to UserLdapStrategy Commit: 08825fa60529ff223a20f890865168b366c1a186 https://github.com/openSUSE/open-build-service/commit/08825fa60529ff223a20f8... Author: Eduardo J Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/app/models/concerns/has_relationships.rb M src/api/app/models/project.rb M src/api/app/models/user.rb M src/api/app/models/user_basic_strategy.rb M src/api/app/models/user_ldap_strategy.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/shared/examples/a_ldap_connection.rb R src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- Merge pull request #16219 from hennevogel/refactoring/net-ldap Refactoring UserLdapStrategy Compare: https://github.com/openSUSE/open-build-service/compare/bece48180a89...08825f... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications