[openSUSE/open-build-service] 29cc13: Fix inconsistent target project name
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 29cc1342ea019133366cc248404660cfbfe63534 https://github.com/openSUSE/open-build-service/commit/29cc1342ea019133366cc2... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-11-17 (Wed, 17 Nov 2021) Changed paths: M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/configure_repositories.rb M src/api/app/models/workflow/step/link_package_step.rb M src/api/spec/models/workflow/step/configure_repositories_spec.rb A src/api/spec/models/workflow/step_spec.rb Log Message: ----------- Fix inconsistent target project name The Workflow::Step::ConfigureRepositories#target_project_name method was a redefinition of the Workflow::Step#target_project_name. They should be identical except for the YAML key containing the project name. So there is no need to keep both. In fact, this is leading to inconsistencies. For example with the format of the name (using "-" or ":"). Now we only have one definition of the method. The only part we redefine is the project name. For this, we have the `target_project_base_name` method. Commit: dbe5baf98e7ed4bd212c23de101168cf7c62e5df https://github.com/openSUSE/open-build-service/commit/dbe5baf98e7ed4bd212c23... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-11-17 (Wed, 17 Nov 2021) Changed paths: M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/configure_repositories.rb M src/api/app/models/workflow/step/link_package_step.rb M src/api/spec/models/workflow/step/configure_repositories_spec.rb A src/api/spec/models/workflow/step_spec.rb Log Message: ----------- Merge pull request #11868 from saraycp/fix_target_project_name Fix inconsistent target project name Compare: https://github.com/openSUSE/open-build-service/compare/24c4ee90fedd...dbe5ba...
participants (1)
-
Saray Cabrera Padrón