[openSUSE/open-build-service] bcfffb: Refactor controller specs
![](https://seccdn.libravatar.org/avatar/9181eb84f9c35729a3bad740fb7f9d93.jpg?s=120&d=mm&r=g)
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bcfffb4f98f428aa24fce3d7569189ce0308270f https://github.com/openSUSE/open-build-service/commit/bcfffb4f98f428aa24fce3... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M src/api/spec/controllers/group_controller_spec.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/search_controller_spec.rb M src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb M src/api/spec/controllers/status/checks_controller_spec.rb M src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/controllers/status_messages_controller_spec.rb M src/api/spec/controllers/webui/architectures_controller_spec.rb M src/api/spec/controllers/webui/groups/users_controller_spec.rb M src/api/spec/controllers/worker/status_controller_spec.rb Log Message: ----------- Refactor controller specs Change from `subject!/it is_expected` to `before/expect(response)?`: A spec over a controller action has an HTTP request just before the checks. Most of the checks over a controller action use response as the implicit subject. Using subject only in the cases where it is really needed and response in the rest of the cases helps to understand better this pattern used in controller specs. See this pattern in the documentation: https://rspec.info/features/6-1/rspec-rails/controller-specs/controller-spec... Commit: 7c6e5c3f6d47b4702365f281fd47f17714dda627 https://github.com/openSUSE/open-build-service/commit/7c6e5c3f6d47b4702365f2... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M src/api/spec/controllers/distributions_controller_spec.rb M src/api/spec/controllers/person/token_controller_spec.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/staging/excluded_requests_controller_spec.rb M src/api/spec/controllers/staging/staging_projects_controller_spec.rb M src/api/spec/controllers/status_messages_controller_spec.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/binaries_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/staging/projects_controller_spec.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb M src/api/spec/controllers/webui/status_messages_controller_spec.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/controllers/webui/users/tokens_controller_spec.rb Log Message: ----------- Autocorrect RSpec/LeadingSubject RuboCop offenses... ... in spec/controllers/ Commit: a167bfd378bba55be812e2f29ee4f19d688711fc https://github.com/openSUSE/open-build-service/commit/a167bfd378bba55be812e2... Author: Eduardo J <enavarro@suse.com> Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M src/api/spec/controllers/distributions_controller_spec.rb M src/api/spec/controllers/group_controller_spec.rb M src/api/spec/controllers/person/token_controller_spec.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/search_controller_spec.rb M src/api/spec/controllers/staging/excluded_requests_controller_spec.rb M src/api/spec/controllers/staging/staging_projects_controller_spec.rb M src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb M src/api/spec/controllers/status/checks_controller_spec.rb M src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/controllers/status_messages_controller_spec.rb M src/api/spec/controllers/trigger_controller_spec.rb M src/api/spec/controllers/webui/architectures_controller_spec.rb M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/controllers/webui/groups/users_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/binaries_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/staging/projects_controller_spec.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb M src/api/spec/controllers/webui/status_messages_controller_spec.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/controllers/webui/users/tokens_controller_spec.rb M src/api/spec/controllers/worker/status_controller_spec.rb Log Message: ----------- Merge pull request #15806 from eduardoj/refactoring/rubocop_offenses_part_3_iii Autocorrect RSpec/LeadingSubject RuboCop offenses, part III Compare: https://github.com/openSUSE/open-build-service/compare/7fc2ddb5db63...a167bf... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
participants (1)
-
Eduardo J.