[openSUSE/open-build-service] 588b49: Replace Staging::ProjectDecorator with a view comp...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 588b496ed18874f5945d07335f4e7e5dd9839504 https://github.com/openSUSE/open-build-service/commit/588b496ed18874f5945d07... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2021-10-26 (Tue, 26 Oct 2021) Changed paths: A src/api/app/components/staging_project_link_component.html.haml A src/api/app/components/staging_project_link_component.rb R src/api/app/decorators/base_decorator.rb R src/api/app/decorators/staging/project_decorator.rb M src/api/app/views/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui/staging/workflows/_overall_state.html.haml M src/api/app/views/webui/staging/workflows/_staging_project.html.haml A src/api/spec/components/staging_project_link_component_spec.rb R src/api/spec/decorators/staging/project_decorator_spec.rb Log Message: ----------- Replace Staging::ProjectDecorator with a view component While this could have been a helper, this code is better encapsulated in a view component. The specs are a tiny bit faster now since we don't rely on actual database records. It's about 0.3 second faster in my development environment. I know... wow! Commit: ab3818407dbf376b28b0cd565a69e2ac43fc337e https://github.com/openSUSE/open-build-service/commit/ab3818407dbf376b28b0cd... Author: Victor Pereira <vpereira@suse.de> Date: 2021-10-26 (Tue, 26 Oct 2021) Changed paths: A src/api/app/components/staging_project_link_component.html.haml A src/api/app/components/staging_project_link_component.rb R src/api/app/decorators/base_decorator.rb R src/api/app/decorators/staging/project_decorator.rb M src/api/app/views/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui/staging/workflows/_overall_state.html.haml M src/api/app/views/webui/staging/workflows/_staging_project.html.haml A src/api/spec/components/staging_project_link_component_spec.rb R src/api/spec/decorators/staging/project_decorator_spec.rb Log Message: ----------- Merge pull request #11783 from dmarcoux/remove-staging-project-decorator Replace Staging::ProjectDecorator with a view component Compare: https://github.com/openSUSE/open-build-service/compare/07f142dafdee...ab3818...
participants (1)
-
Victor Pereira