[openSUSE/open-build-service] d54e74: Do not rely on named scope chain for PackagesFinder
Branch: refs/heads/next_rails-8 Home: https://github.com/openSUSE/open-build-service Commit: d54e74538a8ae067c0cf91928ee7c8728555d751 https://github.com/openSUSE/open-build-service/commit/d54e74538a8ae067c0cf91... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/backend_package.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Do not rely on named scope chain for PackagesFinder Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. As a result of this, every chained usage of the scope "dirty_backend_package" resulted in unexpected/wrong results. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: a57cf094207cdb13d7fe14d12989edb1720b196d https://github.com/openSUSE/open-build-service/commit/a57cf094207cdb13d7fe14... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb M src/api/app/queries/projects_with_image_templates_finder.rb Log Message: ----------- Fix deprecation warning for "local_image_templates" scope Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. Since the mentioned scope is only used in one place, we can simply drop it in order to get rid of the deprecation warning. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: 555e315237021eb43a6e4c85a619edfe809f3b57 https://github.com/openSUSE/open-build-service/commit/555e315237021eb43a6e4c... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb R src/api/app/queries/projects_with_delegate_request_target_finder.rb R src/api/spec/queries/projects_with_delegate_request_target_finder_spec.rb Log Message: ----------- Remove unused "delegates_requests" scope This scope and the corresponding query object were never used Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: bf5590119bcbad730ff0c63b2ddc21a7c0357aa9 https://github.com/openSUSE/open-build-service/commit/bf5590119bcbad730ff0c6... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Fix deprecation warning for "very_important_projects_with_attributes" scope Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. Since the mentioned scope is only used in one place, we can simply drop it in order to get rid of the deprecation warning. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Compare: https://github.com/openSUSE/open-build-service/compare/d54e74538a8a%5E...bf5...
participants (1)
-
Lukas Krause