[obs-commits] [openSUSE/open-build-service] 88e748: [frontend] Remove caching in Package.serviceinfo
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 88e748ec95d416eb768f31c7921962d712bc371a https://github.com/openSUSE/open-build-service/commit/88e748ec95d416eb768f31... Author: Stephan Kulow <coolo@suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/package.rb Log Message: ----------- [frontend] Remove caching in Package.serviceinfo The serviceinfo changes in the backend, caching it in the model is as such not wise. The only place it's called outside of service_info is not using the return value - and was removed Commit: a2bc8ddb51c9a08a90c8c455850238a567ed0fdc https://github.com/openSUSE/open-build-service/commit/a2bc8ddb51c9a08a90c8c4... Author: Stephan Kulow <coolo@suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: A src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml A src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_6_2_1.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml R src/api/spec/cassettes/Package/_service_error/without_error/1_6_1_1.yml M src/api/spec/models/package_spec.rb Log Message: ----------- [ci] Fix the service_error test to poll state The old cassette shows the problem: code: 400 message: revision is empty If you commit a _service and try to fetch the service_error right afterwards, you might not have a serviceinfo beside 'running', so we need to wait a little. Unfortunately we can't use cmd=waitservice for this test as it throws an error for invalid services - which is what we want to test Commit: 0aa7fb9ae59b7923e680539bf5888c546f281d89 https://github.com/openSUSE/open-build-service/commit/0aa7fb9ae59b7923e68053... Author: Stephan Kulow <coolo@suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/models/package.rb A src/api/spec/cassettes/Package/_service_error/returns_nil_on_running.yml M src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml M src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml M src/api/spec/models/package_spec.rb Log Message: ----------- [ci] Stub the backend calls for service_error This way we don't need to start a race with the backend to test the model code. Commit: 10a91ac5a49b0125bc747ce9e85e9caf40e3510a https://github.com/openSUSE/open-build-service/commit/10a91ac5a49b0125bc747c... Author: Stephan Kulow <stephan@kulow.org> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/package.rb A src/api/spec/cassettes/Package/_service_error/returns_nil_on_running.yml A src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml A src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_6_2_1.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml R src/api/spec/cassettes/Package/_service_error/without_error/1_6_1_1.yml M src/api/spec/models/package_spec.rb Log Message: ----------- Merge pull request #5259 from coolo/fix_serviceinfo Fix service_error test blinking (without cassettes) Compare: https://github.com/openSUSE/open-build-service/compare/4177f497e025...10a91a... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Stephan Kulow