[obs-commits] [openSUSE/open-build-service] 4ca319: Add columns rss and web to notifications table
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4ca31916d654d942592c1f741b79b8d58339f30c https://github.com/openSUSE/open-build-service/commit/4ca31916d654d942592c1f... Author: David Kang <dkang@suse.com> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: A src/api/db/migrate/20200422134122_add_rss_and_web_to_notification.rb M src/api/db/structure.sql Log Message: ----------- Add columns rss and web to notifications table Commit: f722f98fd7505f1fc41758666c7b39d2d56171cb https://github.com/openSUSE/open-build-service/commit/f722f98fd7505f1fc41758... Author: David Kang <dkang@suse.com> Date: 2020-04-27 (Mon, 27 Apr 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/event/base.rb M src/api/app/models/event_subscription/find_for_event.rb M src/api/app/services/notification_creator.rb M src/api/spec/db/data/regenerate_notifications_spec.rb M src/api/spec/jobs/send_event_emails_job_spec.rb M src/api/spec/services/notification_creator_spec.rb Log Message: ----------- Adapt NotificationCreator and Job to handle new channels We need to adapt `SendEventEmailsJob` job the send emails and notifications for the enabled channels (rss and web). Commit: f7353bb65992e8b65255a3e266b39dcf628376b5 https://github.com/openSUSE/open-build-service/commit/f7353bb65992e8b65255a3... Author: David Kang <dkang@suse.com> Date: 2020-04-27 (Mon, 27 Apr 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/group.rb M src/api/app/models/notification.rb M src/api/app/models/user.rb M src/api/app/services/notification_creator.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/factories/notification.rb M src/api/spec/models/user_spec.rb Log Message: ----------- Use Notification instead of Notification::RssFeedItem We plan to remove the column type from `Notification` and remove the class `Notification::RssFeedItem` and only use Notification class. The first step is not use this class anymore. After that we should create a migration to remove the column type and get rid the class `Notification::RssFeedItem`. For that we created new `scopes` to fetch the notifications for the different channels. Commit: 832241d58fc53ffd1361b8f8eaab92f06abd85f3 https://github.com/openSUSE/open-build-service/commit/832241d58fc53ffd1361b8... Author: David Kang <dkang@suse.com> Date: 2020-04-27 (Mon, 27 Apr 2020) Changed paths: A src/api/db/data/20200424080753_generate_web_notifications.rb M src/api/db/data_schema.rb A src/api/spec/db/data/generate_web_notifications_spec.rb Log Message: ----------- Add data migration for generate EventSubscriptions We generate EventSubscriptions for `rss` and `web` channels if we found a EventSubscription enabled (channel == :instant_email). Commit: 90847a2aecf00d8e56564a08ce8520cd41f92173 https://github.com/openSUSE/open-build-service/commit/90847a2aecf00d8e56564a... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2020-04-27 (Mon, 27 Apr 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/event/base.rb M src/api/app/models/event_subscription/find_for_event.rb M src/api/app/models/group.rb M src/api/app/models/notification.rb M src/api/app/models/user.rb M src/api/app/services/notification_creator.rb A src/api/db/data/20200424080753_generate_web_notifications.rb M src/api/db/data_schema.rb A src/api/db/migrate/20200422134122_add_rss_and_web_to_notification.rb M src/api/db/structure.sql M src/api/spec/controllers/webui/users/notifications_controller_spec.rb A src/api/spec/db/data/generate_web_notifications_spec.rb M src/api/spec/db/data/regenerate_notifications_spec.rb M src/api/spec/factories/notification.rb M src/api/spec/jobs/send_event_emails_job_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/services/notification_creator_spec.rb Log Message: ----------- Merge pull request #9430 from DavidKang/notification/jobs-and-user-notification Adapt Job to handle new notification channels Compare: https://github.com/openSUSE/open-build-service/compare/8660152a4d1c...90847a...
participants (1)
-
Henne Vogelsang