Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6d995c1ed4ada01ac5b5795da03f82206c3528fb https://github.com/openSUSE/open-build-service/commit/6d995c1ed4ada01ac5b579... Author: Eduardo Navarro Date: 2019-12-03 (Tue, 03 Dec 2019) Changed paths: M src/api/app/models/issue_tracker.rb M src/api/app/models/issue_tracker/issue_tracker_helper.rb M src/api/spec/models/issue_tracker/issue_tracker_helper_spec.rb Log Message: ----------- Remove no longer used cve? methods in issue trackers These methods were used before for issue tracker name validations. They are not used any more. Commit: 3ab4407d91e8ff21ba08636ea0f524d94dc57a73 https://github.com/openSUSE/open-build-service/commit/3ab4407d91e8ff21ba0863... Author: Eduardo Navarro Date: 2019-12-03 (Tue, 03 Dec 2019) Changed paths: M src/api/app/models/issue_tracker/issue_tracker_helper.rb M src/api/spec/models/issue_tracker/issue_tracker_helper_spec.rb Log Message: ----------- Remove not used bug method in IssueTracker::IssueTrackerHelper It was only used in the tests. So those tests are removed also. Commit: 881bfe49bdec75cd1daeaffffe367a0a3820c1e4 https://github.com/openSUSE/open-build-service/commit/881bfe49bdec75cd1daeaf... Author: Eduardo Navarro Date: 2019-12-03 (Tue, 03 Dec 2019) Changed paths: M src/api/app/models/issue_tracker/issue_summary.rb M src/api/spec/models/issue_tracker/issue_summary_spec.rb Log Message: ----------- Move 'bug' method from IssueSummary to private section It was only used in the tests, so no need to make it public. The tests were adapted to test the 'belongs_bug_to_tracker?' method, wich includes cases for CVE issues. This way the now private 'bug' method is indirectly tested. Commit: 6a59a0382492f8fbcde0ba9ca8f3695304c353b0 https://github.com/openSUSE/open-build-service/commit/6a59a0382492f8fbcde0ba... Author: Eduardo Navarro Date: 2019-12-04 (Wed, 04 Dec 2019) Changed paths: M src/api/app/models/issue.rb A src/api/app/models/issue/errors.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/patchinfo.rb M src/api/test/unit/patchinfo_test.rb Log Message: ----------- Get rid of 'valid_issue_name?' in IssueTracker... ... and make use of 'valid_name?' validation from Issue. Also replace IssueTracker::InvalidIssueName exception with Issue::InvalidName. And move all the issue exceptions to its own concern, for better code structure and readibility. We moved the issues' name validation from the IssueTracker model to the Issue model. We unify two methods that did the same name validation. Co-authored-by: Saray Cabrera Padrón Commit: adb8d9b7d0fe9f2f98f3468df20d35510273e780 https://github.com/openSUSE/open-build-service/commit/adb8d9b7d0fe9f2f98f346... Author: Eduardo Navarro Date: 2019-12-04 (Wed, 04 Dec 2019) Changed paths: M src/api/app/models/issue.rb M src/api/app/models/patchinfo.rb Log Message: ----------- Remove unneeded 'valid_name?' public method 'valid_name?' had the same code as the validation method for an issue, so we can ask directly for an issue to be valid with the same result and get rid of 'valid_name?'. This method is also not used in any other place of the application. Co-authored-by: Saray Cabrera Padrón Commit: fb96235f229e812a72342a7210e2a5d4a967d40a https://github.com/openSUSE/open-build-service/commit/fb96235f229e812a72342a... Author: Victor Pereira Date: 2019-12-04 (Wed, 04 Dec 2019) Changed paths: M src/api/app/models/issue.rb A src/api/app/models/issue/errors.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/issue_tracker/issue_summary.rb M src/api/app/models/issue_tracker/issue_tracker_helper.rb M src/api/app/models/patchinfo.rb M src/api/spec/models/issue_tracker/issue_summary_spec.rb M src/api/spec/models/issue_tracker/issue_tracker_helper_spec.rb M src/api/test/unit/patchinfo_test.rb Log Message: ----------- Merge pull request #8832 from eduardoj/remove_unused_cve_methods Refactor code related to issue models Compare: https://github.com/openSUSE/open-build-service/compare/d5819c0efce3...fb9623...