Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d7470205cce4d71c26ed9016a2bac37af178dfcc https://github.com/openSUSE/open-build-service/commit/d7470205cce4d71c26ed90... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- Trigger error via controller test When sending a group update with a bad xml, the controller crashes. Commit: 680cf8beebaba1e0e6e28427b62966fd3e87e701 https://github.com/openSUSE/open-build-service/commit/680cf8beebaba1e0e6e284... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/app/controllers/group_controller.rb M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- Raise a propper error when the xml is invalid Instead of crashing, we now raise an InvalidParameterError when receiving an invalid XML when trying to update a group. Commit: dd686eae5f3aa1b0239a133755dc360d083bbc03 https://github.com/openSUSE/open-build-service/commit/dd686eae5f3aa1b0239a13... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/app/controllers/group_controller.rb M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- Use Suse::Validator for xml validation Commit: e70434927b61ea3923823c82810d585349db0e49 https://github.com/openSUSE/open-build-service/commit/e70434927b61ea3923823c... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/app/controllers/group_controller.rb M src/api/test/functional/group_test.rb Log Message: ----------- Use validation helpers to do the validation declaratively Commit: 572a7c89fc1a6cba4846f818590c86c010304cc5 https://github.com/openSUSE/open-build-service/commit/572a7c89fc1a6cba4846f8... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- Remove redundant let Commit: 3e47931314c64355b9e1f2fb7fe278d67119d7d4 https://github.com/openSUSE/open-build-service/commit/3e47931314c64355b9e1f2... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/test/functional/group_test.rb Log Message: ----------- Use the already loaded fixtures Commit: ab5d4257aa2c20355ec85adf7243eb9a09a5ccce https://github.com/openSUSE/open-build-service/commit/ab5d4257aa2c20355ec85a... Author: Dani Donisa <dani.doni@gmail.com> Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M src/api/app/controllers/group_controller.rb M src/api/spec/controllers/group_controller_spec.rb M src/api/test/functional/group_test.rb Log Message: ----------- Merge pull request #16531 from danidoni/fix-error-when-processing-bad-group-updates-via-xml Fix error when processing bad group updates via xml Compare: https://github.com/openSUSE/open-build-service/compare/c064df7f1573...ab5d42... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications