[obs-commits] [openSUSE/open-build-service] 952614: [api] Introduce scope for assigned and unassigned ...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9526146aaa40f9dc6daa8b27d9219b5a84bd2332 https://github.com/openSUSE/open-build-service/commit/9526146aaa40f9dc6daa8b... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/review.rb A src/api/spec/factories/history_elements.rb A src/api/spec/factories/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [api] Introduce scope for assigned and unassigned reviews Use case of this is when e.g. maintenance group assigns a review to a user, the new review should not be displayed in maintenance statistics. Only the original one is of interested for them. Commit: 56aa591d6c7cc880af6d82c77e9e66d1a8401ce9 https://github.com/openSUSE/open-build-service/commit/56aa591d6c7cc880af6d82... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/review.rb A src/api/db/migrate/20170118091131_add_review_id_to_review.rb M src/api/db/structure.sql M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [api] Implements accepted_at time for Review objects Calculates the Review#accepted_at timestamp. Returns the accepted_at time based on the Review#state and Review#updated_at timestamp. However, if a Group review (e.g. maintenance group) gets assigned to a user, the accepted_at time is taken from the assigned user review and not from the group review. Commit: 70200a94e3263f8e0f006a1efc2a8f53686b363d https://github.com/openSUSE/open-build-service/commit/70200a94e3263f8e0f006a... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: A src/api/app/controllers/statistics/maintenance_incidents_controller.rb A src/api/app/models/maintenance_statistic.rb M src/api/app/models/review.rb A src/api/app/views/statistics/maintenance_incidents/_issue_created.xml.builder A src/api/app/views/statistics/maintenance_incidents/_project_created.xml.builder A src/api/app/views/statistics/maintenance_incidents/_release_request_accepted.xml.builder A src/api/app/views/statistics/maintenance_incidents/_release_request_created.xml.builder A src/api/app/views/statistics/maintenance_incidents/_review_accepted.xml.builder A src/api/app/views/statistics/maintenance_incidents/_review_opened.xml.builder A src/api/app/views/statistics/maintenance_incidents/show.xml.builder M src/api/config/routes.rb M src/api/spec/models/bs_request_spec.rb A src/api/spec/models/maintenance_statistic_spec.rb Log Message: ----------- [api] Implements MaintenanceRelease workflow statistics This feature is basically covered in fate#319971. The action is used to calculate a KPI statistic for maintenance It exposes the maintenance project, issues, reviews and requests data. WIP tests Commit: 2226d61e79759805ef61d9bceaf00030ad0c9b20 https://github.com/openSUSE/open-build-service/commit/2226d61e79759805ef61d9... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [api] Review model: add validation and unit tests Commit: 53a510e2c01309cb7ef00769a451936e206ccb7d https://github.com/openSUSE/open-build-service/commit/53a510e2c01309cb7ef007... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/spec/factories/history_elements.rb A src/api/spec/factories/issue.rb A src/api/spec/factories/issue_tracker.rb A src/api/spec/factories/package_issue.rb M src/api/spec/models/maintenance_statistic_spec.rb Log Message: ----------- [api] finish spec for MaintenanceStatistic Commit: d8d52c223436b66c12829672c8d3d9ffd0ad8296 https://github.com/openSUSE/open-build-service/commit/d8d52c223436b66c128296... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: A src/api/spec/controllers/statistics/maintenance_incidents_controller_spec.rb M src/api/spec/models/maintenance_statistic_spec.rb M src/api/spec/spec_helper.rb A src/api/spec/support/shared_contexts/a_project_with_maintenance_statistics.rb Log Message: ----------- [ci] add spec for Statistics::MaintenanceIncidentsController Commit: 718ed2a033f0345f39ac574be54cb8648d44f44b https://github.com/openSUSE/open-build-service/commit/718ed2a033f0345f39ac57... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [api] fix Review#validate_non_symmetric_assignment spec Commit: af785344d8028e29f31a2dc0747c10d18755fcba https://github.com/openSUSE/open-build-service/commit/af785344d8028e29f31a2d... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/spec/models/review_spec.rb Log Message: ----------- [ci] add more test cases for Review#accepted_at Commit: 124e7e12ce8dcf41b24f5624135d1fe105ee7152 https://github.com/openSUSE/open-build-service/commit/124e7e12ce8dcf41b24f56... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/maintenance_statistic.rb M src/api/app/models/review.rb M src/api/spec/factories/package_issue.rb M src/api/spec/models/maintenance_statistic_spec.rb M src/api/spec/models/review_spec.rb M src/api/spec/support/shared_contexts/a_project_with_maintenance_statistics.rb Log Message: ----------- [api] fix MaintenanceStatistic type for history elements [api] rubocop fixes Commit: fa326deef24e45f0d2b5cbdf28723d45089c9f65 https://github.com/openSUSE/open-build-service/commit/fa326deef24e45f0d2b5cb... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/controllers/statistics/maintenance_incidents_controller.rb A src/api/app/decorators/base_decorator.rb A src/api/app/decorators/statistics/maintenance_statistic_decorator.rb R src/api/app/views/statistics/maintenance_incidents/_issue_created.xml.builder R src/api/app/views/statistics/maintenance_incidents/_project_created.xml.builder R src/api/app/views/statistics/maintenance_incidents/_release_request_accepted.xml.builder R src/api/app/views/statistics/maintenance_incidents/_release_request_created.xml.builder R src/api/app/views/statistics/maintenance_incidents/_review_accepted.xml.builder R src/api/app/views/statistics/maintenance_incidents/_review_opened.xml.builder M src/api/app/views/statistics/maintenance_incidents/show.xml.builder M src/api/spec/controllers/statistics/maintenance_incidents_controller_spec.rb Log Message: ----------- [api] use a decorator class to determine which MaintenanceStatistic attributes to render in the view Commit: 7bc9369807c3591ffce78e1c5ffc1ee4bdae4b89 https://github.com/openSUSE/open-build-service/commit/7bc9369807c3591ffce78e... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: R src/api/app/controllers/statistics/maintenance_incidents_controller.rb A src/api/app/controllers/statistics/maintenance_statistics_controller.rb R src/api/app/views/statistics/maintenance_incidents/show.xml.builder A src/api/app/views/statistics/maintenance_statistics/index.xml.builder M src/api/config/routes.rb R src/api/spec/controllers/statistics/maintenance_incidents_controller_spec.rb A src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb Log Message: ----------- [api] rename MaintenanceIncidentsController#show => MaintenanceStatisticsController#index Commit: 2a601298d09137c5e1531849f11416be8fce2d72 https://github.com/openSUSE/open-build-service/commit/2a601298d09137c5e15318... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: R src/api/app/models/maintenance_statistic.rb A src/api/app/models/statistics/maintenance_statistic.rb R src/api/spec/models/maintenance_statistic_spec.rb A src/api/spec/models/statistics/maintenance_statistic_spec.rb Log Message: ----------- [api] move model MaintenanceStatistic => Statistics::MaintenanceStatistic Commit: 8df57e09d5d816eebe6a7273f57827d196e27269 https://github.com/openSUSE/open-build-service/commit/8df57e09d5d816eebe6a72... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [api] Review#accepted_at now uses the history_element.created_at value instead of review.updated_at Commit: 728db4962a0dcddc7a5824a237066e82b13a74a4 https://github.com/openSUSE/open-build-service/commit/728db4962a0dcddc7a5824... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/db/structure.sql Log Message: ----------- [api] commit db/structure.sql Commit: a5e30bf45d4c23b55d462caf05995fe63c0b273b https://github.com/openSUSE/open-build-service/commit/a5e30bf45d4c23b55d462c... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/spec/models/statistics/maintenance_statistic_spec.rb M src/api/spec/support/shared_contexts/a_project_with_maintenance_statistics.rb Log Message: ----------- [ci] fix MaintenanceStatistic specs Commit: e6c8bc4dcdb2169d542b432a3ea604bd822f1d89 https://github.com/openSUSE/open-build-service/commit/e6c8bc4dcdb2169d542b43... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-01-26 (Thu, 26 Jan 2017) Changed paths: M src/api/app/models/statistics/maintenance_statistic.rb A src/api/app/models/statistics/maintenance_statistics_factory.rb Log Message: ----------- [api] refactor to use a MaintenanceStatisticsFactory class Commit: 13807a00544162f2d0fe5c646209e8ed7a4108fe https://github.com/openSUSE/open-build-service/commit/13807a00544162f2d0fe5c... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/api/app/models/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [api] add Review#declined_at method Commit: 6d7e286a8a45463c5dc01d9530ac3221cf6b4bb9 https://github.com/openSUSE/open-build-service/commit/6d7e286a8a45463c5dc01d... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/api/app/models/statistics/maintenance_statistics_factory.rb M src/api/spec/factories/history_elements.rb M src/api/spec/models/statistics/maintenance_statistic_spec.rb M src/api/spec/support/shared_contexts/a_project_with_maintenance_statistics.rb Log Message: ----------- [api] add :review_declined maintenance statistic Commit: 93124548ba965acef544967888614f0695d3127d https://github.com/openSUSE/open-build-service/commit/93124548ba965acef54496... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/api/app/decorators/statistics/maintenance_statistic_decorator.rb M src/api/app/models/review.rb M src/api/app/models/statistics/maintenance_statistic.rb A src/api/app/models/statistics/maintenance_statistics_collection.rb R src/api/app/models/statistics/maintenance_statistics_factory.rb A src/api/spec/decorators/statistics/maintenance_statistic_decorator.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/statistics/maintenance_statistic_spec.rb Log Message: ----------- [api] refactor code in response to PR feedback Commit: 175ec6653bd86640e9878913753c74600e3b7c26 https://github.com/openSUSE/open-build-service/commit/175ec6653bd86640e98789... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/api/app/models/review.rb Log Message: ----------- [api] refactor Review scopes to use active record query interface instead of plain SQL Commit: dd0f3fa193957ea5a6c4cdc4415c7fa0a7f478ac https://github.com/openSUSE/open-build-service/commit/dd0f3fa193957ea5a6c4cd... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: A src/api/app/controllers/statistics/maintenance_statistics_controller.rb A src/api/app/decorators/base_decorator.rb A src/api/app/decorators/statistics/maintenance_statistic_decorator.rb M src/api/app/models/bs_request.rb M src/api/app/models/review.rb A src/api/app/models/statistics/maintenance_statistic.rb A src/api/app/models/statistics/maintenance_statistics_collection.rb A src/api/app/views/statistics/maintenance_statistics/index.xml.builder M src/api/config/routes.rb A src/api/db/migrate/20170118091131_add_review_id_to_review.rb M src/api/db/structure.sql A src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb A src/api/spec/decorators/statistics/maintenance_statistic_decorator.rb A src/api/spec/factories/history_elements.rb A src/api/spec/factories/issue.rb A src/api/spec/factories/issue_tracker.rb A src/api/spec/factories/package_issue.rb A src/api/spec/factories/review.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/review_spec.rb A src/api/spec/models/statistics/maintenance_statistic_spec.rb M src/api/spec/spec_helper.rb A src/api/spec/support/shared_contexts/a_project_with_maintenance_statistics.rb Log Message: ----------- Merge pull request #2610 from evanrolfe/maint_stats_tests Maintenance Incident KPI statistics Compare: https://github.com/openSUSE/open-build-service/compare/4fff498d1b7c...dd0f3f...
participants (1)
-
Evan Rolfe