[obs-commits] [openSUSE/open-build-service] 8f0753: [api][webui] Enable Style/GuardClause rubocop cop

17 Feb 2017

      Branch: refs/heads/master
  Home:   https://github.com/openSUSE/open-build-service
  Commit: 8f07536b86ac15431639406d7a10013694bf5401
      https://github.com/openSUSE/open-build-service/commit/8f07536b86ac1543163940...
  Author: David Kang <dkang@suse.com>
  Date:   2017-02-16 (Thu, 16 Feb 2017)

  Changed paths:
    M src/api/.rubocop.yml
    M src/api/.rubocop_todo.yml
    M src/api/app/controllers/application_controller.rb
    M src/api/app/controllers/group_controller.rb
    M src/api/app/controllers/message_controller.rb
    M src/api/app/controllers/public_controller.rb
    M src/api/app/controllers/source_controller.rb
    M src/api/app/controllers/tag_controller.rb
    M src/api/app/controllers/webui/attribute_controller.rb
    M src/api/app/controllers/webui/driver_update_controller.rb
    M src/api/app/controllers/webui/groups_controller.rb
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/controllers/webui/patchinfo_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/app/controllers/webui/repositories_controller.rb
    M src/api/app/controllers/webui/request_controller.rb
    M src/api/app/controllers/webui/user_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/helpers/event_mailer_helper.rb
    M src/api/app/helpers/flag_helper.rb
    M src/api/app/helpers/validation_helper.rb
    M src/api/app/helpers/webui/project_helper.rb
    M src/api/app/helpers/webui/request_helper.rb
    M src/api/app/mixins/forbids_anonymous_users.rb
    M src/api/app/mixins/has_attributes.rb
    M src/api/app/mixins/has_relationships.rb
    M src/api/app/mixins/request_source_diff.rb
    M src/api/app/models/attrib.rb
    M src/api/app/models/channel_binary.rb
    M src/api/app/models/full_text_search.rb
    M src/api/app/policies/attrib_policy.rb
    M src/api/db/checker.rb
    M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb
    M src/api/db/migrate/20160321105300_request_counter.rb
    M src/api/lib/activexml/node.rb
    M src/api/lib/activexml/transport.rb
    M src/api/lib/opensuse/backend.rb
    M src/api/lib/opensuse/validator.rb
    M src/api/lib/wizard.rb

  Log Message:
  -----------
  [api][webui] Enable Style/GuardClause rubocop cop

  Commit: 362bdc3a13936dcf07c17ca24c6213975c5336c4
      https://github.com/openSUSE/open-build-service/commit/362bdc3a13936dcf07c17c...
  Author: Evan Rolfe <evanrolfe@gmail.com>
  Date:   2017-02-16 (Thu, 16 Feb 2017)

  Changed paths:
    M src/api/app/models/backend_file.rb
    M src/api/app/models/branch_package.rb
    M src/api/app/models/bs_request.rb
    M src/api/app/models/bs_request_action.rb
    M src/api/app/models/bs_request_action_add_role.rb
    M src/api/app/models/bs_request_action_group.rb
    M src/api/app/models/bs_request_action_maintenance_release.rb
    M src/api/app/models/bs_request_action_set_bugowner.rb
    M src/api/app/models/bs_request_action_submit.rb
    M src/api/app/models/bs_request_permission_check.rb
    M src/api/app/models/buildresult.rb
    M src/api/app/models/configuration.rb
    M src/api/app/models/download_repository.rb
    M src/api/app/models/event/base.rb
    M src/api/app/models/event_subscription.rb
    M src/api/app/models/flag.rb
    M src/api/app/models/group_maintainer.rb
    M src/api/app/models/groups_user.rb
    M src/api/app/models/issue_tracker.rb
    M src/api/app/models/package.rb
    M src/api/app/models/package_build_status.rb
    M src/api/app/models/project.rb
    M src/api/app/models/project/key_info.rb
    M src/api/app/models/relationship.rb
    M src/api/app/models/review.rb
    M src/api/app/models/unregistered_user.rb
    M src/api/app/models/user.rb
    M src/api/app/models/user_ldap_strategy.rb
    M src/api/app/models/wizard_form.rb
    M src/api/test/functional/request_controller_test.rb
    M src/api/test/functional/webui/attributes_test.rb
    M src/api/test/functional/webui/login_test.rb
    M src/api/test/functional/webui/owner_search_test.rb
    M src/api/test/functional/webui/package_edit_source_test.rb
    M src/api/test/functional/webui/package_edit_test.rb
    M src/api/test/functional/webui/patchinfo_controller_test.rb
    M src/api/test/functional/webui/users_test.rb

  Log Message:
  -----------
  [api][webui] Enable Style/GuardClause rubocop cop

  Commit: 2a542a5c4f4469dea57a3829394a148cf123df44
      https://github.com/openSUSE/open-build-service/commit/2a542a5c4f4469dea57a38...
  Author: Evan Rolfe <evanrolfe@gmail.com>
  Date:   2017-02-16 (Thu, 16 Feb 2017)

  Changed paths:
    M src/api/app/controllers/application_controller.rb
    M src/api/app/controllers/public_controller.rb
    M src/api/app/models/issue_tracker.rb

  Log Message:
  -----------
  [webui][api] refactor some lines

  Commit: aa2d0716ef33d0cb8ac68c55ea537e846e345c62
      https://github.com/openSUSE/open-build-service/commit/aa2d0716ef33d0cb8ac68c...
  Author: Evan Rolfe <evanrolfe@gmail.com>
  Date:   2017-02-16 (Thu, 16 Feb 2017)

  Changed paths:
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/mixins/has_relationships.rb

  Log Message:
  -----------
  [webui] remove unecessary returns

  Commit: ce907c3dadfdcf5d21c81bb8d31e8ab3fb02cfda
      https://github.com/openSUSE/open-build-service/commit/ce907c3dadfdcf5d21c81b...
  Author: Evan Rolfe <evanrolfe@gmail.com>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/api/app/controllers/tag_controller.rb
    M src/api/app/controllers/webui/attribute_controller.rb
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/controllers/webui/patchinfo_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/app/controllers/webui/request_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/helpers/event_mailer_helper.rb
    M src/api/app/models/branch_package.rb
    M src/api/app/models/bs_request.rb
    M src/api/app/models/bs_request_action_maintenance_release.rb
    M src/api/app/models/bs_request_permission_check.rb
    M src/api/app/models/buildresult.rb
    M src/api/app/models/download_repository.rb
    M src/api/app/models/issue_tracker.rb
    M src/api/app/models/project.rb
    M src/api/app/models/relationship.rb
    M src/api/app/models/user.rb
    M src/api/test/functional/webui/users_test.rb

  Log Message:
  -----------
  [webui][api] remove empty lines

  Commit: 3a554ed1c4e03862373358b0b9a733ea7f81aede
      https://github.com/openSUSE/open-build-service/commit/3a554ed1c4e03862373358...
  Author: Ana María Martínez Gómez <ammartinez@suse.de>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/api/.rubocop.yml
    M src/api/.rubocop_todo.yml
    M src/api/app/controllers/application_controller.rb
    M src/api/app/controllers/group_controller.rb
    M src/api/app/controllers/message_controller.rb
    M src/api/app/controllers/public_controller.rb
    M src/api/app/controllers/source_controller.rb
    M src/api/app/controllers/tag_controller.rb
    M src/api/app/controllers/webui/attribute_controller.rb
    M src/api/app/controllers/webui/driver_update_controller.rb
    M src/api/app/controllers/webui/groups_controller.rb
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/controllers/webui/patchinfo_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/app/controllers/webui/repositories_controller.rb
    M src/api/app/controllers/webui/request_controller.rb
    M src/api/app/controllers/webui/user_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/helpers/event_mailer_helper.rb
    M src/api/app/helpers/flag_helper.rb
    M src/api/app/helpers/validation_helper.rb
    M src/api/app/helpers/webui/project_helper.rb
    M src/api/app/helpers/webui/request_helper.rb
    M src/api/app/mixins/forbids_anonymous_users.rb
    M src/api/app/mixins/has_attributes.rb
    M src/api/app/mixins/has_relationships.rb
    M src/api/app/mixins/request_source_diff.rb
    M src/api/app/models/attrib.rb
    M src/api/app/models/backend_file.rb
    M src/api/app/models/branch_package.rb
    M src/api/app/models/bs_request.rb
    M src/api/app/models/bs_request_action.rb
    M src/api/app/models/bs_request_action_add_role.rb
    M src/api/app/models/bs_request_action_group.rb
    M src/api/app/models/bs_request_action_maintenance_release.rb
    M src/api/app/models/bs_request_action_set_bugowner.rb
    M src/api/app/models/bs_request_action_submit.rb
    M src/api/app/models/bs_request_permission_check.rb
    M src/api/app/models/buildresult.rb
    M src/api/app/models/channel_binary.rb
    M src/api/app/models/configuration.rb
    M src/api/app/models/download_repository.rb
    M src/api/app/models/event/base.rb
    M src/api/app/models/event_subscription.rb
    M src/api/app/models/flag.rb
    M src/api/app/models/full_text_search.rb
    M src/api/app/models/group_maintainer.rb
    M src/api/app/models/groups_user.rb
    M src/api/app/models/issue_tracker.rb
    M src/api/app/models/package.rb
    M src/api/app/models/package_build_status.rb
    M src/api/app/models/project.rb
    M src/api/app/models/project/key_info.rb
    M src/api/app/models/relationship.rb
    M src/api/app/models/review.rb
    M src/api/app/models/unregistered_user.rb
    M src/api/app/models/user.rb
    M src/api/app/models/user_ldap_strategy.rb
    M src/api/app/models/wizard_form.rb
    M src/api/app/policies/attrib_policy.rb
    M src/api/db/checker.rb
    M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb
    M src/api/db/migrate/20160321105300_request_counter.rb
    M src/api/lib/activexml/node.rb
    M src/api/lib/activexml/transport.rb
    M src/api/lib/opensuse/backend.rb
    M src/api/lib/opensuse/validator.rb
    M src/api/lib/wizard.rb
    M src/api/test/functional/request_controller_test.rb
    M src/api/test/functional/webui/attributes_test.rb
    M src/api/test/functional/webui/login_test.rb
    M src/api/test/functional/webui/owner_search_test.rb
    M src/api/test/functional/webui/package_edit_source_test.rb
    M src/api/test/functional/webui/package_edit_test.rb
    M src/api/test/functional/webui/patchinfo_controller_test.rb
    M src/api/test/functional/webui/users_test.rb

  Log Message:
  -----------
  Merge pull request #2689 from evanrolfe/guard-clause

Guard clause

Compare: https://github.com/openSUSE/open-build-service/compare/8a595f5553f7...3a554e...

Ana María Martínez Gómez

tags

participants (1)