Branch: refs/heads/rubocop Home: https://github.com/openSUSE/open-build-service Commit: fc370e4d7db417c66dea232478ea1238d9870933 https://github.com/openSUSE/open-build-service/commit/fc370e4d7db417c66dea23... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Fix indentation Commit: 42e9fb1ff14bb8f5090392bdfb82ad82e4533de3 https://github.com/openSUSE/open-build-service/commit/42e9fb1ff14bb8f5090392... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Fix indentation Commit: 685dabd51785a70c6d64c948f01542cf7af3ea9b https://github.com/openSUSE/open-build-service/commit/685dabd51785a70c6d64c9... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Refactor open_requests_for method This method is only used by ProjectCreateAutoCleanupRequests. It's not used for any object of Package class. Thus we can remove the code that handles packages. Commit: 5606c368fd9d54fc07f5ff1a9a25dae5205a5151 https://github.com/openSUSE/open-build-service/commit/5606c368fd9d54fc07f5ff... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Replace helper methods and simplify query Since the query is only used once we can run it directly where it's needed. Additional changes: - Removed ordering by ids. We only use the count there anyway. - Count open requests as part of the SQL query. Faster;-) - Combine both queries Commit: ca016c5b554f9cc9a90b2ae21a50afd20d667d83 https://github.com/openSUSE/open-build-service/commit/ca016c5b554f9cc9a90b2a... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Remove superfluous reference The scope is running in the BsRequest class therefore doesn't need to reference bs_requests. Commit: 20923d9c4b3c6faabcf4bc6fbc5f1f174e0b1980 https://github.com/openSUSE/open-build-service/commit/20923d9c4b3c6faabcf4bc... Author: Björn Geuken <bgeuken@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Update scope of bs request model Commit: 5720a5fc911d542729f508dbc8988436912ce09a https://github.com/openSUSE/open-build-service/commit/5720a5fc911d542729f508... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb M src/api/app/models/architecture.rb M src/api/lib/templates/active_record/model/model.rb M src/api/lib/templates/rails/scaffold_controller/controller.rb Log Message: ----------- [webui] Use the templates in the model. Few changes to the templates itself Commit: 2e8e8a4196b09abd69159ce26287fc29d526a19c https://github.com/openSUSE/open-build-service/commit/2e8e8a4196b09abd69159c... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb M src/api/lib/templates/active_record/model/model.rb Log Message: ----------- [webui] Refactored Attrib model. Added "alias" section to model template Commit: a0042c7355c7df39f5019186589e259f509b6e2a https://github.com/openSUSE/open-build-service/commit/a0042c7355c7df39f50191... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb A src/api/app/validators/attrib_allowed_values_validator.rb A src/api/app/validators/attrib_issue_validator.rb A src/api/app/validators/attrib_value_length_validator.rb Log Message: ----------- [webui] Moving validators of Attrib to a file for themselves. Commit: e37de5267a0e69cffcc284546c212ae10004c650 https://github.com/openSUSE/open-build-service/commit/e37de5267a0e69cffcc284... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_value.rb Log Message: ----------- [webui] Refactored AttribValue model Commit: e6509c11bbb4f7b18bb17f785cf9983aa0127d1c https://github.com/openSUSE/open-build-service/commit/e6509c11bbb4f7b18bb17f... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_namespace.rb Log Message: ----------- [webui] Refactored AttribNamespace Commit: b7d9cbf29a680874d54e30f0f071fa037484fb6c https://github.com/openSUSE/open-build-service/commit/b7d9cbf29a680874d54e30... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_type.rb Log Message: ----------- [webui] Refactored AttribType model Commit: 00e75e649e051da809a0257c585282d909a620a7 https://github.com/openSUSE/open-build-service/commit/00e75e649e051da809a025... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/backend_info.rb M src/api/app/models/backend_package.rb Log Message: ----------- [webui] Refactor backend models Commit: 6fcc7eebea0d7ccb8a0ea691773f37d06ed241d0 https://github.com/openSUSE/open-build-service/commit/6fcc7eebea0d7ccb8a0ea6... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/binary_release.rb M src/api/test/unit/binary_release.rb Log Message: ----------- [webui] Refactor Binary Releases model and fix tests for it Commit: f6af1113ae783d70e6728511f713e689ff28c3f1 https://github.com/openSUSE/open-build-service/commit/f6af1113ae783d70e67285... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb M src/api/app/models/attrib_issue.rb M src/api/test/functional/attributes_test.rb Log Message: ----------- [webui] Minor changes in Attrib and fix test for it Commit: 8dc492cba12147004405eee85a99e4e289955989 https://github.com/openSUSE/open-build-service/commit/8dc492cba12147004405ee... Author: Moisés Déniz Alemán <mdeniz@suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb Log Message: ----------- [webui] Use will_save instead of save local variable Commit: 248d64f8266b801e134df174c1fa8f085fba05b0 https://github.com/openSUSE/open-build-service/commit/248d64f8266b801e134df1... Author: chrisbr <cbruckmayer@suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [ci] Fix Style/AlignHash rubocop offences Commit: 2b323d4079ea316e280d8869ee8dcdcc261d56e5 https://github.com/openSUSE/open-build-service/commit/2b323d4079ea316e280d88... Author: chrisbr <cbruckmayer@suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/relationship.rb Log Message: ----------- [ci] Fix RailsCop rubocop offences Commit: ba26e90f22535327208c2e5af8a192da48c32ecd https://github.com/openSUSE/open-build-service/commit/ba26e90f22535327208c2e... Author: chrisbr <cbruckmayer@suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/test/test_helper.rb Log Message: ----------- [ci] Fix LineLength rubocop offences Commit: 032be2f7a8c9154f81046a0a7c81258fdac926ea https://github.com/openSUSE/open-build-service/commit/032be2f7a8c9154f81046a... Author: chrisbr <cbruckmayer@suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/test/functional/maintenance_test.rb M src/api/test/unit/binary_release.rb Log Message: ----------- [ci] Fix AlignParameters rubocop offences Commit: 2d4c2c27b396d1a53cac9c410cacb12f5b58f1cd https://github.com/openSUSE/open-build-service/commit/2d4c2c27b396d1a53cac9c... Author: chrisbr <cbruckmayer@suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/full_text_search.rb Log Message: ----------- [ci] Fix EmptyElse rubocop offences Compare: https://github.com/openSUSE/open-build-service/compare/fc370e4d7db4^...2d4c2c27b396